issue-16 adding DateLiteralConstant to address issue with passing SOQL date literals as strings

Author: James Simone

src/classes/SOQLUtils.cls

@@ -8,6 +8,10 @@ public without sharing class SOQLUtils {
 
     public static String toSOQLString(Object value) {
         if(value == null) return null;
+        else if(value instanceof DateLiteralConstant) {
+            DateLiteralConstant dateLiteral = (DateLiteralConstant) value;
+            return dateLiteral.value;
+        }
         else if(value instanceof Boolean) return String.valueOf((Boolean)value);
         else if(value instanceof Date) return String.valueOf((Date)value);
         else if(value instanceof Datetime) {

src/classes/TaskRepository.cls

@@ -6,6 +6,10 @@ public without sharing class TaskRepository extends SObjectRepository {
         super(TaskRepository.DEFAULT_FIELD_SET);
     }
 
+    public TaskRepository(Boolean returnCommonFields) {
+        super(TaskRepository.DEFAULT_FIELD_SET,returnCommonFields);
+    }
+
     public Task getRecord(Id taskId) {
         return (Task)this
             .whereIdEquals(taskId)
@@ -26,8 +30,7 @@ public without sharing class TaskRepository extends SObjectRepository {
 
     public List<Task> getListOfCreatedSinceLastWeek() {
         return (List<Task>)this
-            .whereFieldGreaterThanOrEqualTo(Schema.Lead.CreatedDate, 'LAST_WEEK')
-            .setAsUpdate()
+            .whereFieldGreaterThanOrEqualTo(Schema.Lead.CreatedDate, new DateLiteralConstant().LAST_WEEK)
             .getQueryResults();
     }
 
@@ -40,6 +43,15 @@ public without sharing class TaskRepository extends SObjectRepository {
             .getQueryResults();
     }
 
+    public List<Task> getListByFieldForWhoIds(Schema.SObjectField field, String value, List<Id> whoIdList) {
+        return (List<Task>)this
+            .whereWhoIdIn(whoIdList)
+            .whereFieldEquals(field,value)
+            .orderBy(Schema.Task.WhoId)
+            .orderBy(Schema.Task.CreatedDate, SObjectRepository.SortOrder.DESCENDING)
+            .getQueryResults();
+    }
+
     public List<Task> searchInAllFields(String searchTerm) {
         return (List<Task>)this
             .whereIsClosed(false)

src/classes/TaskRepository_Tests.cls

@@ -26,7 +26,7 @@ private class TaskRepository_Tests {
     }
 
     @isTest
-    static void getRecord() {
+    static void it_should_return_specific_tasks_by_Id() {
         Task expectedTask = [SELECT Id FROM Task LIMIT 1];
 
         Test.startTest();
@@ -38,7 +38,7 @@ private class TaskRepository_Tests {
     }
 
     @isTest
-    static void getList() {
+    static void it_should_return_tasks_by_list() {
         List<Task> expectedTaskList = [SELECT Id FROM Task];
         List<Id> expectedTaskIdList = new List<Id>(new Map<Id, Task>(expectedTaskList).keySet());
 
@@ -51,7 +51,7 @@ private class TaskRepository_Tests {
     }
 
     @isTest
-    static void getListOfOpenForWhoId() {
+    static void it_should_return_all_open_tasks_by_who_Id() {
         Lead lead = [SELECT Id FROM Lead LIMIT 1];
 
         Map<Id, Task> expectedTaskMap = new Map<Id, Task>([SELECT Id, WhoId FROM Task WHERE WhoId = :lead.Id AND IsClosed = false]);
@@ -70,6 +70,24 @@ private class TaskRepository_Tests {
 
     @isTest
     static void searchInAllFields() {
+    @isTest
+    static void it_should_not_return_a_task_created_more_than_two_weeks_ago_when_querying_for_last_week() {
+        Lead lead = [SELECT Id FROM Lead LIMIT 1];
+
+        Task task = TestDataGenerator.createCommunicationTask(lead.Id, null);
+        task.CreatedDate = (Datetime)System.today().addDays(-15);
+
+        Test.startTest();
+        Map<Id, Task> returnedTaskMap = new Map<Id,Task>(new TaskRepository().getListOfCreatedSinceLastWeek());
+        Test.stopTest();
+
+        for(Task tsk : returnedTaskMap.values()) {
+            System.assertEquals(false,returnedTaskMap.containsKey(task.Id));
+        }
+    }
+
+    @isTest
+    static void it_should_return_appropriate_tasks_when_querying_with_SOSL() {
         String searchTerm = 'thing';
         List<Task> expectedTaskList = (List<Task>)[FIND :searchTerm IN ALL FIELDS RETURNING Task(Id WHERE IsClosed = false)][0];