Skip to content

Commit 0362031

Browse files
author
Jonas Sciangula Street
committed
Merge branch 'fkoester-improved-filesize'
2 parents 5757b3e + c41083c commit 0362031

File tree

6 files changed

+26
-8
lines changed

6 files changed

+26
-8
lines changed

dist/angular-filemanager.min.js

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/js/filters/filters.js

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,4 +18,23 @@
1818
(input.toLocaleString || input.toString).apply(input);
1919
};
2020
}]);
21+
22+
app.filter('humanReadableFileSize', ['$filter', 'fileManagerConfig', function($filter, fileManagerConfig) {
23+
// See https://en.wikipedia.org/wiki/Binary_prefix
24+
var decimalByteUnits = [' kB', ' MB', ' GB', ' TB', 'PB', 'EB', 'ZB', 'YB'];
25+
var binaryByteUnits = ['KiB', 'MiB', 'GiB', 'TiB', 'PiB', 'EiB', 'ZiB', 'YiB'];
26+
27+
return function(input) {
28+
var i = -1;
29+
var fileSizeInBytes = input;
30+
31+
do {
32+
fileSizeInBytes = fileSizeInBytes / 1024;
33+
i++;
34+
} while (fileSizeInBytes > 1024);
35+
36+
var result = fileManagerConfig.useBinarySizePrefixes ? binaryByteUnits[i] : decimalByteUnits[i];
37+
return Math.max(fileSizeInBytes, 0.1).toFixed(1) + ' ' + result;
38+
};
39+
}]);
2140
})(angular);

src/js/providers/config.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,7 @@
3737
},
3838

3939
showSizeForDirectories: false,
40+
useBinarySizePrefixes: false,
4041

4142
previewImagesInModal: true,
4243
enablePermissionsRecursive: true,

src/templates/main-icons.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<div class="iconset clearfix">
22
<div class="col-120" ng-repeat="item in fileNavigator.fileList | filter: query | orderBy: orderProp" ng-show="!fileNavigator.requesting && !fileNavigator.error">
3-
<a href="" class="thumbnail text-center" ng-click="smartClick(item)" ng-right-click="touch(item)" title="{{item.model.name}} ({{item.model.sizeKb()}}kb)">
3+
<a href="" class="thumbnail text-center" ng-click="smartClick(item)" ng-right-click="touch(item)" title="{{item.model.name}} ({{item.model.size | humanReadableFileSize}})">
44
<div class="item-icon">
55
<i class="glyphicon glyphicon-folder-open" ng-show="item.model.type === 'dir'"></i>
66
<i class="glyphicon glyphicon-file" ng-show="item.model.type === 'file'"></i>

src/templates/main-table-modal.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@
3131
</tr>
3232
<tr ng-repeat="item in fileNavigator.fileList | orderBy:predicate:reverse" ng-show="!fileNavigator.requesting && item.model.type === 'dir'">
3333
<td>
34-
<a href="" ng-click="fileNavigator.folderClick(item)" title="{{item.model.name}} ({{item.model.sizeKb()}}kb)">
34+
<a href="" ng-click="fileNavigator.folderClick(item)" title="{{item.model.name}} ({{item.model.size | humanReadableFileSize}})">
3535
<i class="glyphicon glyphicon-folder-close"></i>
3636
{{item.model.name | strLimit : 32}}
3737
</a>

src/templates/main-table.html

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -46,16 +46,14 @@
4646
</tr>
4747
<tr ng-repeat="item in fileNavigator.fileList | filter: {model:{name: query}} | orderBy:predicate:reverse" ng-show="!fileNavigator.requesting">
4848
<td ng-right-click="touch(item)">
49-
<a href="" ng-click="smartClick(item)" title="{{item.model.name}} ({{item.model.sizeKb()}}kb)">
49+
<a href="" ng-click="smartClick(item)" title="{{item.model.name}} ({{item.model.size | humanReadableFileSize}})">
5050
<i class="glyphicon glyphicon-folder-close" ng-show="item.model.type === 'dir'"></i>
5151
<i class="glyphicon glyphicon-file" ng-show="item.model.type === 'file'"></i>
5252
{{item.model.name | strLimit : 64}}
5353
</a>
5454
</td>
5555
<td class="hidden-xs">
56-
<span ng-show="item.model.type !== 'dir' || config.showSizeForDirectories">
57-
{{item.model.sizeKb()}}kb
58-
</span>
56+
{{item.model.size | humanReadableFileSize }}
5957
</td>
6058
<td class="hidden-sm hidden-xs" ng-hide="config.hideDate">
6159
{{item.model.date | formatDate }}

0 commit comments

Comments
 (0)