PR feedback

Signed-off-by: Jon Koops <jonkoops@gmail.com>

Author: jonkoops

.github/release.sh

@@ -18,10 +18,10 @@ LOG=$(git log --format="%s" -1 | grep -Poe "#\d+")
 PR_NUM=${LOG:1}
 
 # for running a dry run
-#pnpm run lerna version --conventional-commits --no-private --yes --no-git-tag-version --no-push
+# pnpm exec lerna version --conventional-commits --no-private --yes --no-git-tag-version --no-push
 
 # for publishing
-pnpm run lerna publish --conventional-commits --create-release=github --no-verify-access --no-private  --yes 2>&1 | tee lerna-output.txt
+pnpm exec lerna publish --conventional-commits --create-release=github --no-verify-access --no-private  --yes 2>&1 | tee lerna-output.txt
 
 if grep -i "Successfully published" lerna-output.txt; # Leave a Github comment
 then

.github/workflows-src/partials/build.yml

@@ -2,13 +2,13 @@
   with:
     node-version: 22
 - run: corepack enable
-- run:pnpm install --immutable
+- run: pnpm install
 # v5 build
 - uses: actions/cache@v4
   id: site-cache
   name: Load webpack cache
   with:
     path: "packages/documentation-site/.cache"
-    key: ${{ runner.os }}-${{ hashFiles('yarn.lock') }}
-- run:pnpm build
+    key: ${{ runner.os }}-${{ hashFiles('pnpm-lock.yaml') }}
+- run: pnpm build
   name: Build docs

.github/workflows/pr-preview.yml

@@ -20,15 +20,15 @@ jobs:
         with:
           node-version: 22
       - run: corepack enable
-      - run:pnpm install --immutable
+      - run: pnpm install
       # build
       - uses: actions/cache@v4
         id: site-cache
         name: Load webpack cache
         with:
           path: "packages/documentation-site/.cache"
-          key: ${{ runner.os }}-${{ hashFiles('yarn.lock') }}
-      - run:pnpm build
+          key: ${{ runner.os }}-${{ hashFiles('pnpm-lock.yaml') }}
+      - run: pnpm build
         name: Build docs
       - run: node .github/upload-preview.js build/patternfly-org/site site
         name: Upload docs

.github/workflows/release.yml

@@ -23,15 +23,15 @@ jobs:
         with:
           node-version: 22
       - run: corepack enable
-      - run:pnpm install --immutable
+      - run: pnpm install
       # v6 build
       - uses: actions/cache@v4
         id: site-cache
         name: Load webpack cache
         with:
           path: "packages/documentation-site/.cache"
-          key: ${{ runner.os }}-site-${{ hashFiles('yarn.lock') }}
-      - run:pnpm build
+          key: ${{ runner.os }}-site-${{ hashFiles('pnpm-lock.yaml') }}
+      - run: pnpm build
         name: Build docs
       - run: .github/release.sh
       - name: Configure AWS Credentials
@@ -46,7 +46,7 @@ jobs:
         name: Check size of docs
       - run: .github/upload-staging.sh
         name: Upload docs to staging
-      - run:pnpm build:extensions
+      - run: pnpm build:extensions
         name: Build extension docs
       - name: Upload extension only docs
         uses: dswistowski/surge-sh-action@v1

.gitignore

@@ -33,13 +33,3 @@ static
 
 size-plugin.json
 **/generated/**/*.js
-
-# Yarn
-# See: https://yarnpkg.com/getting-started/qa#which-files-should-be-gitignored
-.pnp.*
-.yarn/*
-!.yarn/patches
-!.yarn/plugins
-!.yarn/releases
-!.yarn/sdks
-!.yarn/versions

README.md

@@ -4,7 +4,7 @@ The PatternFly Org is the source for the official documentation for PatternFly.
 
 ## Development
 
-Development setup requirespnpm. If you do not already havepnpm installed on your system, see https://yarnpkg.com/getting-started.
+Development setup requires PNPM. If you do not already have PNPM installed on your system, see https://pnpm.io/installation#using-corepack
 
 A Node version 22 or greater is also required.
 
@@ -14,17 +14,23 @@ A Node version 22 or greater is also required.
 
 You can install the NPM dependencies with:
 
-   pnpm install
+```sh
+pnpm install
+```
 
 A local development server at http://localhost:8003 can be started with:
 
-   pnpm start
+```sh
+pnpm start
+```
 
 ### Build
 
 The site can be built with:
 
-   pnpm build
+```sh
+pnpm build
+```
 
 The static assets get copied to build/patternfly-org.
 
@@ -39,7 +45,7 @@ When PatternFly does a release (currently every 3 weeks) this bucket is copied t
 ### Update screenshots
 To update the screenshots (these are the images that you click on to see a full-page demo):
 
-- open a terminal and run `pnpm build &&pnpm serve`
+- open a terminal and run `pnpm build && pnpm serve`
 - in another terminal, run `pnpm screenshots`
 
 Make sure that the version of Chromium you are using is relatively recent. Version 112.0.5614.0 (Developer Build), for example, isn't compatible with the latest versions of PatternFly, and your screenshots will be off.
@@ -50,7 +56,9 @@ Browse the screenshots to make sure that nothing seems super off. You can compar
 
 You might have a dirty file tree with old submodules and folders lying around. You can remove these with:
 
-    git clean -dfx
+```sh
+git clean -dfx
+```
 
 ### Contribute to HTML/CSS
 

lerna.json

@@ -1,5 +1,5 @@
 {
-  "npmClient": "yarn",
+  "npmClient": "pnpm",
   "publishConfig": {
     "access": "public",
     "registry": "https://registry.npmjs.org/"
@@ -10,11 +10,6 @@
       "conventionalCommits": true
     }
   },
-  "packages": [
-    "packages/ast-helpers",
-    "packages/documentation-framework",
-    "packages/documentation-site"
-  ],
   "version": "independent",
   "allowBranch": ["main", "v4", "v5"]
 }

package.json

@@ -1,16 +1,17 @@
 {
-  "name": "patternfly-org---filter",
+  "name": "patternfly-org-workspace",
   "private": true,
   "version": "0.0.1",
   "main": "index.js",
   "license": "MIT",
+  "packageManager": "pnpm@10.6.4+sha512.da3d715bfd22a9a105e6e8088cfc7826699332ded60c423b14ec613a185f1602206702ff0fe4c438cb15c979081ce4cb02568e364b15174503a63c7a8e2a5f6c",
   "scripts": {
     "analyze": "pnpm --filter patternfly-org analyze",
     "develop": "pnpm --filter patternfly-org develop",
-    "develop:extensions": "EXTENSIONS_ONLY=true PRERELEASE=truepnpm develop",
-    "build:analyze": "pnpm --filter patternfly-org build:analyze &&pnpm copy",
-    "build": "pnpm --filter patternfly-org build &&pnpm copy",
-    "build:extensions": "EXTENSIONS_ONLY=true PRERELEASE=truepnpm build",
+    "develop:extensions": "EXTENSIONS_ONLY=true PRERELEASE=true pnpm develop",
+    "build:analyze": "pnpm --filter patternfly-org build:analyze && pnpm copy",
+    "build": "pnpm --filter patternfly-org build && pnpm copy",
+    "build:extensions": "EXTENSIONS_ONLY=true PRERELEASE=true pnpm build",
     "copy": "rm -rf build/patternfly-org/site && mkdir -p build/patternfly-org && cp -r packages/documentation-site/public build/patternfly-org/site",
     "clean": "lerna run clean && rm -rf build",
     "serve": "npx pf-docs-framework serve build/patternfly-org/site",
@@ -22,11 +23,6 @@
     "workflows": "node .github/generate-workflows",
     "test:a11y": "pnpm --filter patternfly-org test:a11y"
   },
-  "--filters": {
-    "packages": [
-      "packages/*"
-    ]
-  },
   "devDependencies": {
     "@octokit/rest": "^19.0.7",
     "@patternfly/patternfly": "^6.1.0",
@@ -41,6 +37,5 @@
   },
   "resolutions": {
     "node-sass": ">=6.0.1"
-  },
-  "packageManager": "pnpm@10.6.4+sha512.da3d715bfd22a9a105e6e8088cfc7826699332ded60c423b14ec613a185f1602206702ff0fe4c438cb15c979081ce4cb02568e364b15174503a63c7a8e2a5f6c"
+  }
 }

packages/documentation-framework/README.md

@@ -8,48 +8,71 @@ We publish this theme [on npm.](https://www.npmjs.com/package/@patternfly/docume
 
 1. @patternfly/documentation-framework
 
-    `npm i --save-dev @patternfly/documentation-framework`
+    ```sh
+    npm i --save-dev @patternfly/documentation-framework
+    ```
 
     or
 
-    `pnpm add -D @patternfly/documentation-framework`
+    ```sh
+    pnpm add --save-dev @patternfly/documentation-framework
+    ```
 
 2. Provide or install the following either as dependencies if you want to use them in your own project, or as devDependencies:
-    ```
+    ```json
     "@patternfly/patternfly": "6.0.0-alpha.205",
     "@patternfly/react-core": "6.0.0-alpha.94",
     "@patternfly/react-table": "6.0.0-alpha.95",
     "@patternfly/react-code-editor": "6.0.0-alpha.94",
     ```
-    `pnpm add -D @patternfly/patternfly @patternfly/react-core @patternfly/react-table @patternfly/react-code-editor`
+    ```sh
+    pnpm add --save-dev @patternfly/patternfly @patternfly/react-core @patternfly/react-table @patternfly/react-code-editor
+    ```
 
 ## First time setup
 
 ### Init documentation project
 
 To get started, you can scaffold out a sample extension docs setup:
 
-`npx pf-docs-framework init --name "My extension"`
+```sh
+npx pf-docs-framework init --name "My extension"
+```
 
 If you also want to add relevant script targets to package.json, pass in `--scripts` as well:
 
-`npx pf-docs-framework init --name "My extension" --scripts`
+```sh
+npx pf-docs-framework init --name "My extension" --scripts
+```
 
 ## Usage
 
-For all CLI options, run `npx pf-docs-framework --help`
+For all CLI options, run:
+
+```sh
+npx pf-docs-framework --help
+```
+
+For individual CLI commands, you can also display more information by running:
 
-For individual CLI commands, you can also display more information by running `npx pf-docs-framework <COMMAND> --help`
+```sh
+npx pf-docs-framework <COMMAND> --help
+```
 
 ### Develop docs
 
-`npx pf-docs-framework start`
+```sh
+npx pf-docs-framework start
+```
 
 ### Build docs
 
-`npx pf-docs-framework build all --output public`
+```sh
+npx pf-docs-framework build all --output public
+```
 
-> NOTE: If you have `sideEffects: false` in your package.json, that will prevent the CSS from loading in the documentation production build. Set it to true or remove it to enable the CSS from being loaded.
+> [!NOTE]
+> If you have `sideEffects: false` in your package.json, that will prevent the CSS from loading in the documentation production build. Set it to true or remove it to enable the CSS from being loaded.
 
 ### Publish docs to patternfly.org
 

packages/documentation-site/patternfly-docs/content/get-started/develop.md

@@ -13,7 +13,7 @@ In order to develop with PatternFly, you will need to:
 
 1. [Learn about our design token system](/tokens/about-tokens), which enables you to build interfaces with consistent PatternFly styling, including colors, shadows, spacing, and more.
 
-1. Install a package manager to help you install, update, and configure all necessary PatternFly packages. We recommend [npm](https://nodejs.org/en/download) or [Yarn](https://yarnpkg.com/getting-started).
+1. Install a package manager to help you install, update, and configure all necessary PatternFly packages. We recommend [npm](https://nodejs.org/en/download) or [PNPM](https://pnpm.io/installation).
 
 1. Configure your environment to get started with our [React](#develop-with-react) and/or [HTML/CSS](#develop-with-htmlcss) libraries.