More gracefully handle exceptions during structure analysis

jonpalmisc · jonpalmisc · commit 1dbba5231ff5 · 2022-01-15T10:25:12.000-05:00
Resolves: https://github.com/jonpalmisc/ObjectiveNinja/issues/16
diff --git a/source/StructureAnalyzer.cpp b/source/StructureAnalyzer.cpp
@@ -467,7 +467,13 @@ void StructureAnalyzer::runPrivate()
 AnalysisRecords StructureAnalyzer::run(BinaryViewRef bv)
 {
     StructureAnalyzer analyzer(std::move(bv));
-    analyzer.runPrivate();
+
+    try {
+        analyzer.runPrivate();
+    } catch (...) {
+        LogError("ObjectiveNinja: Exception during structure analysis; please report this issue!");
+        LogError("ObjectiveNinja: Structure analysis failed.");
+    }
 
     return analyzer.m_records;
 }

Original file line number	Diff line number	Diff line change
`@@ -467,7 +467,13 @@ void StructureAnalyzer::runPrivate()`
`467`	`467`	`AnalysisRecords StructureAnalyzer::run(BinaryViewRef bv)`
`468`	`468`	`{`
`469`	`469`	`StructureAnalyzer analyzer(std::move(bv));`
`470`		`- analyzer.runPrivate();`
	`470`	`+`
	`471`	`+ try {`
	`472`	`+ analyzer.runPrivate();`
	`473`	`+ } catch (...) {`
	`474`	`+ LogError("ObjectiveNinja: Exception during structure analysis; please report this issue!");`
	`475`	`+ LogError("ObjectiveNinja: Structure analysis failed.");`
	`476`	`+ }`
`471`	`477`
`472`	`478`	`return analyzer.m_records;`
`473`	`479`	`}`