refactor: remove outdated test targets and standardize environment setup

- Removed redundant `test` targets from project configurations.
- Standardized `local` environment naming across documentation and scripts.
- Updated scaffolding templates to reflect changes, ensuring consistency for new projects.
- Simplified CI and workflow scripts by eliminating unnecessary steps.

Author: jonphipps

.github/workflows/nx-optimized-ci.yml

@@ -53,15 +53,9 @@ jobs:
       - name: Install dependencies
         run: pnpm install --no-frozen-lockfile
 
-      - name: Run type checking
-        run: npx nx affected --target=typecheck --parallel=3
-
-      - name: Run linting
-        run: npx nx affected --target=lint --parallel=3
-
-      - name: Build affected projects
+      - name: Build affected projects for deployment validation
         run: npx nx affected --target=build --parallel=3
 
-      - name: Validate deployment configuration
-        run: node scripts/test-site-builds.js --site all --env production --skip-build
+      - name: Run deployment-critical tests
+        run: npx nx affected --target=test --parallel=3
 

.husky/pre-push-optimized

@@ -57,7 +57,7 @@ if [ "$BRANCH" = "main" ] || [ "$BRANCH" = "dev" ]; then
 
   # 3. Run configuration validation for all sites (fast, no build)
   echo "⚙️  Validating all site configurations..."
-  node scripts/test-site-builds.js --site all --env localhost --skip-build
+  node scripts/test-site-builds.js --site all --env local --skip-build
   if [ $? -ne 0 ]; then
     echo "❌ Site configuration validation failed."
     exit 1

CLAUDE.md

@@ -8,7 +8,7 @@ This file provides guidance to Claude Code (claude.ai/code) when working with co
 - **Package manager**: Always use `pnpm` (never npm or yarn)
 - **Build single site**: `pnpm build standards/{name}` or `nx build {name}`
 - **Start dev server**: `pnpm start:{site}` (e.g., `pnpm start:portal`, `pnpm start:isbdm`)
-- **Test execution**: `pnpm test --skip-nx-cache` (always skip nx cache for tests)
+- **Test execution**: `pnpm test` (uses nx cache for performance with nx-affected)
 - **Type checking**: `pnpm typecheck`
 - **Linting**: `pnpm lint`
 
@@ -29,7 +29,7 @@ This file provides guidance to Claude Code (claude.ai/code) when working with co
 - **Environment-specific**: `nx run standards-dev:e2e:site-validation:production`
 
 #### Build & Configuration Testing
-- **Config validation**: `node scripts/test-site-builds.js --site all --env localhost --skip-build`
+- **Config validation**: `node scripts/test-site-builds.js --site all --env local --skip-build`
 - **Full build tests**: `node scripts/test-site-builds.js --site all --env production`
 - **Affected builds**: `nx run standards-dev:build-affected`
 - **Build validation**: `nx run standards-dev:validate:builds`
@@ -147,6 +147,12 @@ standards-dev/
 - **E2E testing**: Playwright for interface testing when needed
 - **Always test before commits**: Tests must pass before offering to commit
 
+### Scaffolding and Templates
+- **CRITICAL**: Always check and update scaffolding templates when making configuration changes that affect all sites
+- **Template locations**: `scripts/site-template.ts` and `scripts/scaffold-site.ts`
+- **Pattern**: When fixing issues in existing sites, verify the scaffold template doesn't propagate the same issue to future sites
+- **Example**: If removing test targets from existing sites, also remove from site template
+
 ## Test Placement Decision Tree (CRITICAL - Reference When Creating Tests)
 
 **ALWAYS use this decision tree when creating new tests to ensure they run in the correct scenario:**
@@ -261,7 +267,7 @@ const { workspaceRoot, scriptsDir, tmpDir, packagesDir, themeDir } = setupTestPa
 ### Deployment and Build Management
 - **Server coordination**: Ask user to start servers/builds rather than waiting for timeouts
 - **Environment awareness**: Warn when environment isn't set to project root
-- **Nx optimization**: Use `--skip-nx-cache` for reliable test runs
+- **Nx optimization**: Use nx cache for performance; only skip with `--skip-nx-cache` when debugging cache-specific issues
 
 ## Vocabulary and Content Management
 
@@ -391,7 +397,7 @@ nx run standards-dev:validate:builds  # Post-build validation
 
 # Script-based testing
 node scripts/test-site-builds.js --site all --env production
-node scripts/test-site-builds.js --site portal --env localhost --skip-build
+node scripts/test-site-builds.js --site portal --env local --skip-build
 ```
 
 #### Comprehensive Test Suites

TESTING_STRATEGY.md

@@ -119,7 +119,7 @@ nx affected --target=lint --parallel=3
 nx affected --target=test --parallel=3
 
 # Configuration validation only
-node scripts/test-site-builds.js --site all --env localhost --skip-build
+node scripts/test-site-builds.js --site all --env local --skip-build
 
 # Representative build test (if portal affected)
 nx run portal:build
@@ -132,7 +132,7 @@ nx affected --target=test --parallel=3
 nx affected --target=build --parallel=3
 
 # Complete configuration validation
-node scripts/test-site-builds.js --site all --env localhost --skip-build
+node scripts/test-site-builds.js --site all --env local --skip-build
 
 # Critical E2E (if portal affected)
 nx run portal:e2e

developer_notes/build-regression-testing.md

@@ -48,7 +48,7 @@ pnpm test:builds:production # All sites production build
 pnpm test:portal:e2e        # Portal end-to-end testing
 
 # Individual site testing
-node scripts/test-site-builds.js --site ISBDM --env localhost
+node scripts/test-site-builds.js --site ISBDM --env local
 ./scripts/test-portal-builds.sh
 ```
 
@@ -234,7 +234,7 @@ IFLA Standards Site Regression Testing
 
 ### 3. Build Process Tests
 **Location**: `scripts/test-site-builds.js`
-**Command**: `node scripts/test-site-builds.js --site ISBDM --env localhost`
+**Command**: `node scripts/test-site-builds.js --site ISBDM --env local`
 
 #### Build Verification:
 - ✅ **Compilation Success**: All TypeScript/MDX files compile

developer_notes/command-line-scripts/build-with-env.md

@@ -14,12 +14,12 @@ pnpm build --env production --site portal
 # Build all sites for preview environment with theme rebuild
 pnpm build --env preview --site all --clean-theme
 
-# Build single standard for localhost
-pnpm build --env localhost --site isbdm
+# Build single standard for local
+pnpm build --env local --site isbdm
 ```
 
 ### Options
-- `--env` : Environment to build for (localhost, preview, production)
+- `--env` : Environment to build for (local, preview, production)
 - `--site` : Site to build (all, portal, isbdm, lrm, frbr, isbd, muldicat, unimarc)
 - `--clean-theme` : Clean and rebuild theme package before building
 
@@ -35,7 +35,7 @@ pnpm build --env localhost --site isbdm
 1. **Environment Configuration**
    - Sets `DOCS_ENV` environment variable before building
    - This affects how Docusaurus configures URLs and paths
-   - Valid environments: `localhost`, `preview`, `production`
+   - Valid environments: `local`, `preview`, `production`
 
 2. **Interactive Mode**
    - Uses `inquirer` to prompt for missing options
@@ -72,7 +72,7 @@ pnpm build --env localhost --site isbdm
 ### Environment Impact
 
 The `DOCS_ENV` variable affects:
-- **localhost**: baseUrl = '/', url = 'http://localhost:3000'
+- **local**: baseUrl = '/', url = 'http://local:3000'
 - **preview**: baseUrl = '/standards-dev/', url = 'https://iflastandards.github.io'
 - **production**: baseUrl = '/', url = 'https://www.iflastandards.info'
 
@@ -112,7 +112,7 @@ To add new build options:
 **Daily Development**
 ```bash
 # Quick build for testing
-pnpm build --env localhost --site portal
+pnpm build --env local --site portal
 ```
 
 **Before PR/Deployment**

portal/project.json

@@ -43,21 +43,6 @@
       },
       "cache": false
     },
-    "test": {
-      "executor": "@nx/vite:test",
-      "options": {
-        "config": "{workspaceRoot}/vite.config.ts",
-        "testPathPattern": ["{projectRoot}/src/**/*.{test,spec}.{js,ts,jsx,tsx}"]
-      },
-      "outputs": ["{projectRoot}/coverage"],
-      "cache": true,
-      "inputs": [
-        "default",
-        "{projectRoot}/src/**/*.{test,spec}.{js,ts,jsx,tsx}",
-        "{workspaceRoot}/vite.config.ts",
-        "{workspaceRoot}/vitest.config.*"
-      ]
-    },
     "typecheck": {
       "executor": "nx:run-commands",
       "options": {

scripts/site-template.ts

@@ -108,21 +108,6 @@ export const SITE_TEMPLATE = {
         },
         cache: false
       },
-      test: {
-        executor: "@nx/vite:test",
-        options: {
-          config: "{workspaceRoot}/vite.config.ts",
-          testPathPattern: ["{projectRoot}/src/**/*.{test,spec}.{js,ts,jsx,tsx}"]
-        },
-        outputs: ["{projectRoot}/coverage"],
-        cache: true,
-        inputs: [
-          "default",
-          "{projectRoot}/src/**/*.{test,spec}.{js,ts,jsx,tsx}",
-          "{workspaceRoot}/vite.config.ts",
-          "{workspaceRoot}/vitest.config.*"
-        ]
-      },
       typecheck: {
         executor: "nx:run-commands",
         options: {

standards/FRBR/project.json

@@ -43,15 +43,6 @@
       },
       "cache": false
     },
-    "test": {
-      "executor": "@nx/vite:test",
-      "options": {
-        "config": "{workspaceRoot}/vite.config.ts",
-        "testPathPattern": ["{projectRoot}/src/**/*.{test,spec}.{js,ts,jsx,tsx}"]
-      },
-      "outputs": ["{projectRoot}/coverage"],
-      "cache": true
-    },
     "e2e": {
       "executor": "nx:run-commands",
       "options": {

standards/ISBDM/tsconfig.json

@@ -0,0 +1,24 @@
+{
+  "extends": "../../tsconfig.json",
+  "compilerOptions": {
+    "baseUrl": ".",
+    "paths": {
+      "@ifla/theme": ["../../packages/theme/src/index.ts"],
+      "@ifla/theme/*": ["../../packages/theme/src/*"],
+      "@ifla/theme/components": ["../../packages/theme/src/components/index.ts"],
+      "@ifla/theme/components/*": ["../../packages/theme/src/components/*"],
+      "@ifla/theme/config": ["../../packages/theme/src/config/index.ts"],
+      "@ifla/theme/config/*": ["../../packages/theme/src/config/*"],
+      "@ifla/theme/styles": ["../../packages/theme/src/styles/index.css"],
+      "@ifla/theme/utils": ["../../packages/theme/src/utils/index.ts"],
+      "@ifla/theme/utils/*": ["../../packages/theme/src/utils/*"]
+    }
+  },
+  "include": [
+    "src/**/*",
+    "docs/**/*",
+    "docusaurus.config.ts",
+    "sidebars.ts",
+    "navbar.ts"
+  ]
+}