Skip to content

this.success call missing info parameter #16

@pszabop

Description

@pszabop

the this.success callback is missing the info parameter.

This breaks custom handlers as documented here

In my particular use case, I wish to test disabling a Facebook user (e.g. if they are abusive I want to be able to disable them), and I use the custom callback documented here to do so. But I need to be able to respond with a message (e.g. 'suspended account') and the info param is being dropped.

Note related passport-facebook issue.

It's a simple patch to fix this:

passport-mocked/strategy.js:25                                                        

>        var verified = function (e, d, info) { this.success(d, info); }.bind(this);
<        var verified = function (e, d) { this.success(d); }.bind(this);

I can submit a pull request if you wish, I'm not sure how maintenance is done on this project.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions