Skip to content

Commit 13a4768

Browse files
committed
Undertow uppgrade 1.4.15 fix #783
1 parent 2736c94 commit 13a4768

File tree

3 files changed

+23
-28
lines changed

3 files changed

+23
-28
lines changed

coverage-report/src/test/java/org/jooby/issues/Issue418.java

Lines changed: 20 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,24 @@
11
package org.jooby.issues;
22

3-
import com.google.common.collect.ImmutableMap;
3+
import static org.junit.Assert.assertEquals;
4+
import static org.junit.Assert.assertNotNull;
5+
import static org.junit.Assert.assertTrue;
6+
7+
import java.io.IOException;
8+
import java.io.InputStream;
9+
import java.io.OutputStream;
10+
import java.net.InetSocketAddress;
11+
import java.net.Socket;
12+
import java.net.SocketTimeoutException;
13+
import java.nio.ByteBuffer;
14+
import java.nio.charset.StandardCharsets;
15+
import java.util.HashMap;
16+
import java.util.Map;
17+
import java.util.concurrent.CountDownLatch;
18+
import java.util.concurrent.Phaser;
19+
import java.util.concurrent.TimeUnit;
20+
import java.util.concurrent.atomic.AtomicReference;
21+
422
import org.eclipse.jetty.http.HttpFields;
523
import org.eclipse.jetty.http.HttpURI;
624
import org.eclipse.jetty.http.HttpVersion;
@@ -28,24 +46,7 @@
2846
import org.jooby.test.ServerFeature;
2947
import org.junit.Test;
3048

31-
import java.io.IOException;
32-
import java.io.InputStream;
33-
import java.io.OutputStream;
34-
import java.net.InetSocketAddress;
35-
import java.net.Socket;
36-
import java.net.SocketTimeoutException;
37-
import java.nio.ByteBuffer;
38-
import java.nio.charset.StandardCharsets;
39-
import java.util.HashMap;
40-
import java.util.Map;
41-
import java.util.concurrent.CountDownLatch;
42-
import java.util.concurrent.Phaser;
43-
import java.util.concurrent.TimeUnit;
44-
import java.util.concurrent.atomic.AtomicReference;
45-
46-
import static org.junit.Assert.assertEquals;
47-
import static org.junit.Assert.assertNotNull;
48-
import static org.junit.Assert.assertTrue;
49+
import com.google.common.collect.ImmutableMap;
4950

5051
public class Issue418 extends ServerFeature {
5152

jooby-undertow/src/main/java/org/jooby/internal/undertow/UndertowServer.java

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,6 @@
4444
import io.undertow.UndertowOptions;
4545
import io.undertow.server.HttpHandler;
4646
import io.undertow.server.handlers.GracefulShutdownHandler;
47-
import io.undertow.server.protocol.http2.Http2UpgradeHandler;
4847

4948
public class UndertowServer implements org.jooby.spi.Server {
5049

@@ -67,11 +66,7 @@ public UndertowServer(final org.jooby.spi.HttpHandler dispatcher, final Config c
6766

6867
awaitShutdown = conf.getDuration("undertow.awaitShutdown", TimeUnit.MILLISECONDS);
6968
boolean http2 = conf.getBoolean("server.http2.enabled");
70-
HttpHandler handler = doHandler(dispatcher, conf);
71-
if (http2) {
72-
handler = new Http2UpgradeHandler(handler);
73-
}
74-
shutdown = new GracefulShutdownHandler(handler);
69+
shutdown = new GracefulShutdownHandler(doHandler(dispatcher, conf));
7570
Undertow.Builder ubuilder = configure(conf, io.undertow.Undertow.builder())
7671
.addHttpListener(conf.getInt("application.port"),
7772
host(conf.getString("application.host")));
@@ -209,8 +204,7 @@ public void stop() throws Exception {
209204
}
210205

211206
@Override
212-
public Optional<Executor> executor()
213-
{
207+
public Optional<Executor> executor() {
214208
return Optional.ofNullable(server.getWorker());
215209
}
216210

pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2950,7 +2950,7 @@ org.eclipse.jdt.apt.processorOptions/defaultOverwrite=true
29502950
<properties>
29512951
<!-- Dependencies -->
29522952
<jackson.version>2.8.3</jackson.version>
2953-
<undertow.version>1.4.9.Final</undertow.version>
2953+
<undertow.version>1.4.15.Final</undertow.version>
29542954
<servlet.version>3.1.0</servlet.version>
29552955
<jetty.version>9.4.3.v20170317</jetty.version>
29562956
<netty.version>4.1.9.Final</netty.version>

0 commit comments

Comments
 (0)