APT ignores @Inject fields in superclass when generating Mvc route constructors

- fix #3804

Author: jknack

modules/jooby-apt/src/main/java/io/jooby/internal/apt/MvcRouter.java

@@ -196,9 +196,7 @@ private StringBuilder constructors(String generatedName, boolean kt) {
     // Inject could be at constructor or field level.
     var injectConstructor =
         constructors.stream().filter(hasInjectAnnotation()).findFirst().orElse(null);
-    var inject =
-        injectConstructor != null
-            || getTargetType().getEnclosedElements().stream().anyMatch(hasInjectAnnotation());
+    var inject = injectConstructor != null || hasInjectAnnotation(getTargetType());
     final var defaultConstructor =
         constructors.stream().filter(it -> it.getParameters().isEmpty()).findFirst().orElse(null);
     if (inject) {
@@ -306,6 +304,21 @@ private StringBuilder constructors(String generatedName, boolean kt) {
     return trimr(buffer).append(System.lineSeparator());
   }
 
+  private boolean hasInjectAnnotation(TypeElement targetClass) {
+    var inject = false;
+    while (!inject && !targetClass.toString().equals("java.lang.Object")) {
+      // Look up at field/setter injection
+      inject = targetClass.getEnclosedElements().stream().anyMatch(hasInjectAnnotation());
+      targetClass =
+          (TypeElement)
+              context
+                  .getProcessingEnvironment()
+                  .getTypeUtils()
+                  .asElement(getTargetType().getSuperclass());
+    }
+    return inject;
+  }
+
   private static Predicate<Element> hasInjectAnnotation() {
     var injectAnnotations =
         Set.of("javax.inject.Inject", "jakarta.inject.Inject", "com.google.inject.Inject");

modules/jooby-apt/src/test/java/tests/i3804/Base3804.java

@@ -0,0 +1,12 @@
+/*
+ * Jooby https://jooby.io
+ * Apache License Version 2.0 https://jooby.io/LICENSE.txt
+ * Copyright 2014 Edgar Espina
+ */
+package tests.i3804;
+
+import jakarta.inject.Inject;
+
+public class Base3804 {
+  @Inject protected Service3804 paramDecoder;
+}

modules/jooby-apt/src/test/java/tests/i3804/C3804.java

@@ -0,0 +1,18 @@
+/*
+ * Jooby https://jooby.io
+ * Apache License Version 2.0 https://jooby.io/LICENSE.txt
+ * Copyright 2014 Edgar Espina
+ */
+package tests.i3804;
+
+import io.jooby.Context;
+import io.jooby.annotation.GET;
+import io.jooby.annotation.Path;
+
+@Path("/3804")
+public class C3804 extends Base3804 {
+  @GET
+  public Object list(Context ctx) {
+    return paramDecoder; // paramDecoder is null
+  }
+}

modules/jooby-apt/src/test/java/tests/i3804/C3804b.java

@@ -0,0 +1,21 @@
+/*
+ * Jooby https://jooby.io
+ * Apache License Version 2.0 https://jooby.io/LICENSE.txt
+ * Copyright 2014 Edgar Espina
+ */
+package tests.i3804;
+
+import io.jooby.Context;
+import io.jooby.annotation.GET;
+import io.jooby.annotation.Path;
+import jakarta.inject.Inject;
+
+@Path("/3804")
+public class C3804b {
+  @Inject protected Service3804 paramDecoder;
+
+  @GET
+  public Object list(Context ctx) {
+    return paramDecoder; // paramDecoder is null
+  }
+}

modules/jooby-apt/src/test/java/tests/i3804/C3804c.java

@@ -0,0 +1,26 @@
+/*
+ * Jooby https://jooby.io
+ * Apache License Version 2.0 https://jooby.io/LICENSE.txt
+ * Copyright 2014 Edgar Espina
+ */
+package tests.i3804;
+
+import io.jooby.Context;
+import io.jooby.annotation.GET;
+import io.jooby.annotation.Path;
+import jakarta.inject.Inject;
+
+@Path("/3804")
+public class C3804c {
+  private Service3804 paramDecoder;
+
+  @GET
+  public Object list(Context ctx) {
+    return paramDecoder; // paramDecoder is null
+  }
+
+  @Inject
+  public void setParamDecoder(Service3804 paramDecoder) {
+    this.paramDecoder = paramDecoder;
+  }
+}

modules/jooby-apt/src/test/java/tests/i3804/Issue3804.java

@@ -0,0 +1,41 @@
+/*
+ * Jooby https://jooby.io
+ * Apache License Version 2.0 https://jooby.io/LICENSE.txt
+ * Copyright 2014 Edgar Espina
+ */
+package tests.i3804;
+
+import static org.junit.jupiter.api.Assertions.assertTrue;
+
+import org.junit.jupiter.api.Test;
+
+import io.jooby.apt.ProcessorRunner;
+
+public class Issue3804 {
+  @Test
+  public void shouldDetectDIOnFieldsOfBaseClass() throws Exception {
+    new ProcessorRunner(new C3804())
+        .withSourceCode(
+            source -> {
+              assertTrue(source.contains("setup(ctx -> ctx.require(type));"));
+            });
+  }
+
+  @Test
+  public void shouldDetectDIOnFields() throws Exception {
+    new ProcessorRunner(new C3804b())
+        .withSourceCode(
+            source -> {
+              assertTrue(source.contains("setup(ctx -> ctx.require(type));"));
+            });
+  }
+
+  @Test
+  public void shouldDetectDIOnSetter() throws Exception {
+    new ProcessorRunner(new C3804c())
+        .withSourceCode(
+            source -> {
+              assertTrue(source.contains("setup(ctx -> ctx.require(type));"));
+            });
+  }
+}

modules/jooby-apt/src/test/java/tests/i3804/Service3804.java

@@ -0,0 +1,8 @@
+/*
+ * Jooby https://jooby.io
+ * Apache License Version 2.0 https://jooby.io/LICENSE.txt
+ * Copyright 2014 Edgar Espina
+ */
+package tests.i3804;
+
+public class Service3804 {}