output api: rename to buffered output + add buffer options

- update server implementations

Author: jknack

jooby/src/main/java/io/jooby/Context.java

@@ -34,8 +34,8 @@
 import io.jooby.internal.ParamLookupImpl;
 import io.jooby.internal.ReadOnlyContext;
 import io.jooby.internal.WebSocketSender;
-import io.jooby.output.Output;
-import io.jooby.output.OutputFactory;
+import io.jooby.output.BufferedOutput;
+import io.jooby.output.BufferedOutputFactory;
 import io.jooby.value.Value;
 import io.jooby.value.ValueFactory;
 
@@ -145,7 +145,7 @@ private static Selector single() {
    */
   Router getRouter();
 
-  OutputFactory getOutputFactory();
+  BufferedOutputFactory getOutputFactory();
 
   /**
    * Forward executing to another route. We use the given path to find a matching route.
@@ -1312,7 +1312,7 @@ Context responseWriter(
    * @param output Output.
    * @return This context.
    */
-  Context send(@NonNull Output output);
+  Context send(@NonNull BufferedOutput output);
 
   /**
    * Send response data.

jooby/src/main/java/io/jooby/DefaultContext.java

@@ -35,7 +35,7 @@
 import io.jooby.internal.MissingValue;
 import io.jooby.internal.SingleValue;
 import io.jooby.internal.UrlParser;
-import io.jooby.output.OutputFactory;
+import io.jooby.output.BufferedOutputFactory;
 import io.jooby.value.Value;
 import io.jooby.value.ValueFactory;
 
@@ -654,7 +654,7 @@ default Context sendError(@NonNull Throwable cause, @NonNull StatusCode code) {
   }
 
   @Override
-  default OutputFactory getOutputFactory() {
+  default BufferedOutputFactory getOutputFactory() {
     return getRouter().getOutputFactory();
   }
 }

jooby/src/main/java/io/jooby/ForwardingContext.java

@@ -24,8 +24,8 @@
 import edu.umd.cs.findbugs.annotations.NonNull;
 import edu.umd.cs.findbugs.annotations.Nullable;
 import io.jooby.exception.RegistryException;
-import io.jooby.output.Output;
-import io.jooby.output.OutputFactory;
+import io.jooby.output.BufferedOutput;
+import io.jooby.output.BufferedOutputFactory;
 import io.jooby.value.Value;
 import io.jooby.value.ValueFactory;
 
@@ -671,7 +671,7 @@ public Router getRouter() {
   }
 
   @Override
-  public OutputFactory getOutputFactory() {
+  public BufferedOutputFactory getOutputFactory() {
     return ctx.getOutputFactory();
   }
 
@@ -1229,7 +1229,7 @@ public Context send(@NonNull ByteBuffer data) {
   }
 
   @Override
-  public Context send(@NonNull Output output) {
+  public Context send(@NonNull BufferedOutput output) {
     ctx.send(output);
     return this;
   }

jooby/src/main/java/io/jooby/Jooby.java

@@ -51,7 +51,7 @@
 import io.jooby.internal.MutedServer;
 import io.jooby.internal.RegistryRef;
 import io.jooby.internal.RouterImpl;
-import io.jooby.output.OutputFactory;
+import io.jooby.output.BufferedOutputFactory;
 import io.jooby.problem.ProblemDetailsHandler;
 import io.jooby.value.ValueFactory;
 import jakarta.inject.Provider;
@@ -920,12 +920,12 @@ public Jooby setValueFactory(@NonNull ValueFactory valueFactory) {
   }
 
   @NonNull @Override
-  public OutputFactory getOutputFactory() {
+  public BufferedOutputFactory getOutputFactory() {
     return router.getOutputFactory();
   }
 
   @NonNull @Override
-  public Jooby setOutputFactory(@NonNull OutputFactory outputFactory) {
+  public Jooby setOutputFactory(@NonNull BufferedOutputFactory outputFactory) {
     router.setOutputFactory(outputFactory);
     return this;
   }

jooby/src/main/java/io/jooby/MessageEncoder.java

@@ -8,7 +8,7 @@
 import edu.umd.cs.findbugs.annotations.NonNull;
 import edu.umd.cs.findbugs.annotations.Nullable;
 import io.jooby.exception.NotAcceptableException;
-import io.jooby.output.Output;
+import io.jooby.output.BufferedOutput;
 
 /**
  * Render a route output as a byte array.
@@ -36,5 +36,5 @@ public interface MessageEncoder {
    * @return Value as a byte array or <code>null</code> if given object isn't supported it.
    * @throws Exception If something goes wrong.
    */
-  @Nullable Output encode(@NonNull Context ctx, @NonNull Object value) throws Exception;
+  @Nullable BufferedOutput encode(@NonNull Context ctx, @NonNull Object value) throws Exception;
 }

jooby/src/main/java/io/jooby/Router.java

@@ -36,7 +36,7 @@
 import io.jooby.exception.MissingValueException;
 import io.jooby.handler.AssetHandler;
 import io.jooby.handler.AssetSource;
-import io.jooby.output.OutputFactory;
+import io.jooby.output.BufferedOutputFactory;
 import io.jooby.value.ValueFactory;
 import jakarta.inject.Provider;
 
@@ -536,9 +536,9 @@ default Object execute(@NonNull Context context) {
    */
   @NonNull Router setDefaultWorker(@NonNull Executor worker);
 
-  @NonNull OutputFactory getOutputFactory();
+  @NonNull BufferedOutputFactory getOutputFactory();
 
-  @NonNull Router setOutputFactory(@NonNull OutputFactory outputFactory);
+  @NonNull Router setOutputFactory(@NonNull BufferedOutputFactory outputFactory);
 
   /**
    * Attach a filter to the route pipeline.

jooby/src/main/java/io/jooby/Sender.java

@@ -10,7 +10,7 @@
 
 import edu.umd.cs.findbugs.annotations.NonNull;
 import edu.umd.cs.findbugs.annotations.Nullable;
-import io.jooby.output.Output;
+import io.jooby.output.BufferedOutput;
 
 /**
  * Non-blocking sender. Reactive responses use this class to send partial data in a non-blocking
@@ -94,7 +94,7 @@ interface Callback {
    */
   Sender write(@NonNull byte[] data, @NonNull Callback callback);
 
-  Sender write(@NonNull Output output, @NonNull Callback callback);
+  Sender write(@NonNull BufferedOutput output, @NonNull Callback callback);
 
   /** Close the sender. */
   void close();

jooby/src/main/java/io/jooby/ServerOptions.java

@@ -26,6 +26,7 @@
 import edu.umd.cs.findbugs.annotations.NonNull;
 import edu.umd.cs.findbugs.annotations.Nullable;
 import io.jooby.internal.SslContextProvider;
+import io.jooby.output.BufferOptions;
 
 /**
  * Available server options. To load server options from configuration files, just do:
@@ -47,7 +48,7 @@ public class ServerOptions {
   public static final int SERVER_PORT = Integer.parseInt(System.getProperty("server.port", "8080"));
 
   /**
-   * Default application secure port <code>8443</code> or the value of system property <code>
+   * Default application secures port <code>8443</code> or the value of system property <code>
    * server.securePort</code>.
    */
   public static final int SEVER_SECURE_PORT =
@@ -70,9 +71,6 @@ public class ServerOptions {
 
   private static final String LOCAL_HOST = "0.0.0.0";
 
-  /** Buffer size used by server. Usually for reading/writing data. */
-  private int bufferSize = _16KB;
-
   /** Number of available threads, but never smaller than <code>2</code>. */
   public static final int IO_THREADS = Runtime.getRuntime().availableProcessors() * 2;
 
@@ -100,6 +98,8 @@ public class ServerOptions {
   /** Name of server: Jetty, Netty or Undertow. */
   private String server;
 
+  private BufferOptions buffer = BufferOptions.defaults();
+
   /**
    * Maximum request size in bytes. Request exceeding this value results in {@link
    * io.jooby.StatusCode#REQUEST_ENTITY_TOO_LARGE} response. Default is <code>10mb</code>.
@@ -143,8 +143,11 @@ public class ServerOptions {
       if (conf.hasPath("server.name")) {
         options.setServer(conf.getString("server.name"));
       }
-      if (conf.hasPath("server.bufferSize")) {
-        options.setBufferSize(conf.getInt("server.bufferSize"));
+      if (conf.hasPath("server.buffer.size")) {
+        options.buffer.setSize(conf.getInt("server.buffer.size"));
+      }
+      if (conf.hasPath("server.buffer.useDirectBuffers")) {
+        options.buffer.setDirectBuffers(conf.getBoolean("server.buffer.useDirectBuffers"));
       }
       if (conf.hasPath("server.defaultHeaders")) {
         options.setDefaultHeaders(conf.getBoolean("server.defaultHeaders"));
@@ -191,7 +194,7 @@ public String toString() {
       buff.append(", ioThreads: ").append(Optional.ofNullable(ioThreads).orElse(IO_THREADS));
     }
     buff.append(", workerThreads: ").append(getWorkerThreads());
-    buff.append(", bufferSize: ").append(bufferSize);
+    buff.append(", buffer: ").append(getBuffer());
     buff.append(", maxRequestSize: ").append(maxRequestSize);
     buff.append(", httpsOnly: ").append(httpsOnly);
     if (compressionLevel != null) {
@@ -405,24 +408,12 @@ public boolean getDefaultHeaders() {
     return this;
   }
 
-  /**
-   * Server buffer size in bytes. Default is: <code>16kb</code>. Used for reading/writing data.
-   *
-   * @return Server buffer size in bytes. Default is: <code>16kb</code>. Used for reading/writing
-   *     data.
-   */
-  public int getBufferSize() {
-    return bufferSize;
+  public BufferOptions getBuffer() {
+    return buffer;
   }
 
-  /**
-   * Set buffer size.
-   *
-   * @param bufferSize Buffer size.
-   * @return This options.
-   */
-  public @NonNull ServerOptions setBufferSize(int bufferSize) {
-    this.bufferSize = bufferSize;
+  public ServerOptions setBuffer(@NonNull BufferOptions buffer) {
+    this.buffer = buffer;
     return this;
   }
 

jooby/src/main/java/io/jooby/ServerSentMessage.java

@@ -132,7 +132,7 @@ public ServerSentMessage(@NonNull Object data) {
    * @param ctx Web context. To encode complex objects.
    * @return Encoded data.
    */
-  public @NonNull Output encode(@NonNull Context ctx) {
+  public @NonNull BufferedOutput encode(@NonNull Context ctx) {
     try {
       var route = ctx.getRoute();
       var encoder = route.getEncoder();

jooby/src/main/java/io/jooby/TemplateEngine.java

@@ -9,7 +9,7 @@
 import java.util.List;
 
 import edu.umd.cs.findbugs.annotations.NonNull;
-import io.jooby.output.Output;
+import io.jooby.output.BufferedOutput;
 
 /**
  * Template engine renderer. This class renderer instances of {@link ModelAndView} objects. Template
@@ -34,10 +34,10 @@ public interface TemplateEngine extends MessageEncoder {
    * @return Rendered template.
    * @throws Exception If something goes wrong.
    */
-  Output render(Context ctx, ModelAndView<?> modelAndView) throws Exception;
+  BufferedOutput render(Context ctx, ModelAndView<?> modelAndView) throws Exception;
 
   @Override
-  default Output encode(@NonNull Context ctx, @NonNull Object value) throws Exception {
+  default BufferedOutput encode(@NonNull Context ctx, @NonNull Object value) throws Exception {
     // initialize flash and session attributes (if any)
     ctx.flashOrNull();
     ctx.sessionOrNull();