Skip to content

Commit 2998385

Browse files
committed
jetty: JettyServer no longer takes a QueuedThreadPool fix #3590
1 parent ea9a3f7 commit 2998385

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

modules/jooby-jetty/src/main/java/io/jooby/jetty/JettyServer.java

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,6 @@
3030
import com.typesafe.config.Config;
3131
import edu.umd.cs.findbugs.annotations.NonNull;
3232
import io.jooby.*;
33-
import io.jooby.buffer.DataBufferFactory;
3433
import io.jooby.internal.jetty.JettyHandler;
3534
import io.jooby.internal.jetty.JettyHttpExpectAndContinueHandler;
3635
import io.jooby.internal.jetty.http2.JettyHttp2Configurer;
@@ -52,10 +51,11 @@ public class JettyServer extends io.jooby.Server.Base {
5251

5352
private ServerOptions options = new ServerOptions().setServer("jetty").setWorkerThreads(THREADS);
5453
private Consumer<HttpConfiguration> httpConfigurer;
55-
private DataBufferFactory bufferFactory;
5654

57-
public JettyServer(@NonNull DataBufferFactory bufferFactory, @NonNull ThreadPool threadPool) {
58-
this.bufferFactory = bufferFactory;
55+
// TODO: integrate buffer factory with Jetty.
56+
// private DataBufferFactory bufferFactory;
57+
58+
public JettyServer(@NonNull QueuedThreadPool threadPool) {
5959
this.threadPool = threadPool;
6060
}
6161

@@ -91,7 +91,7 @@ public JettyServer configure(Consumer<HttpConfiguration> configurer) {
9191
@NonNull @Override
9292
public io.jooby.Server start(@NonNull Jooby application) {
9393
try {
94-
/** Set max request size attribute: */
94+
/* Set max request size attribute: */
9595
System.setProperty(
9696
"org.eclipse.jetty.server.Request.maxFormContentSize",
9797
Long.toString(options.getMaxRequestSize()));

0 commit comments

Comments
 (0)