open-api: security-scheme don't set a name by default only apiKey requires it

Author: jknack

modules/jooby-openapi/src/main/java/io/jooby/internal/openapi/OpenAPIParser.java

@@ -136,9 +136,6 @@ private static void securitySchemas(OpenAPIExt openapi, List<Map<String, Object>
       annotationList(annotation, "extensions", values -> extensions(values, scheme::addExtension));
       annotationValue(annotation, "flows", flows -> flows(flows, scheme::flows));
 
-      if (scheme.getName() == null || scheme.getName().trim().isEmpty()) {
-        scheme.setName(name);
-      }
       openapi.addSecuritySchemes(name, scheme);
     }
   }

modules/jooby-openapi/src/main/java/io/jooby/internal/openapi/javadoc/JavaDocTag.java

@@ -96,8 +96,7 @@ public static Map<String, SecurityScheme> securitySchemes(DetailNode node) {
               var item = new SecurityScheme();
               item.setDescription((String) hash.get("description"));
               var name = (String) hash.get("name");
-              var paramName = (String) hash.getOrDefault("paramName", name);
-              item.setName(paramName);
+              item.setName((String) hash.get("paramName"));
               ofNullable((String) hash.get("in"))
                   .map(String::toUpperCase)
                   .map(SecurityScheme.In::valueOf)

modules/jooby-openapi/src/test/java/io/jooby/openapi/SecuritySchemeTest.java

@@ -43,7 +43,6 @@ public void shouldParseExtensionFromInfo(OpenAPIResult result) {
             + "  securitySchemes:\n"
             + "    myOauth2Security:\n"
             + "      type: oauth2\n"
-            + "      name: myOauth2Security\n"
             + "      in: header\n"
             + "      flows:\n"
             + "        implicit:\n"

modules/jooby-openapi/src/test/java/issues/i3652/Issue3652.java

@@ -46,7 +46,6 @@ public void shouldGenerateSecuritySchemeFromController(OpenAPIResult result) {
             + "  securitySchemes:\n"
             + "    myBearerToken:\n"
             + "      type: http\n"
-            + "      name: myBearerToken\n"
             + "      in: header\n"
             + "      scheme: bearer\n"
             + "      bearerFormat: JWT\n",

modules/jooby-openapi/src/test/java/issues/i3729/api/SecuritySchemaDocApp.java

@@ -12,7 +12,7 @@
  * Security Scheme.
  *
  * @securityScheme.name myOauth2Security
- * @securityScheme.type oauth2
+ * @securityScheme.type apiKey
  * @securityScheme.in header
  * @securityScheme.paramName X-Auth
  * @securityScheme.flows.implicit.authorizationUrl http://url.com/auth

modules/jooby-openapi/src/test/java/issues/i3729/api/SecuritySchemeDocTest.java

@@ -52,7 +52,7 @@ public void shouldGenerateDocFromMountedApp(OpenAPIResult result) {
             + "components:\n"
             + "  securitySchemes:\n"
             + "    myOauth2Security:\n"
-            + "      type: oauth2\n"
+            + "      type: apiKey\n"
             + "      name: X-Auth\n"
             + "      in: header\n"
             + "      flows:\n"
@@ -63,7 +63,6 @@ public void shouldGenerateDocFromMountedApp(OpenAPIResult result) {
             + "            read:pets: read your pets\n"
             + "    myOauth:\n"
             + "      type: oauth2\n"
-            + "      name: myOauth\n"
             + "      in: header\n"
             + "      flows:\n"
             + "        implicit:\n"