jooby-run: Resource [logback.xml] occurs multiple times on the classpath

- fix  #3793

Author: jknack

modules/jooby-run/src/main/java/io/jooby/internal/run/JoobyModuleFinder.java

@@ -7,8 +7,8 @@
 
 import static java.util.stream.Collectors.joining;
 import static org.jboss.modules.ResourceLoaderSpec.createResourceLoaderSpec;
-import static org.jboss.modules.ResourceLoaders.createJarResourceLoader;
-import static org.jboss.modules.ResourceLoaders.createPathResourceLoader;
+import static org.jboss.modules.ResourceLoaders.*;
+import static org.jboss.modules.filter.PathFilters.not;
 
 import java.io.File;
 import java.io.IOException;
@@ -23,12 +23,7 @@
 import java.util.Set;
 import java.util.jar.JarFile;
 
-import org.jboss.modules.DependencySpec;
-import org.jboss.modules.ModuleDependencySpecBuilder;
-import org.jboss.modules.ModuleFinder;
-import org.jboss.modules.ModuleSpec;
-import org.jboss.modules.PathUtils;
-import org.jboss.modules.ResourceLoaderSpec;
+import org.jboss.modules.*;
 import org.jboss.modules.filter.PathFilters;
 
 import io.jooby.run.JoobyRun;
@@ -73,15 +68,15 @@ private static Path joobyRunHook(Class loader) {
     }
   }
 
-  public static ModuleSpec createModuleSpec(
-      String name, Set<Path> resources, Set<String> dependencies) {
+  public ModuleSpec createModuleSpec(String name, Set<Path> resources, Set<String> dependencies) {
     ModuleSpec.Builder builder = newModule(name, resources);
 
     // dependencies
     for (String dependency : dependencies) {
+      var filter = PathFilters.acceptAll();
       builder.addDependency(
           new ModuleDependencySpecBuilder()
-              .setImportFilter(PathFilters.acceptAll())
+              .setImportFilter(filter)
               .setExportFilter(PathFilters.getMetaInfServicesFilter())
               .setName(dependency)
               .setOptional(false)
@@ -90,7 +85,7 @@ public static ModuleSpec createModuleSpec(
     return builder.create();
   }
 
-  private static ModuleSpec.Builder newModule(String name, Set<Path> resources) {
+  private ModuleSpec.Builder newModule(String name, Set<Path> resources) {
     try {
       ModuleSpec.Builder builder = ModuleSpec.build(name);
       // Add all JDK classes
@@ -102,8 +97,20 @@ private static ModuleSpec.Builder newModule(String name, Set<Path> resources) {
 
       for (Path path : resources) {
         if (Files.isDirectory(path)) {
-          builder.addResourceRoot(
-              ResourceLoaderSpec.createResourceLoaderSpec(createPathResourceLoader(path)));
+          var resourceLoader = createPathResourceLoader(path);
+          if (main.equals(name)) {
+            resourceLoader =
+                createFilteredResourceLoader(
+                    not(
+                        it ->
+                            // remove duplicated log configuration
+                            (it.startsWith("logback") || it.startsWith("log4j"))
+                                    && it.endsWith(".xml")
+                                // remove duplicated configuration
+                                || (it.startsWith("application") && it.endsWith(".conf"))),
+                    resourceLoader);
+          }
+          builder.addResourceRoot(ResourceLoaderSpec.createResourceLoaderSpec(resourceLoader));
         } else {
           builder.addResourceRoot(
               createResourceLoaderSpec(createJarResourceLoader(new JarFile(path.toFile()))));
@@ -117,7 +124,7 @@ private static ModuleSpec.Builder newModule(String name, Set<Path> resources) {
 
   @Override
   public String toString() {
-    return "classes: "
+    return "main: "
         + classes.stream().map(Path::toString).collect(joining(File.pathSeparator))
         + "\nresources: "
         + resources.stream().map(Path::toString).collect(joining(File.pathSeparator))

modules/jooby-run/src/main/java/io/jooby/internal/run/JoobyMultiModuleFinder.java

@@ -16,7 +16,11 @@
 /**
  * The new class loader since 3.x. It creates 3 modules with their own classloader:
  *
- * <p>- classes: project classes - resources: project resources - jars: project dependencies
+ * <ul>
+ *   <li>classes: project classes
+ *   <li>resources: project resources
+ *   <li>jars: project dependencies
+ * </ul>
  *
  * <p>This approach reduce memory footprint allowing fast restart.
  */