worker threads: make sure default max size is 32 fix #916

Author: jknack

jooby/src/main/java/org/jooby/Jooby.java

@@ -3316,36 +3316,37 @@ private Config defaultConfig(final Config conf, final String cpath) {
     String version = Optional.ofNullable(getClass().getPackage().getImplementationVersion())
         .orElse("0.0.0");
     Config defs = ConfigFactory.parseResources(Jooby.class, "jooby.conf")
-        .withValue("contextPath", ConfigValueFactory.fromAnyRef(cpath.equals("/") ? "" : cpath))
-        .withValue("application.name", ConfigValueFactory.fromAnyRef(appname))
-        .withValue("application.version", ConfigValueFactory.fromAnyRef(version))
-        .withValue("application.class", ConfigValueFactory.fromAnyRef(getClass().getName()))
-        .withValue("application.ns", ConfigValueFactory.fromAnyRef(ns))
-        .withValue("application.lang", ConfigValueFactory.fromAnyRef(lang))
-        .withValue("application.tz", ConfigValueFactory.fromAnyRef(tz))
-        .withValue("application.numberFormat", ConfigValueFactory.fromAnyRef(nf))
-        .withValue("server.http2.enabled", ConfigValueFactory.fromAnyRef(http2))
-        .withValue("runtime.processors", ConfigValueFactory.fromAnyRef(processors))
-        .withValue("runtime.processors-plus1", ConfigValueFactory.fromAnyRef(processors + 1))
-        .withValue("runtime.processors-plus2", ConfigValueFactory.fromAnyRef(processors + 2))
-        .withValue("runtime.processors-x2", ConfigValueFactory.fromAnyRef(processors * 2))
-        .withValue("runtime.processors-x4", ConfigValueFactory.fromAnyRef(processors * 4))
-        .withValue("runtime.processors-x8", ConfigValueFactory.fromAnyRef(processors * 8))
-        .withValue("runtime.concurrencyLevel", ConfigValueFactory
-            .fromAnyRef(Math.max(4, processors)));
+        .withValue("contextPath", fromAnyRef(cpath.equals("/") ? "" : cpath))
+        .withValue("application.name", fromAnyRef(appname))
+        .withValue("application.version", fromAnyRef(version))
+        .withValue("application.class", fromAnyRef(getClass().getName()))
+        .withValue("application.ns", fromAnyRef(ns))
+        .withValue("application.lang", fromAnyRef(lang))
+        .withValue("application.tz", fromAnyRef(tz))
+        .withValue("application.numberFormat", fromAnyRef(nf))
+        .withValue("server.http2.enabled", fromAnyRef(http2))
+        .withValue("runtime.processors", fromAnyRef(processors))
+        .withValue("runtime.processors-plus1", fromAnyRef(processors + 1))
+        .withValue("runtime.processors-plus2", fromAnyRef(processors + 2))
+        .withValue("runtime.processors-x2", fromAnyRef(processors * 2))
+        .withValue("runtime.processors-x4", fromAnyRef(processors * 4))
+        .withValue("runtime.processors-x8", fromAnyRef(processors * 8))
+        .withValue("runtime.concurrencyLevel", fromAnyRef(Math.max(4, processors)))
+        .withValue("server.threads.Min", fromAnyRef(Math.max(4, processors)))
+        .withValue("server.threads.Max", fromAnyRef(Math.max(32, processors * 8)));
 
     if (charset != null) {
-      defs = defs.withValue("application.charset", ConfigValueFactory.fromAnyRef(charset.name()));
+      defs = defs.withValue("application.charset", fromAnyRef(charset.name()));
     }
     if (port != null) {
-      defs = defs.withValue("application.port", ConfigValueFactory.fromAnyRef(port.intValue()));
+      defs = defs.withValue("application.port", fromAnyRef(port.intValue()));
     }
     if (securePort != null) {
       defs = defs.withValue("application.securePort",
-          ConfigValueFactory.fromAnyRef(securePort.intValue()));
+          fromAnyRef(securePort.intValue()));
     }
     if (dateFormat != null) {
-      defs = defs.withValue("application.dateFormat", ConfigValueFactory.fromAnyRef(dateFormat));
+      defs = defs.withValue("application.dateFormat", fromAnyRef(dateFormat));
     }
     return defs;
   }

jooby/src/main/resources/org/jooby/jooby.conf

@@ -137,8 +137,8 @@ server {
   }
 
   threads {
-    Min = ${runtime.processors}
-    Max = ${runtime.processors-x8}
+    # Min = Math.max(4, ${runtime.processors})
+    # Max = Math.max(32, ${runtime.processors-x8})
     IdleTimeout = 60s
   }
 

modules/jooby-netty/src/main/java/org/jooby/internal/netty/NettyServer.java

@@ -261,7 +261,6 @@ public class NettyServer implements Server {
   public NettyServer(final HttpHandler dispatcher, final Config config) {
     this.dispatcher = dispatcher;
     this.conf = config;
-    ResourceLeakDetector.setLevel(Level.DISABLED);
   }
 
   @Override
@@ -270,7 +269,7 @@ public void start() throws Exception {
     bossLoop = eventLoop(bossThreads, "boss");
     int workerThreads = conf.getInt("netty.threads.Worker");
     if (workerThreads > 0) {
-      workerLoop = eventLoop(workerThreads, "worker");
+      workerLoop = eventLoop(Math.max(4, workerThreads), "worker");
     } else {
       workerLoop = bossLoop;
     }

modules/jooby-netty/src/test/java/org/jooby/internal/netty/NettyServerTest.java

@@ -240,7 +240,7 @@ public void unknownOption() throws Exception {
   @SuppressWarnings({"unchecked", "rawtypes" })
   @Test
   public void serverWithWorkerEventLoop() throws Exception {
-    Config config = this.config.withValue("netty.threads.Worker", ConfigValueFactory.fromAnyRef(1));
+    Config config = this.config.withValue("netty.threads.Worker", ConfigValueFactory.fromAnyRef(4));
     new MockUnit(HttpHandler.class)
         .expect(parentThreadFactory("nio-boss"))
         .expect(noepoll)
@@ -264,7 +264,7 @@ public void serverWithWorkerEventLoop() throws Exception {
         .expect(unit -> {
           NioEventLoopGroup eventLoop = unit.constructor(NioEventLoopGroup.class)
               .args(int.class, ThreadFactory.class)
-              .build(1, unit.get(DefaultThreadFactory.class));
+              .build(4, unit.get(DefaultThreadFactory.class));
           unit.registerMock(NioEventLoopGroup.class, eventLoop);
 
           Future future = unit.mock(Future.class);
@@ -296,7 +296,7 @@ public void serverWithWorkerEventLoop() throws Exception {
   @SuppressWarnings({"unchecked", "rawtypes" })
   @Test
   public void eventLoopError() throws Exception {
-    Config config = this.config.withValue("netty.threads.Worker", ConfigValueFactory.fromAnyRef(1));
+    Config config = this.config.withValue("netty.threads.Worker", ConfigValueFactory.fromAnyRef(5));
     new MockUnit(HttpHandler.class)
         .expect(parentThreadFactory("nio-boss"))
         .expect(noepoll)
@@ -320,7 +320,7 @@ public void eventLoopError() throws Exception {
         .expect(unit -> {
           NioEventLoopGroup eventLoop = unit.constructor(NioEventLoopGroup.class)
               .args(int.class, ThreadFactory.class)
-              .build(1, unit.get(DefaultThreadFactory.class));
+              .build(5, unit.get(DefaultThreadFactory.class));
           unit.registerMock(NioEventLoopGroup.class, eventLoop);
 
           Future future = unit.mock(Future.class);