Netty: clean/remove dead code

Author: jknack

modules/jooby-netty/src/main/java/io/jooby/internal/netty/NettyContext.java

@@ -106,7 +106,6 @@
 import io.netty.handler.stream.ChunkedStream;
 import io.netty.handler.stream.ChunkedWriteHandler;
 import io.netty.handler.timeout.IdleStateHandler;
-import io.netty.util.ReferenceCounted;
 
 public class NettyContext implements DefaultContext, ChannelFutureListener {
 
@@ -268,7 +267,7 @@ public QueryString query() {
   public Formdata form() {
     if (formdata == null) {
       formdata = Formdata.create(this);
-      decodeForm(req, formdata);
+      decodeForm(formdata);
     }
     return formdata;
   }
@@ -832,8 +831,7 @@ private boolean pendingTasks() {
     return (getSession() != null)
         || (listeners != null)
         || (files != null && files.size() > 0)
-        || (decoder != null)
-        || shouldRelease(req);
+        || (decoder != null);
   }
 
   void destroy(Throwable cause) {
@@ -874,7 +872,6 @@ void destroy(Throwable cause) {
       }
       decoder = null;
     }
-    release(req);
   }
 
   private NettyOutputStream newOutputStream() {
@@ -891,7 +888,7 @@ private FileUpload register(FileUpload upload) {
     return upload;
   }
 
-  private void decodeForm(HttpRequest req, Formdata form) {
+  private void decodeForm(Formdata form) {
     if (decoder == null || decoder instanceof HttpRawPostRequestDecoder) {
       // empty/bad form
       return;
@@ -900,13 +897,12 @@ private void decodeForm(HttpRequest req, Formdata form) {
       while (decoder.hasNext()) {
         HttpData next = (HttpData) decoder.next();
         if (next.getHttpDataType() == InterfaceHttpData.HttpDataType.FileUpload) {
-          ((Formdata) form)
-              .put(
-                  next.getName(),
-                  register(
-                      new NettyFileUpload(
-                          router.getTmpdir(),
-                          (io.netty.handler.codec.http.multipart.FileUpload) next)));
+          form.put(
+              next.getName(),
+              register(
+                  new NettyFileUpload(
+                      router.getTmpdir(),
+                      (io.netty.handler.codec.http.multipart.FileUpload) next)));
         } else {
           form.put(next.getName(), next.getString(UTF_8));
         }
@@ -915,24 +911,7 @@ private void decodeForm(HttpRequest req, Formdata form) {
       // ignore, silly netty
     } catch (Exception x) {
       throw SneakyThrows.propagate(x);
-    } finally {
-      release(req);
-    }
-  }
-
-  private static void release(HttpRequest req) {
-    if (shouldRelease(req)) {
-      ReferenceCounted ref = (ReferenceCounted) req;
-      ref.release();
-    }
-  }
-
-  private static boolean shouldRelease(HttpRequest req) {
-    if (req instanceof ReferenceCounted) {
-      ReferenceCounted ref = (ReferenceCounted) req;
-      return ref.refCnt() > 0;
     }
-    return false;
   }
 
   private long responseLength() {

modules/jooby-netty/src/main/java/io/jooby/internal/netty/NettyHandler.java

@@ -188,13 +188,11 @@ public void exceptionCaught(ChannelHandlerContext ctx, Throwable cause) {
   }
 
   private void offer(NettyContext context, HttpContent chunk) {
-    if (context.decoder != null) {
-      try {
-        context.decoder.offer(chunk);
-      } catch (HttpPostRequestDecoder.ErrorDataDecoderException x) {
-        resetDecoderState(context, true);
-        context.sendError(x, StatusCode.BAD_REQUEST);
-      }
+    try {
+      context.decoder.offer(chunk);
+    } catch (HttpPostRequestDecoder.ErrorDataDecoderException x) {
+      resetDecoderState(context, true);
+      context.sendError(x, StatusCode.BAD_REQUEST);
     }
   }