UtowFileUpload.getFileSize throws exception when "Content-Length" header is missing. fix #1650

Author: jknack

jooby/src/main/java/io/jooby/FileUpload.java

@@ -66,9 +66,9 @@ public interface FileUpload {
   @Nonnull Path path();
 
   /**
-   * File size.
+   * File size or <code>-1</code> when unknown.
    *
-   * @return File size.
+   * @return File size or <code>-1</code> when unknown.
    */
   long getFileSize();
 

modules/jooby-utow/pom.xml

@@ -44,5 +44,11 @@
       <classifier>runtime</classifier>
       <scope>test</scope>
     </dependency>
+
+    <dependency>
+      <groupId>org.mockito</groupId>
+      <artifactId>mockito-core</artifactId>
+      <scope>test</scope>
+    </dependency>
   </dependencies>
 </project>

modules/jooby-utow/src/main/java/io/jooby/internal/utow/UtowFileUpload.java

@@ -59,7 +59,11 @@ public UtowFileUpload(FormData.FormValue upload) {
   }
 
   @Override public long getFileSize() {
-    return Long.parseLong(upload.getHeaders().getFirst(Headers.CONTENT_LENGTH));
+    try {
+      return upload.getFileItem().getFileSize();
+    } catch (IOException x) {
+      return -1;
+    }
   }
 
   @Override public void destroy() {

modules/jooby-utow/src/test/java/io/jooby/internal/utow/UtowFileUploadTest.java

@@ -0,0 +1,40 @@
+package io.jooby.internal.utow;
+
+import io.undertow.server.handlers.form.FormData;
+import org.junit.jupiter.api.Test;
+
+import java.io.IOException;
+
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.mockito.Mockito.doThrow;
+import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.when;
+
+public class UtowFileUploadTest {
+
+  @Test
+  public void shouldGetFileSize() throws IOException {
+    long fileSize = 678;
+
+    FormData.FileItem fileItem = mock(FormData.FileItem.class);
+    when(fileItem.getFileSize()).thenReturn(fileSize);
+
+    FormData.FormValue upload = mock(FormData.FormValue.class);
+    when(upload.getFileItem()).thenReturn(fileItem);
+
+    assertEquals(fileSize, new UtowFileUpload(upload).getFileSize());
+  }
+
+  @Test
+  public void shouldGetUnknownFileSize() throws IOException {
+    long fileSize = -1;
+
+    FormData.FileItem fileItem = mock(FormData.FileItem.class);
+    doThrow(new IOException()).when(fileItem).getFileSize();
+
+    FormData.FormValue upload = mock(FormData.FormValue.class);
+    when(upload.getFileItem()).thenReturn(fileItem);
+
+    assertEquals(fileSize, new UtowFileUpload(upload).getFileSize());
+  }
+}