Route inheritance from base controller no longer works when multiple subclasses extend it (Jooby 4.x vs 1.x)

- ref  #3786

Author: jknack

modules/jooby-apt/src/test/java/tests/i3786/Base3786.java

@@ -0,0 +1,30 @@
+/*
+ * Jooby https://jooby.io
+ * Apache License Version 2.0 https://jooby.io/LICENSE.txt
+ * Copyright 2014 Edgar Espina
+ */
+package tests.i3786;
+
+import io.jooby.Context;
+import io.jooby.annotation.GET;
+import io.jooby.annotation.Path;
+import io.jooby.annotation.QueryParam;
+
+@Path("/base")
+public abstract class Base3786 {
+
+  @GET
+  public String base() {
+    return "base";
+  }
+
+  @GET("/withPath")
+  public String withPath(@QueryParam String q) {
+    return "withPath";
+  }
+
+  @GET("/{id}")
+  public String getOne(Context ctx) {
+    return "base: " + ctx.path("id").value();
+  }
+}

modules/jooby-apt/src/test/java/tests/i3786/C3786.java

@@ -0,0 +1,24 @@
+/*
+ * Jooby https://jooby.io
+ * Apache License Version 2.0 https://jooby.io/LICENSE.txt
+ * Copyright 2014 Edgar Espina
+ */
+package tests.i3786;
+
+import io.jooby.Context;
+import io.jooby.annotation.GET;
+import io.jooby.annotation.POST;
+import io.jooby.annotation.Path;
+
+@Path("/inherited")
+public class C3786 extends Base3786 {
+  @GET("/childOnly")
+  public String childOnly(Context ctx) {
+    return ctx.getMethod() + ctx.getRequestPath();
+  }
+
+  @POST("/childOnly")
+  public String childOnlyPost(Context ctx) {
+    return ctx.getMethod() + ctx.getRequestPath();
+  }
+}

modules/jooby-apt/src/test/java/tests/i3786/D3786.java

@@ -0,0 +1,24 @@
+/*
+ * Jooby https://jooby.io
+ * Apache License Version 2.0 https://jooby.io/LICENSE.txt
+ * Copyright 2014 Edgar Espina
+ */
+package tests.i3786;
+
+import io.jooby.Context;
+import io.jooby.annotation.GET;
+import io.jooby.annotation.POST;
+import io.jooby.annotation.Path;
+
+@Path("/overrideMethod")
+public class D3786 extends Base3786 {
+  @GET("/childOnly")
+  public String childOnly(Context ctx) {
+    return ctx.getRequestPath();
+  }
+
+  @POST("/user")
+  public String newPath(Context q) {
+    return "/overrideMethod/user";
+  }
+}

modules/jooby-apt/src/test/java/tests/i3786/Issue3786.java

@@ -0,0 +1,55 @@
+/*
+ * Jooby https://jooby.io
+ * Apache License Version 2.0 https://jooby.io/LICENSE.txt
+ * Copyright 2014 Edgar Espina
+ */
+package tests.i3786;
+
+import static org.junit.jupiter.api.Assertions.*;
+
+import org.junit.jupiter.api.Test;
+
+import io.jooby.apt.ProcessorRunner;
+import io.jooby.test.MockContext;
+import io.jooby.test.MockRouter;
+
+public class Issue3786 {
+  @Test
+  public void shouldCheckBase() throws Exception {
+    new ProcessorRunner(new C3786())
+        .withRouter(
+            app -> {
+              var router = new MockRouter(app);
+              assertEquals("base", router.get("/inherited", new MockContext()).value());
+              assertEquals(
+                  "withPath", router.get("/inherited/withPath", new MockContext()).value());
+              assertEquals("base: 123", router.get("/inherited/123", new MockContext()).value());
+              assertEquals(
+                  "GET/inherited/childOnly",
+                  router.get("/inherited/childOnly", new MockContext()).value());
+              assertEquals(
+                  "POST/inherited/childOnly",
+                  router.post("/inherited/childOnly", new MockContext()).value());
+            });
+  }
+
+  @Test
+  public void shouldCheckOverride() throws Exception {
+    new ProcessorRunner(new D3786())
+        .withRouter(
+            app -> {
+              var router = new MockRouter(app);
+              assertEquals("base", router.get("/overrideMethod", new MockContext()).value());
+              assertEquals(
+                  "withPath", router.get("/overrideMethod/withPath", new MockContext()).value());
+              assertEquals(
+                  "base: 123", router.get("/overrideMethod/123", new MockContext()).value());
+              assertEquals(
+                  "/overrideMethod/childOnly",
+                  router.get("/overrideMethod/childOnly", new MockContext()).value());
+              assertEquals(
+                  "/overrideMethod/user",
+                  router.post("/overrideMethod/user", new MockContext()).value());
+            });
+  }
+}