jooby-apt generates ambiguous constructors for controllers with a single argument constructor w/ single methods

-ref  #3756

Author: jknack

modules/jooby-apt/src/main/resources/io/jooby/internal/apt/Source.java

@@ -9,7 +9,7 @@ public class ${generatedClassName} implements io.jooby.Extension {
     }
 
     public ${generatedClassName}(io.jooby.SneakyThrows.Supplier<${className}> provider) {
-       setup(ctx -> provider.get());
+       setup(ctx -> (${className}) provider.get());
     }
 
     public ${generatedClassName}(io.jooby.SneakyThrows.Function<Class<${className}>, ${className}> provider) {

modules/jooby-apt/src/test/java/io/jooby/apt/ProcessorRunner.java

@@ -90,6 +90,7 @@ protected void onGeneratedSource(JavaFileObject source) {
     }
   }
 
+  private final Object instance;
   private final HookJoobyProcessor processor;
 
   public ProcessorRunner(Object instance) throws IOException {
@@ -106,6 +107,7 @@ public ProcessorRunner(Object instance, Map<String, Object> options) throws IOEx
 
   public ProcessorRunner(Object instance, Consumer<String> stdout, Map<String, Object> options)
       throws IOException {
+    this.instance = instance;
     this.processor = new HookJoobyProcessor(stdout::accept);
     var optionsArray =
         options.entrySet().stream().map(e -> "-A" + e.getKey() + "=" + e.getValue()).toList();
@@ -126,8 +128,14 @@ public ProcessorRunner withRouter(SneakyThrows.Consumer2<Jooby, JavaFileObject>
     var classLoader = processor.createClassLoader();
     var factoryName = classLoader.getClassName();
     var factoryClass = (Class<? extends Extension>) classLoader.loadClass(factoryName);
-    var constructor = factoryClass.getDeclaredConstructor();
-    var extension = constructor.newInstance();
+    Extension extension;
+    try {
+      var constructor = factoryClass.getDeclaredConstructor();
+      extension = constructor.newInstance();
+    } catch (NoSuchMethodException x) {
+      extension = factoryClass.getDeclaredConstructor(instance.getClass()).newInstance(instance);
+    }
+
     var application = new Jooby();
     application.install(extension);
     consumer.accept(application, processor.getSource());

modules/jooby-apt/src/test/java/tests/i3756/C3756.java

@@ -0,0 +1,25 @@
+/*
+ * Jooby https://jooby.io
+ * Apache License Version 2.0 https://jooby.io/LICENSE.txt
+ * Copyright 2014 Edgar Espina
+ */
+package tests.i3756;
+
+import io.jooby.annotation.GET;
+import io.jooby.annotation.Path;
+
+@Path("/C3756")
+public class C3756 {
+  private final S3756 s3756;
+
+  public C3756(S3756 s3756) {
+    super();
+    this.s3756 = s3756;
+  }
+
+  @GET
+  public String handle() {
+    s3756.accept("hello");
+    return "hello";
+  }
+}

modules/jooby-apt/src/test/java/tests/i3756/Issue3756.java

@@ -0,0 +1,30 @@
+/*
+ * Jooby https://jooby.io
+ * Apache License Version 2.0 https://jooby.io/LICENSE.txt
+ * Copyright 2014 Edgar Espina
+ */
+package tests.i3756;
+
+import static org.junit.jupiter.api.Assertions.assertFalse;
+import static org.junit.jupiter.api.Assertions.assertNotNull;
+
+import org.junit.jupiter.api.Test;
+
+import io.jooby.apt.ProcessorRunner;
+
+public class Issue3756 {
+  @Test
+  public void shouldCompile() throws Exception {
+    // must compile
+    new ProcessorRunner(new C3756((S3756) s -> {}))
+        .withRouter(
+            (app, source) -> {
+              System.out.println(source);
+              var routes = app.getRoutes();
+              assertNotNull(routes);
+              assertFalse(routes.isEmpty());
+              var route = app.getRoutes().get(0);
+              assertNotNull(route);
+            });
+  }
+}

modules/jooby-apt/src/test/java/tests/i3756/S3756.java

@@ -0,0 +1,10 @@
+/*
+ * Jooby https://jooby.io
+ * Apache License Version 2.0 https://jooby.io/LICENSE.txt
+ * Copyright 2014 Edgar Espina
+ */
+package tests.i3756;
+
+public interface S3756 {
+  void accept(String s);
+}

tests/src/test/java/io/jooby/i3756/C3756.java

@@ -0,0 +1,24 @@
+/*
+ * Jooby https://jooby.io
+ * Apache License Version 2.0 https://jooby.io/LICENSE.txt
+ * Copyright 2014 Edgar Espina
+ */
+package io.jooby.i3756;
+
+import io.jooby.annotation.GET;
+import io.jooby.annotation.Path;
+
+@Path("/3756")
+public class C3756 {
+  private final S3756 s3756;
+
+  public C3756(S3756 s3756) {
+    this.s3756 = s3756;
+  }
+
+  @GET
+  public String handle() {
+    s3756.accept("hello");
+    return "hello";
+  }
+}

tests/src/test/java/io/jooby/i3756/Issue3756.java

@@ -0,0 +1,30 @@
+/*
+ * Jooby https://jooby.io
+ * Apache License Version 2.0 https://jooby.io/LICENSE.txt
+ * Copyright 2014 Edgar Espina
+ */
+package io.jooby.i3756;
+
+import static org.junit.jupiter.api.Assertions.assertEquals;
+
+import io.jooby.junit.ServerTest;
+import io.jooby.junit.ServerTestRunner;
+
+public class Issue3756 {
+  @ServerTest
+  public void shouldCompileConflictConstructor(ServerTestRunner runner) {
+    runner
+        .define(
+            app -> {
+              app.mvc(new C3756_(s -> {}));
+            })
+        .ready(
+            http -> {
+              http.get(
+                  "/3756",
+                  rsp -> {
+                    assertEquals("hello", rsp.body().string());
+                  });
+            });
+  }
+}

tests/src/test/java/io/jooby/i3756/S3756.java

@@ -0,0 +1,10 @@
+/*
+ * Jooby https://jooby.io
+ * Apache License Version 2.0 https://jooby.io/LICENSE.txt
+ * Copyright 2014 Edgar Espina
+ */
+package io.jooby.i3756;
+
+public interface S3756 {
+  void accept(String s);
+}