Merge pull request #595 from jooby-project/584

org.jooby.Err: Not Found(404): /favicon.ico fix #584

Author: jknack

coverage-report/src/test/java/org/jooby/issues/Issue584.java

@@ -0,0 +1,18 @@
+package org.jooby.issues;
+
+import org.jooby.test.ServerFeature;
+import org.junit.Test;
+
+public class Issue584 extends ServerFeature {
+
+  {
+  }
+
+  @Test
+  public void silentFaviconRequest() throws Exception {
+    request()
+        .get("/favicon.ico")
+        .expect(404)
+        .expect("");
+  }
+}

coverage-report/src/test/java/org/jooby/issues/Issue584b.java

@@ -0,0 +1,27 @@
+package org.jooby.issues;
+
+import org.jooby.test.ServerFeature;
+import org.junit.Test;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+public class Issue584b extends ServerFeature {
+
+  /** The logging system. */
+  private final Logger log = LoggerFactory.getLogger(getClass());
+
+  {
+
+    err((req, rsp, err) -> {
+      log.error("{}", req.path(), err);
+    });
+  }
+
+  @Test
+  public void silentFaviconRequest() throws Exception {
+    request()
+        .get("/favicon.ico")
+        .expect(404)
+        .expect("");
+  }
+}

jooby/src/main/java/org/jooby/internal/HttpHandlerImpl.java

@@ -430,7 +430,13 @@ private static List<Route> routes(final Set<Route.Definition> routeDefs, final S
         if (ex != null) {
           throw ex;
         }
-        throw new Err(Status.NOT_FOUND, req.path(true));
+        // favicon.ico
+        if (path.equals("/favicon.ico")) {
+          // default /favicon.ico handler:
+          rsp.status(Status.NOT_FOUND).end();
+        } else {
+          throw new Err(Status.NOT_FOUND, req.path(true));
+        }
       }
     }, method, path, "err", accept));