jooby-apt: MVC generated controllers require jakarta-inject should be documented because of code generation.

- fix #3460

Author: jknack

jooby/src/main/java/io/jooby/Jooby.java

@@ -552,15 +552,15 @@ public Jooby mvc(@NonNull Class router) {
   public <T> Jooby mvc(@NonNull Class<T> router, @NonNull Provider<T> provider) {
     try {
       MvcFactory module = loadModule(router);
-      Extension extension = module.create(provider);
+      Extension extension = module.create(provider::get);
       extension.install(this);
       return this;
     } catch (Exception x) {
       throw SneakyThrows.propagate(x);
     }
   }
 
-  private MvcFactory loadModule(Class router) {
+  private <T> MvcFactory<T> loadModule(Class<T> router) {
     try {
       ServiceLoader<MvcFactory> modules = ServiceLoader.load(MvcFactory.class);
       return stream(modules.spliterator(), false)

jooby/src/main/java/io/jooby/MvcFactory.java

@@ -6,7 +6,6 @@
 package io.jooby;
 
 import edu.umd.cs.findbugs.annotations.NonNull;
-import jakarta.inject.Provider;
 
 /**
  * Created by a Jooby annotation processor tool using the {@link java.util.ServiceLoader} API.
@@ -28,5 +27,5 @@ public interface MvcFactory<T> {
    * @param provider MVC route instance provider.
    * @return All mvc route as extension module.
    */
-  @NonNull Extension create(@NonNull Provider<T> provider);
+  @NonNull Extension create(@NonNull java.util.function.Supplier<T> provider);
 }

modules/jooby-apt/src/main/resources/io/jooby/internal/apt/Source.java

@@ -16,7 +16,7 @@ public class ${generatedClassName} implements io.jooby.MvcExtension, io.jooby.Mv
         this(ctx -> ctx.require(type));
     }
 
-    public ${generatedClassName}(jakarta.inject.Provider<${className}> provider) {
+    public ${generatedClassName}(java.util.function.Supplier<${className}> provider) {
         this(ctx -> provider.get());
     }
 
@@ -34,7 +34,7 @@ public boolean supports(Class<${className}> type) {
         return type == ${className}.class;
     }
 
-    public io.jooby.Extension create(jakarta.inject.Provider<${className}> provider) {
+    public io.jooby.Extension create(java.util.function.Supplier<${className}> provider) {
         return new ${generatedClassName}(provider);
     }
 }

modules/jooby-apt/src/main/resources/io/jooby/internal/apt/Source.kt

@@ -9,7 +9,7 @@ open class ${generatedClassName}(protected val factory: java.util.function.Funct
 
     constructor(type: kotlin.reflect.KClass<${className}>) : this(java.util.function.Function<io.jooby.Context, ${className}> { ctx: io.jooby.Context -> ctx.require<${className}>(type.java) })
 
-    constructor(provider: jakarta.inject.Provider<${className}?>) : this(java.util.function.Function<io.jooby.Context, ${className}> { provider.get()!! })
+    constructor(provider: java.util.function.Supplier<${className}?>) : this(java.util.function.Function<io.jooby.Context, ${className}> { provider.get()!! })
 
     @Throws(Exception::class)
     override fun install(app: io.jooby.Jooby) {
@@ -22,7 +22,7 @@ ${methods}
         return type == ${className}::class.java
     }
 
-    override fun create(provider: jakarta.inject.Provider<${className}?>): io.jooby.Extension {
+    override fun create(provider: java.util.function.Supplier<${className}?>): io.jooby.Extension {
         return ${generatedClassName}(provider)
     }
 }

modules/jooby-apt/src/test/java/tests/i3460/C3460.java

@@ -0,0 +1,19 @@
+/*
+ * Jooby https://jooby.io
+ * Apache License Version 2.0 https://jooby.io/LICENSE.txt
+ * Copyright 2014 Edgar Espina
+ */
+package tests.i3460;
+
+import edu.umd.cs.findbugs.annotations.NonNull;
+import io.jooby.annotation.GET;
+import io.jooby.annotation.Path;
+import io.jooby.annotation.QueryParam;
+
+@Path("/path")
+public class C3460 {
+  @GET("/required-string-param")
+  public String requiredStringParam(@QueryParam("value") @NonNull String value) {
+    return value;
+  }
+}

modules/jooby-apt/src/test/java/tests/i3460/Issue3460.java

@@ -0,0 +1,24 @@
+/*
+ * Jooby https://jooby.io
+ * Apache License Version 2.0 https://jooby.io/LICENSE.txt
+ * Copyright 2014 Edgar Espina
+ */
+package tests.i3460;
+
+import static org.junit.jupiter.api.Assertions.assertTrue;
+
+import org.junit.jupiter.api.Test;
+
+import io.jooby.apt.ProcessorRunner;
+
+public class Issue3460 {
+
+  @Test
+  public void shouldNotUseJakartaProvider() throws Exception {
+    new ProcessorRunner(new C3460())
+        .withRouter(
+            (app, source) -> {
+              assertTrue(source.toString().contains("C3460_(java.util.function.Supplier<"));
+            });
+  }
+}

modules/jooby-avaje-inject/pom.xml

@@ -91,11 +91,6 @@
             <arg>-parameters</arg>
           </compilerArgs>
           <annotationProcessorPaths>
-            <path>
-              <groupId>io.jooby</groupId>
-              <artifactId>jooby-apt</artifactId>
-              <version>${jooby.version}</version>
-            </path>
             <path>
               <groupId>io.avaje</groupId>
               <artifactId>avaje-inject-generator</artifactId>