netty: more code cleanup

Author: jknack

modules/jooby-netty/src/main/java/io/jooby/internal/netty/NettyHandler.java

@@ -71,7 +71,7 @@ public void channelRead(ChannelHandlerContext ctx, Object msg) {
       }
       context.setHeaders.set(HttpHeaderNames.CONTENT_TYPE, HttpHeaderValues.TEXT_PLAIN);
 
-      if (req.method().equals(HttpMethod.GET)) {
+      if (req.method() == HttpMethod.GET) {
         router.match(context).execute(context);
       } else {
         // possibly body:

modules/jooby-netty/src/main/java/io/jooby/internal/netty/NettyPipeline.java

@@ -119,7 +119,7 @@ private void http11Upgrade(
 
   private void http11(ChannelPipeline p) {
     p.addLast("decoder", new NettyRequestDecoder(decoderConfig));
-    p.addLast("encoder", new NettyResponseEncoder());
+    p.addLast("encoder", new HttpResponseEncoder());
     additionalHandlers(p);
     p.addLast("handler", createHandler());
   }

modules/jooby-netty/src/main/java/io/jooby/internal/netty/NettyRequestDecoder.java

@@ -9,6 +9,11 @@
 
 public class NettyRequestDecoder extends HttpRequestDecoder {
 
+  private static final String GET = HttpMethod.GET.name();
+  private static final String POST = HttpMethod.POST.name();
+  private static final String PUT = HttpMethod.PUT.name();
+  private static final String DELETE = HttpMethod.DELETE.name();
+
   public NettyRequestDecoder(HttpDecoderConfig config) {
     super(config);
   }
@@ -24,16 +29,16 @@ protected HttpMessage createMessage(String[] initialLine) throws Exception {
 
   private static HttpMethod valueOf(String name) {
     // fast-path
-    if (name == HttpMethod.GET.name()) {
+    if (name == GET) {
       return HttpMethod.GET;
     }
-    if (name == HttpMethod.POST.name()) {
+    if (name == POST) {
       return HttpMethod.POST;
     }
-    if (name == HttpMethod.DELETE.name()) {
+    if (name == DELETE) {
       return HttpMethod.DELETE;
     }
-    if (name == HttpMethod.PUT.name()) {
+    if (name == PUT) {
       return HttpMethod.PUT;
     }
     // "slow"-path: ensure method is on upper case