Web Context: Initialize HTTP method and requestPath at context creation due they both are required for route matching

Author: jknack

modules/jooby-jetty/src/main/java/io/jooby/internal/jetty/JettyContext.java

@@ -92,15 +92,17 @@ public class JettyContext implements DefaultContext {
   private HashMap<String, String> responseCookies;
   private boolean responseStarted;
   private Boolean resetHeadersOnError;
-  private String method;
-  private String pathString;
+  private final String method;
+  private final String requestPath;
 
   public JettyContext(Request request, Router router, int bufferSize, long maxRequestSize) {
     this.request = request;
     this.response = request.getResponse();
     this.router = router;
     this.bufferSize = bufferSize;
     this.maxRequestSize = maxRequestSize;
+    this.method = request.getMethod().toUpperCase();
+    this.requestPath = request.getRequestURI();
   }
 
   @Nonnull @Override public Map<String, Object> getAttributes() {
@@ -139,9 +141,6 @@ public JettyContext(Request request, Router router, int bufferSize, long maxRequ
   }
 
   @Nonnull @Override public String getMethod() {
-    if (method == null) {
-      method = request.getMethod().toUpperCase();
-    }
     return method;
   }
 
@@ -159,10 +158,7 @@ public JettyContext(Request request, Router router, int bufferSize, long maxRequ
   }
 
   @Nonnull @Override public String getRequestPath() {
-    if (pathString == null) {
-      pathString = request.getRequestURI();
-    }
-    return pathString;
+    return requestPath;
   }
 
   @Nonnull @Override public Map<String, String> pathMap() {

modules/jooby-netty/src/main/java/io/jooby/internal/netty/NettyContext.java

@@ -111,7 +111,7 @@ public class NettyContext implements DefaultContext, ChannelFutureListener {
   private Route route;
   ChannelHandlerContext ctx;
   private HttpRequest req;
-  private String path;
+  private final String path;
   private HttpResponseStatus status = HttpResponseStatus.OK;
   private boolean responseStarted;
   private QueryString query;
@@ -128,7 +128,7 @@ public class NettyContext implements DefaultContext, ChannelFutureListener {
   private Map<String, String> responseCookies;
   private Boolean resetHeadersOnError;
   NettyWebSocket webSocket;
-  private String method;
+  private final String method;
 
   public NettyContext(ChannelHandlerContext ctx, HttpRequest req, Router router, String path,
       int bufferSize) {
@@ -137,6 +137,7 @@ public NettyContext(ChannelHandlerContext ctx, HttpRequest req, Router router, S
     this.req = req;
     this.router = router;
     this.bufferSize = bufferSize;
+    this.method = req.method().name().toUpperCase();
   }
 
   @Nonnull @Override public Router getRouter() {
@@ -153,9 +154,6 @@ public NettyContext(ChannelHandlerContext ctx, HttpRequest req, Router router, S
   }
 
   @Nonnull @Override public String getMethod() {
-    if (method == null) {
-      method = req.method().name().toUpperCase();
-    }
     return method;
   }
 

modules/jooby-utow/src/main/java/io/jooby/internal/utow/UtowContext.java

@@ -83,12 +83,14 @@ public class UtowContext implements DefaultContext, IoCallback {
   private HashMap<String, String> responseCookies;
   private long responseLength = -1;
   private Boolean resetHeadersOnError;
-  private String method;
-  private String requestPath;
+  private final String method;
+  private final String requestPath;
 
   public UtowContext(HttpServerExchange exchange, Router router) {
     this.exchange = exchange;
     this.router = router;
+    this.method = exchange.getRequestMethod().toString().toUpperCase();
+    this.requestPath = exchange.getRequestPath();
   }
 
   @Nonnull @Override public Router getRouter() {
@@ -123,9 +125,6 @@ public UtowContext(HttpServerExchange exchange, Router router) {
   }
 
   @Nonnull @Override public String getMethod() {
-    if (method == null) {
-      method = exchange.getRequestMethod().toString().toUpperCase();
-    }
     return method;
   }
 
@@ -143,9 +142,6 @@ public UtowContext(HttpServerExchange exchange, Router router) {
   }
 
   @Nonnull @Override public String getRequestPath() {
-    if (requestPath == null) {
-      requestPath = exchange.getRequestPath();
-    }
     return requestPath;
   }