websocket.idleTimeout ignored when using JettyServer — always disconnects after 30s

fix #3795

Author: jknack

modules/jooby-jetty/src/main/java/io/jooby/jetty/JettyServer.java

@@ -26,7 +26,7 @@
 import org.eclipse.jetty.util.thread.Invocable;
 import org.eclipse.jetty.util.thread.QueuedThreadPool;
 import org.eclipse.jetty.util.thread.ThreadPool;
-import org.eclipse.jetty.websocket.server.WebSocketUpgradeHandler;
+import org.eclipse.jetty.websocket.server.ServerWebSocketContainer;
 
 import com.typesafe.config.Config;
 import edu.umd.cs.findbugs.annotations.NonNull;
@@ -236,13 +236,9 @@ public io.jooby.Server start(@NonNull Jooby... application) {
                 ? conf.getDuration("websocket.idleTimeout", TimeUnit.MILLISECONDS)
                 : TimeUnit.MINUTES.toMillis(5);
 
-        WebSocketUpgradeHandler.from(
-            server,
-            context,
-            container -> {
-              container.setMaxTextMessageSize(maxSize);
-              container.setIdleTimeout(Duration.ofMillis(timeout));
-            });
+        var container = ServerWebSocketContainer.ensure(server, context);
+        container.setMaxTextMessageSize(maxSize);
+        container.setIdleTimeout(Duration.ofMillis(timeout));
       }
       server.setHandler(context);
       server.start();

modules/jooby-undertow/src/main/java/io/jooby/internal/undertow/UndertowWebSocket.java

@@ -325,9 +325,7 @@ void fireConnect() {
           conf.hasPath("websocket.idleTimeout")
               ? conf.getDuration("websocket.idleTimeout", TimeUnit.MILLISECONDS)
               : TimeUnit.MINUTES.toMillis(5);
-      if (timeout > 0) {
-        channel.setIdleTimeout(timeout);
-      }
+      channel.setIdleTimeout(timeout);
       if (onConnectCallback != null) {
         dispatch(webSocketTask(() -> onConnectCallback.onConnect(this), true));
       } else {