Skip to content

Commit 93a610b

Browse files
committed
Application startup fails due to env vars
- fix #3732
1 parent d7bfaf8 commit 93a610b

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

jooby/src/main/java/io/jooby/Jooby.java

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1192,9 +1192,10 @@ public static void runApp(
11921192
@NonNull String[] args,
11931193
@NonNull ExecutionMode executionMode,
11941194
@NonNull List<Supplier<Jooby>> provider) {
1195-
Map<String, Object> configMap = new HashMap<>(parseArguments(args));
1196-
// Override with environment
1197-
configMap.putAll(System.getenv());
1195+
var configMap = new HashMap<>(parseArguments(args));
1196+
// TODO: Add new way to override server options mainly from system properties/environment
1197+
// variables. Probably by adding a new config file: server.conf
1198+
// configMap.putAll(System.getenv());
11981199
var options = ServerOptions.from(ConfigFactory.parseMap(configMap)).orElse(null);
11991200
runApp(args, Server.loadServer(), options, executionMode, provider);
12001201
}

0 commit comments

Comments
 (0)