jackson/json: add parameter names module fix #616

Author: jknack

coverage-report/src/test/java/org/jooby/issues/Issue616.java

@@ -0,0 +1,64 @@
+package org.jooby.issues;
+
+import org.jooby.json.Jackson;
+import org.jooby.test.ServerFeature;
+import org.junit.Test;
+
+public class Issue616 extends ServerFeature {
+
+  public static class Person {
+
+    // mandatory fields
+    private final String name;
+    private final String surname;
+
+    // optional fields
+    private String nickname;
+
+    public Person(final String name, final String surname) {
+      this.name = name;
+      this.surname = surname;
+    }
+
+    public String getName() {
+      return name;
+    }
+
+    public String getSurname() {
+      return surname;
+    }
+
+    public String getNickname() {
+      return nickname;
+    }
+
+    public void setNickname(final String nickname) {
+      this.nickname = nickname;
+    }
+
+    @Override
+    public String toString() {
+      return name + " " + surname + "(" + nickname + ")";
+    }
+  }
+
+  {
+    use(new Jackson());
+    post("/616", req -> {
+      return req.body(Person.class).toString();
+    });
+  }
+
+  @Test
+  public void jacksonWithParamNamesModule() throws Exception {
+    request()
+        .post("/616")
+        .body("{\"name\":\"N\",\"surname\":\"S\"}", "application/json")
+        .expect("\"N S(null)\"");
+
+    request()
+        .post("/616")
+        .body("{\"name\":\"N\",\"surname\":\"S\",\"nickname\":\".\"}", "application/json")
+        .expect("\"N S(.)\"");
+  }
+}

jooby-jackson/pom.xml

@@ -54,6 +54,11 @@
       <artifactId>jackson-databind</artifactId>
     </dependency>
 
+    <dependency>
+      <groupId>com.fasterxml.jackson.module</groupId>
+      <artifactId>jackson-module-parameter-names</artifactId>
+    </dependency>
+
     <!-- Test dependencies -->
     <dependency>
       <groupId>org.jooby</groupId>

jooby-jackson/src/main/java/org/jooby/json/Jackson.java

@@ -41,6 +41,7 @@
 import com.fasterxml.jackson.databind.ObjectMapper;
 import com.fasterxml.jackson.datatype.jdk8.Jdk8Module;
 import com.fasterxml.jackson.datatype.jsr310.JavaTimeModule;
+import com.fasterxml.jackson.module.paramnames.ParameterNamesModule;
 import com.google.inject.Binder;
 import com.google.inject.Key;
 import com.google.inject.multibindings.Multibinder;
@@ -218,13 +219,13 @@ public void configure(final Env env, final Config config, final Binder binder) {
       m.setDateFormat(new SimpleDateFormat(config.getString("application.dateFormat"), locale));
       m.setLocale(locale);
       m.setTimeZone(TimeZone.getTimeZone(config.getString("application.tz")));
+      // default modules:
+      m.registerModule(new Jdk8Module());
+      m.registerModule(new JavaTimeModule());
+      m.registerModule(new ParameterNamesModule());
       return m;
     });
 
-    // some java 8 modules
-    mapper.registerModule(new Jdk8Module());
-    mapper.registerModule(new JavaTimeModule());
-
     if (configurer != null) {
       configurer.accept(mapper);
     }

pom.xml

@@ -821,6 +821,12 @@
         <version>${jackson.version}</version>
       </dependency>
 
+      <dependency>
+        <groupId>com.fasterxml.jackson.module</groupId>
+        <artifactId>jackson-module-parameter-names</artifactId>
+        <version>${jackson.version}</version>
+      </dependency>
+
       <dependency>
         <groupId>com.fasterxml.jackson.datatype</groupId>
         <artifactId>jackson-datatype-guava</artifactId>