[jooby 1.x - hibernate]: classcast exception when connection can't be acquire fix #1473

Author: jknack

modules/jooby-hbm/src/main/java/org/jooby/internal/hbm/OpenSessionInView.java

@@ -215,15 +215,25 @@ public class OpenSessionInView implements Filter {
   @Override
   public void handle(final Request req, final Response rsp, final Chain chain) throws Throwable {
     RootUnitOfWork uow = (RootUnitOfWork) req.require(UnitOfWork.class);
-    // start transaction
-    uow.begin();
 
-    rsp.after(after(uow));
+    try {
+      // start transaction
+      uow.begin();
+
+      rsp.after(after(uow));
 
-    rsp.complete(complete(uow));
+      rsp.complete(complete(uow));
 
-    // move next
-    chain.next(req, rsp);
+      // move next
+      chain.next(req, rsp);
+    } catch (Throwable x) {
+      try {
+        uow.setRollbackOnly().end();
+      } catch (Throwable suppressed) {
+        x.addSuppressed(suppressed);
+      }
+      throw x;
+    }
   }
 
   private static Route.Complete complete(final RootUnitOfWork uow) {

modules/jooby-hbm/src/main/java/org/jooby/internal/hbm/RootUnitOfWork.java

@@ -243,15 +243,15 @@ public UnitOfWork commit() {
       return this;
     }
     if (!readOnly) {
-      log.debug("flusing session: {}", oid(session));
+      log.debug("flushing session: {}", oid(session));
       session.flush();
     } else {
-      log.debug("flusing ignored on read-only session: {}", oid(session));
+      log.debug("flushing ignored on read-only session: {}", oid(session));
     }
     active(session, trx -> {
-      log.debug("commiting transaction: {}(trx@{})", oid(session), oid(trx));
+      log.debug("committing transaction: {}(trx@{})", oid(session), oid(trx));
       trx.commit();
-    }, trx -> log.warn("unable to commit inactive transaction: {}(trx@{})", oid(session), oid(trx)));
+    }, trx -> log.debug("unable to commit inactive transaction: {}(trx@{})", oid(session), oid(trx)));
     return this;
   }
 
@@ -277,7 +277,7 @@ public UnitOfWork rollback() {
     active(session, trx -> {
       log.debug("rollback transaction: {}(trx@{})", oid(session), oid(trx));
       trx.rollback();
-    }, trx -> log.warn("unable to rollback inactive transaction: {}(trx@{})", oid(session), oid(trx)));
+    }, trx -> log.debug("unable to rollback inactive transaction: {}(trx@{})", oid(session), oid(trx)));
     return this;
   }
 
@@ -303,16 +303,19 @@ public void end() {
         commit();
       }
     } finally {
-      if (readOnly) {
-        setConnectionReadOnly(false);
-      }
+      try {
+        if (readOnly) {
+          setConnectionReadOnly(false);
+        }
 
-      String sessionId = oid(session);
-      log.debug("closing session: {}", sessionId);
-      Try.run(session::close)
-          .onFailure(x -> log.error("session.close() resulted in exception: {}", sessionId, x))
-          .onSuccess(() -> log.debug("session closed: {}", sessionId));
-      unbind(session.getSessionFactory());
+        String sessionId = oid(session);
+        log.debug("closing session: {}", sessionId);
+        Try.run(session::close)
+            .onFailure(x -> log.error("session.close() resulted in exception: {}", sessionId, x))
+            .onSuccess(() -> log.debug("session closed: {}", sessionId));
+      } finally {
+        unbind(session.getSessionFactory());
+      }
     }
   }