Bug: review onStarting vs onStarted callback usage from existing modules

- fix #3551
- ref #3550

Author: jknack

modules/jooby-jackson/src/main/java/io/jooby/jackson/JacksonModule.java

@@ -143,7 +143,7 @@ public void install(@NonNull Jooby application) {
     // Parsing exception as 400
     application.errorCode(JsonParseException.class, StatusCode.BAD_REQUEST);
 
-    application.onStarted(
+    application.onStarting(
         () -> {
           for (Class<? extends Module> type : modules) {
             Module module = application.require(type);

modules/jooby-metrics/src/main/java/io/jooby/metrics/MetricsModule.java

@@ -241,7 +241,7 @@ public void install(@NonNull Jooby application) {
 
     final Set<Reporter> reporters = new HashSet<>();
 
-    application.onStarted(
+    application.onStarting(
         () -> {
           metricClasses.forEach(
               (name, clazz) -> metricRegistry.register(name, application.require(clazz)));

modules/jooby-pac4j/src/main/java/io/jooby/pac4j/Pac4jModule.java

@@ -447,7 +447,7 @@ public void install(@NonNull Jooby application) throws Exception {
         allClients.values().stream().flatMap(List::stream).filter(r -> !r.isResolved()).toList();
 
     if (!unresolved.isEmpty()) {
-      application.onStarted(
+      application.onStarting(
           () -> {
             List<Client> clientList = new ArrayList<>(clients.getClients());
             unresolved.stream()
@@ -567,7 +567,7 @@ public void install(@NonNull Jooby application) throws Exception {
     /** Compute default url as next available route. We only select static path patterns. */
     if (options.getDefaultUrl() == null) {
       int index = application.getRoutes().size();
-      application.onStarted(
+      application.onStarting(
           () -> {
             List<Route> routes = application.getRoutes();
             String defaultUrl = application.getContextPath();

tests/src/test/java/io/jooby/i3551/GuiceService3551.java

@@ -0,0 +1,19 @@
+/*
+ * Jooby https://jooby.io
+ * Apache License Version 2.0 https://jooby.io/LICENSE.txt
+ * Copyright 2014 Edgar Espina
+ */
+package io.jooby.i3551;
+
+import com.fasterxml.jackson.databind.module.SimpleModule;
+import io.jooby.Environment;
+import jakarta.inject.Inject;
+
+public class GuiceService3551 extends SimpleModule {
+  private Environment env;
+
+  @Inject
+  public GuiceService3551(Environment env) {
+    this.env = env;
+  }
+}

tests/src/test/java/io/jooby/i3551/Issue3551.java

@@ -0,0 +1,51 @@
+/*
+ * Jooby https://jooby.io
+ * Apache License Version 2.0 https://jooby.io/LICENSE.txt
+ * Copyright 2014 Edgar Espina
+ */
+package io.jooby.i3551;
+
+import static org.junit.jupiter.api.Assertions.*;
+import static org.junit.jupiter.api.Assertions.assertEquals;
+
+import io.jooby.ServiceKey;
+import io.jooby.StatusCode;
+import io.jooby.guice.GuiceModule;
+import io.jooby.jackson.JacksonModule;
+import io.jooby.junit.ServerTest;
+import io.jooby.junit.ServerTestRunner;
+
+public class Issue3551 {
+  @ServerTest
+  public void shouldEnsureDIOnStartCallbacks(ServerTestRunner runner) {
+    runner
+        .define(
+            app -> {
+              app.getServices()
+                  .put(
+                      ServiceKey.key(Service3551.class, "service"),
+                      new Service3551(app.getEnvironment()));
+              app.install(new JacksonModule().module(JacksonModule3551.class));
+
+              app.install(new GuiceModule());
+
+              app.onStarting(
+                  () -> {
+                    // Ask jooby registry
+                    assertNotNull(app.require(ServiceKey.key(Service3551.class, "service")));
+                    // Ask Guice
+                    assertNotNull(app.require(GuiceService3551.class));
+                    assertNotNull(app.require(JacksonModule3551.class));
+                  });
+              app.get("/3551", ctx -> StatusCode.OK);
+            })
+        .ready(
+            http -> {
+              http.get(
+                  "/3551",
+                  rsp -> {
+                    assertEquals(StatusCode.OK.value(), rsp.code());
+                  });
+            });
+  }
+}

tests/src/test/java/io/jooby/i3551/JacksonModule3551.java

@@ -0,0 +1,19 @@
+/*
+ * Jooby https://jooby.io
+ * Apache License Version 2.0 https://jooby.io/LICENSE.txt
+ * Copyright 2014 Edgar Espina
+ */
+package io.jooby.i3551;
+
+import com.fasterxml.jackson.databind.module.SimpleModule;
+import io.jooby.Environment;
+import jakarta.inject.Inject;
+
+public class JacksonModule3551 extends SimpleModule {
+  private Environment env;
+
+  @Inject
+  public JacksonModule3551(Environment env) {
+    this.env = env;
+  }
+}

tests/src/test/java/io/jooby/i3551/Service3551.java

@@ -0,0 +1,17 @@
+/*
+ * Jooby https://jooby.io
+ * Apache License Version 2.0 https://jooby.io/LICENSE.txt
+ * Copyright 2014 Edgar Espina
+ */
+package io.jooby.i3551;
+
+import com.fasterxml.jackson.databind.module.SimpleModule;
+import io.jooby.Environment;
+
+public class Service3551 extends SimpleModule {
+  private Environment env;
+
+  public Service3551(Environment env) {
+    this.env = env;
+  }
+}