source: apply formatter + some minor changes on problem implementation

- rename `fromConfig` to `from` and always require the full path `problem.details`
- remove `Internal` from title and description
- adjust tests

Author: jknack

jooby/src/main/java/io/jooby/Jooby.java

@@ -41,7 +41,6 @@
 import java.util.function.Supplier;
 import java.util.stream.Collectors;
 
-import io.jooby.problem.ProblemDetailsHandler;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
@@ -55,6 +54,7 @@
 import io.jooby.internal.MutedServer;
 import io.jooby.internal.RegistryRef;
 import io.jooby.internal.RouterImpl;
+import io.jooby.problem.ProblemDetailsHandler;
 import jakarta.inject.Provider;
 
 /**
@@ -1333,7 +1333,7 @@ public static Jooby createApp(
   public boolean problemDetailsIsEnabled() {
     var config = getConfig();
     return config.hasPath(ProblemDetailsHandler.ENABLED_KEY)
-           && config.getBoolean(ProblemDetailsHandler.ENABLED_KEY);
+        && config.getBoolean(ProblemDetailsHandler.ENABLED_KEY);
   }
 
   private static void configurePackage(Package pkg) {

jooby/src/main/java/io/jooby/exception/InvalidCsrfToken.java

@@ -28,8 +28,7 @@ public InvalidCsrfToken(@Nullable String token) {
 
   @Override
   public @NonNull HttpProblem toHttpProblem() {
-    return HttpProblem.valueOf(statusCode,
-        "Invalid CSRF token",
-        "CSRF token '" + getMessage() + "' is invalid");
+    return HttpProblem.valueOf(
+        statusCode, "Invalid CSRF token", "CSRF token '" + getMessage() + "' is invalid");
   }
 }

jooby/src/main/java/io/jooby/exception/MethodNotAllowedException.java

@@ -52,9 +52,9 @@ public List<String> getAllow() {
 
   @Override
   public @NonNull HttpProblem toHttpProblem() {
-    return HttpProblem.valueOf(statusCode,
+    return HttpProblem.valueOf(
+        statusCode,
         statusCode.reason(),
-        "HTTP method '" + getMethod() + "' is not allowed. Allowed methods are: " + allow
-    );
+        "HTTP method '" + getMethod() + "' is not allowed. Allowed methods are: " + allow);
   }
 }

jooby/src/main/java/io/jooby/exception/NotAcceptableException.java

@@ -37,10 +37,10 @@ public NotAcceptableException(@Nullable String contentType) {
 
   @Override
   public @NonNull HttpProblem toHttpProblem() {
-    return HttpProblem.valueOf(statusCode,
+    return HttpProblem.valueOf(
+        statusCode,
         statusCode.reason(),
-        "Server cannot produce a response matching the list of " +
-        "acceptable values defined in the request's 'Accept' header"
-    );
+        "Server cannot produce a response matching the list of "
+            + "acceptable values defined in the request's 'Accept' header");
   }
 }

jooby/src/main/java/io/jooby/exception/NotFoundException.java

@@ -37,7 +37,8 @@ public NotFoundException(@NonNull String path) {
 
   @Override
   public @NonNull HttpProblem toHttpProblem() {
-    return HttpProblem.valueOf(statusCode,
+    return HttpProblem.valueOf(
+        statusCode,
         statusCode.reason(),
         "Route '" + getRequestPath() + "' not found. Please verify request path");
   }

jooby/src/main/java/io/jooby/exception/TypeMismatchException.java

@@ -50,7 +50,6 @@ public TypeMismatchException(@NonNull String name, @NonNull Type type) {
     return name;
   }
 
-
   @Override
   public @NonNull HttpProblem toHttpProblem() {
     return HttpProblem.valueOf(statusCode, "Type Mismatch", getMessage());

jooby/src/main/java/io/jooby/exception/UnsupportedMediaType.java

@@ -37,8 +37,7 @@ public UnsupportedMediaType(@Nullable String type) {
 
   @Override
   public @NonNull HttpProblem toHttpProblem() {
-    return HttpProblem.valueOf(statusCode,
-        statusCode.reason(),
-        "Media type '" + getContentType() + "' is not supported");
+    return HttpProblem.valueOf(
+        statusCode, statusCode.reason(), "Media type '" + getContentType() + "' is not supported");
   }
 }

jooby/src/main/java/io/jooby/internal/RouterImpl.java

@@ -35,7 +35,6 @@
 import java.util.stream.IntStream;
 import java.util.stream.Stream;
 
-import io.jooby.problem.ProblemDetailsHandler;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
@@ -48,6 +47,7 @@
 import io.jooby.exception.StatusCodeException;
 import io.jooby.internal.handler.ServerSentEventHandler;
 import io.jooby.internal.handler.WebSocketHandler;
+import io.jooby.problem.ProblemDetailsHandler;
 import jakarta.inject.Provider;
 
 public class RouterImpl implements Router {
@@ -668,18 +668,16 @@ private void pureAscii(String pattern, Consumer<String> consumer) {
   }
 
   /**
-   * Define the global error handler.
-   * If ProblemDetails is enabled the {@link ProblemDetailsHandler} instantiated
-   * from configuration settings and returned. Otherwise, {@link DefaultErrorHandler} instance
-   * returned.
+   * Define the global error handler. If ProblemDetails is enabled the {@link ProblemDetailsHandler}
+   * instantiated from configuration settings and returned. Otherwise, {@link DefaultErrorHandler}
+   * instance returned.
    *
    * @param app - Jooby application instance
    * @return global error handler
    */
   private ErrorHandler defineGlobalErrorHandler(Jooby app) {
     if (app.problemDetailsIsEnabled()) {
-      var problemDetailsConfig = app.getConfig().getConfig(ProblemDetailsHandler.ROOT_CONFIG_PATH);
-      return ProblemDetailsHandler.fromConfig(problemDetailsConfig);
+      return ProblemDetailsHandler.from(app.getConfig());
     } else {
       return ErrorHandler.create();
     }

jooby/src/main/java/io/jooby/problem/HttpProblem.java

@@ -5,28 +5,25 @@
  */
 package io.jooby.problem;
 
-import edu.umd.cs.findbugs.annotations.Nullable;
-import io.jooby.StatusCode;
-
 import java.net.URI;
 import java.time.Instant;
 import java.util.*;
 
+import edu.umd.cs.findbugs.annotations.Nullable;
+import io.jooby.StatusCode;
+
 /**
- * Representation of
- * <a href="https://www.rfc-editor.org/rfc/rfc7807">RFC7807</a>
- * <a href="https://www.rfc-editor.org/rfc/rfc9457">RFC9457</a>
- * Problem schema.
+ * Representation of <a href="https://www.rfc-editor.org/rfc/rfc7807">RFC7807</a> <a
+ * href="https://www.rfc-editor.org/rfc/rfc9457">RFC9457</a> Problem schema.
  *
  * @author kliushnichenko
  * @since 3.4.2
  */
 public class HttpProblem extends RuntimeException {
 
-  private static final String INTERNAL_ERROR_TITLE = "Internal Server Error";
+  private static final String INTERNAL_ERROR_TITLE = StatusCode.SERVER_ERROR.reason();
   private static final String INTERNAL_ERROR_DETAIL =
-      "The server encountered an internal error or misconfiguration and was unable " +
-      "to complete your request";
+      "The server encountered an error or misconfiguration and was unable to complete your request";
 
   private static final URI DEFAULT_TYPE = URI.create("about:blank");
 
@@ -59,25 +56,15 @@ private static String createMessage(String title, String detail) {
   }
 
   public static HttpProblem valueOf(StatusCode status, String title) {
-    return builder()
-        .title(title)
-        .status(status)
-        .build();
+    return builder().title(title).status(status).build();
   }
 
   public static HttpProblem valueOf(StatusCode status, String title, String detail) {
-    return builder()
-        .title(title)
-        .status(status)
-        .detail(detail)
-        .build();
+    return builder().title(title).status(status).detail(detail).build();
   }
 
   public static HttpProblem valueOf(StatusCode status) {
-    return builder()
-        .title(status.reason())
-        .status(status)
-        .build();
+    return builder().title(status.reason()).status(status).build();
   }
 
   public static HttpProblem internalServerError() {
@@ -102,13 +89,13 @@ public String getTimestamp() {
   }
 
   /**
-   * A URI reference that identifies the problem type. Consumers MUST use the "type" URI
-   * (after resolution, if necessary) as the problem type's primary identifier.
-   * When this member is not present, its value is assumed to be "about:blank".
-   * If the type URI is a locator (e.g., those with a "http" or "https" scheme), de-referencing it
-   * SHOULD provide human-readable documentation for the problem type (e.g., using HTML).
-   * However, consumers SHOULD NOT automatically dereference the type URI, unless they do so
-   * when providing information to developers (e.g., when a debugging tool is in use)
+   * A URI reference that identifies the problem type. Consumers MUST use the "type" URI (after
+   * resolution, if necessary) as the problem type's primary identifier. When this member is not
+   * present, its value is assumed to be "about:blank". If the type URI is a locator (e.g., those
+   * with a "http" or "https" scheme), de-referencing it SHOULD provide human-readable documentation
+   * for the problem type (e.g., using HTML). However, consumers SHOULD NOT automatically
+   * dereference the type URI, unless they do so when providing information to developers (e.g.,
+   * when a debugging tool is in use)
    *
    * @return a URI that identifies this problem's type
    */
@@ -117,9 +104,8 @@ public URI getType() {
   }
 
   /**
-   * A short, human-readable summary of the problem type. It SHOULD NOT
-   * change from occurrence to occurrence of the problem, except for
-   * purposes of localization.
+   * A short, human-readable summary of the problem type. It SHOULD NOT change from occurrence to
+   * occurrence of the problem, except for purposes of localization.
    *
    * @return a short, human-readable summary of this problem
    */
@@ -128,8 +114,7 @@ public String getTitle() {
   }
 
   /**
-   * The HTTP status code generated by the origin server for this
-   * occurrence of the problem.
+   * The HTTP status code generated by the origin server for this occurrence of the problem.
    *
    * @return the HTTP status code
    */
@@ -147,8 +132,8 @@ public int getStatus() {
   }
 
   /**
-   * A URI that identifies the specific occurrence of the problem.
-   * It may or may not yield further information if de-referenced.
+   * A URI that identifies the specific occurrence of the problem. It may or may not yield further
+   * information if de-referenced.
    *
    * @return an absolute URI that identifies this specific problem
    */
@@ -183,16 +168,25 @@ public boolean hasErrors() {
 
   @Override
   public String toString() {
-    return "HttpProblem{" +
-           "timestamp='" + timestamp + '\'' +
-           ", type=" + type +
-           ", title='" + title + '\'' +
-           ", status=" + status +
-           ", detail='" + detail + '\'' +
-           ", instance=" + instance +
-           (hasErrors() ? ", errors=" + errors : "") +
-           (hasParameters() ? ", parameters=" + parameters : "") +
-           '}';
+    return "HttpProblem{"
+        + "timestamp='"
+        + timestamp
+        + '\''
+        + ", type="
+        + type
+        + ", title='"
+        + title
+        + '\''
+        + ", status="
+        + status
+        + ", detail='"
+        + detail
+        + '\''
+        + ", instance="
+        + instance
+        + (hasErrors() ? ", errors=" + errors : "")
+        + (hasParameters() ? ", parameters=" + parameters : "")
+        + '}';
   }
 
   public static class Builder {
@@ -205,8 +199,7 @@ public static class Builder {
     private final Map<String, Object> headers = new LinkedHashMap<>();
     private final List<Error> errors = new LinkedList<>();
 
-    Builder() {
-    }
+    Builder() {}
 
     public Builder type(@Nullable final URI type) {
       this.type = type;
@@ -249,7 +242,7 @@ public Builder errors(final List<? extends Error> errors) {
     }
 
     /**
-     * @param key   additional info parameter name
+     * @param key additional info parameter name
      * @param value additional info parameter value
      * @return this for chaining
      */
@@ -266,8 +259,11 @@ public HttpProblem build() {
         throw new RuntimeException("The problem 'status' should be specified");
       }
       if (this.status < 400) {
-        throw new RuntimeException("Illegal status code " + this.status + ". " +
-                                   "Problem details designed to serve 4xx and 5xx status codes");
+        throw new RuntimeException(
+            "Illegal status code "
+                + this.status
+                + ". "
+                + "Problem details designed to serve 4xx and 5xx status codes");
       }
       return new HttpProblem(this);
     }

jooby/src/main/java/io/jooby/problem/HttpProblemMappable.java

@@ -8,14 +8,13 @@
 import edu.umd.cs.findbugs.annotations.NonNull;
 
 /**
- * Implementing {@link HttpProblemMappable} allows to control the transformation of exception
- * into {@link HttpProblem}.
- * {@link ProblemDetailsHandler} rely on `toHttpProblem()` method when it is available.
+ * Implementing {@link HttpProblemMappable} allows to control the transformation of exception into
+ * {@link HttpProblem}. {@link ProblemDetailsHandler} rely on `toHttpProblem()` method when it is
+ * available.
  *
  * @author kliushnichenko
  * @since 3.4.2
  */
 public interface HttpProblemMappable {
-  @NonNull
-  HttpProblem toHttpProblem();
+  @NonNull HttpProblem toHttpProblem();
 }