output: remove setOptions from OutputFactory

Author: jknack

jooby/src/main/java/io/jooby/Server.java

@@ -150,6 +150,11 @@ default Server init(@NonNull Jooby application) {
     return this;
   }
 
+  /**
+   * Output buffer required for using native/server buffers.
+   *
+   * @return Output buffer required for using native/server buffers.
+   */
   OutputFactory getOutputFactory();
 
   /**

jooby/src/main/java/io/jooby/output/ByteBufferedOutputFactory.java

@@ -48,7 +48,7 @@ public Output wrap(@NonNull byte[] bytes, int offset, int length) {
     }
   }
 
-  private OutputOptions options;
+  private final OutputOptions options;
 
   public ByteBufferedOutputFactory(OutputOptions options) {
     this.options = options;
@@ -59,12 +59,6 @@ public OutputOptions getOptions() {
     return options;
   }
 
-  @Override
-  public OutputFactory setOptions(@NonNull OutputOptions options) {
-    this.options = options;
-    return this;
-  }
-
   @Override
   public BufferedOutput allocate(boolean direct, int size) {
     return new ByteBufferedOutput(direct, size);

jooby/src/main/java/io/jooby/output/OutputFactory.java

@@ -37,10 +37,13 @@ static OutputFactory create() {
     return create(new OutputOptions());
   }
 
+  /**
+   * Configuration options.
+   *
+   * @return Configuration options.
+   */
   OutputOptions getOptions();
 
-  OutputFactory setOptions(@NonNull OutputOptions options);
-
   /**
    * Creates a new byte buffered output.
    *

jooby/src/main/java/io/jooby/output/OutputOptions.java

@@ -5,11 +5,18 @@
  */
 package io.jooby.output;
 
+/**
+ * Configuration options for output buffers.
+ *
+ * @author edgar
+ * @since 4.0.0
+ */
 public class OutputOptions {
   private int size;
 
   private boolean directBuffers;
 
+  /** Creates a default options. */
   public OutputOptions() {
     long maxMemory = Runtime.getRuntime().maxMemory();
     // smaller than 64mb of ram we use 512b buffers
@@ -68,10 +75,21 @@ public OutputOptions setSize(int size) {
     return this;
   }
 
+  /**
+   * True when using direct buffers.
+   *
+   * @return True when using direct buffers.
+   */
   public boolean isDirectBuffers() {
     return directBuffers;
   }
 
+  /**
+   * Set to true for using direct buffers.
+   *
+   * @param directBuffers True for direct buffers.
+   * @return This options.
+   */
   public OutputOptions setDirectBuffers(boolean directBuffers) {
     this.directBuffers = directBuffers;
     return this;

modules/jooby-netty/src/main/java/io/jooby/internal/netty/NettyOutputFactory.java

@@ -56,7 +56,7 @@ public NettyContextOutputFactory(ByteBufAllocator allocator, OutputOptions optio
   }
 
   private final ByteBufAllocator allocator;
-  private OutputOptions options;
+  private final OutputOptions options;
 
   public NettyOutputFactory(ByteBufAllocator allocator, OutputOptions options) {
     this.allocator = allocator;
@@ -72,12 +72,6 @@ public ByteBufAllocator getAllocator() {
     return options;
   }
 
-  @Override
-  @NonNull public OutputFactory setOptions(@NonNull OutputOptions options) {
-    this.options = options;
-    return this;
-  }
-
   @Override
   public @NonNull BufferedOutput allocate(boolean direct, int size) {
     return new NettyByteBufOutput(