server: clean up

Author: jknack

docs/asciidoc/body.adoc

@@ -158,14 +158,14 @@ Response encoding is achieved using the javadoc:MessageEncoder[] functional inte
 ----
 public interface MessageEncoder {
 
-  DataBuffer encode(@NonNull Context ctx, @NonNull Object value) throws Exception;
+  Output encode(@NonNull Context ctx, @NonNull Object value) throws Exception;
 }
 ----
 
 MessageEncoder has a single `encode` method that accepts two input arguments: `(context, value)` and 
 produces a result.
 
-The javadoc:buffer.DataBuffer[buffer] works like `java.nio.ByteBuffer` and it is used internally
+The javadoc:output.Output[] works like `java.nio.ByteBuffer` and it is used internally
 for performance reason.
 
 .JSON example:

docs/asciidoc/migration/4.x.adoc

@@ -10,13 +10,6 @@ This is a **work in progress** document, if something is wrong or missing please
 
 - Java 21 as minimum
 
-==== module-info.java
-
-Jooby is now compatible with Java Module system.
-
-Almost all Jooby components are now Java Modules, but not all them. For those where wasn't
-possible the Jooby module contains the `Automatic-Module-Name` manifest entry.
-
 ==== Buffer API
 
 The package `io.jooby.buffer` is gone. It was replaced by `io.jooby.output` these classes
@@ -25,7 +18,7 @@ performance.
 
 ==== Value API
 
-The new package is now `io.jooby.value`. The API has now decoupled from javadoc:Context[] 
+The new package is now `io.jooby.value`. The API is now decoupled from javadoc:Context[] 
 in future release will be the basis of a new configuration system.
 
 Also, the `io.jooby.ValueNode` and `io.jooby.ValueNodeConverter` are gone.

docs/asciidoc/mvc-api.adoc

@@ -1,6 +1,6 @@
 == MVC API
 
-MVC API is an alternative way to define routes in Jooby. It generates source code to define and execute routes.
+MVC API is an alternative way to define routes in Jooby. It generates source code to define and execute routes. The generated class are suffixed with `_` (underscore).
 
 If you use Gradle 6.0 or a later version, you can leverage incremental annotation processing support,
 which means that Gradle only compiles classes that changed since the last compilation, and only runs
@@ -14,8 +14,7 @@ The annotation processor has two options allowing you to control incremental pro
 tasks.withType(JavaCompile) {
     options.compilerArgs += [
         '-parameters',
-        '-Ajooby.incremental=true',
-        '-Ajooby.services=true'
+        '-Ajooby.incremental=true'
     ]
 }
 ----
@@ -26,26 +25,13 @@ tasks.withType(JavaCompile) {
 kapt {
   arguments {
     arg('jooby.incremental', true)
-    arg('jooby.services', true)
   }
 }
 ----
 
 By setting `jooby.incremental` to `false` you can disable incremental processing entirely, which means
 the regardless what's changed, the whole project is recompiled each time. Defaults to `true`.
 
-The generated bytecode is responsible for registering routes, retrieving and invoking your controllers.
-Jooby loads these classes with Java's service-provider loading facility by default. To make this work,
-a so-called _provider configuration_ file needs to be created alongside with the generated classes.
-The content of this file is dependent on all MVC controllers, therefore the annotation processor
-must operate in *aggregating* mode, in which _all generated_ classes are rewritten each time.
-
-You may disable the generation of the provider configuration file by setting `jooby.services` to `false`
-(the default is `true`). This allows the annotation processor to run in *isolating* mode: if you
-change e.g. `HelloController` only, then only the class responsible for registering the routes for
-`HelloController` will be regenerated. This however will force Jooby to load the generated classes
-with reflection instead of the service-provider loading facility.
-
 The package `annotation` contains all the annotations available for MVC routes.
 
 .MVC API:
@@ -681,7 +667,7 @@ logic in the javadoc:ExecutionMode[EVENT_LOOP]:
 
 public class App extends Jooby {
   {
-    mvc(new MyController());
+    mvc(new MyController_());
   }
 
   public static void main(String[] args) {
@@ -697,7 +683,7 @@ import io.jooby.*
 
 fun main(args: Array<String>) {
   runApp(args, EVENT_LOOP) {             <1>
-    mvc(MyController())
+    mvc(MyController_())
   }
 }
 ----
@@ -713,7 +699,7 @@ Similarly, if you need to run all mvc routes in the javadoc:ExecutionMode[WORKER
 public class App extends Jooby {
   {
     dispatch(() -> {
-      mvc(new MyBlockingController());  <1>
+      mvc(new MyBlockingController_());  <1>
     });
   }
 
@@ -731,7 +717,7 @@ import io.jooby.*
 fun main(args: Array<String>) {
   runApp(args, EVENT_LOOP) {
     dispatch {
-      mvc(MyBlockingController())        <1>
+      mvc(MyBlockingController_())        <1>
     }
   }
 }
@@ -823,7 +809,7 @@ Executor must be registered using via services or executor utility method:
 {
   executor("single", Executors.newSingleThreadExecutor());
 
-  mvc(new MyController());
+  mvc(new MyController_());
 }
 ----
 
@@ -833,7 +819,7 @@ Executor must be registered using via services or executor utility method:
 {
   executor("single", Executors.newSingleThreadExecutor())
 
-  mvc(MyController())
+  mvc(MyController_())
 }
 ----
 
@@ -954,15 +940,9 @@ on them (mostly annotations processors).
         <compilerArg>
           -Ajooby.incremental=true
         </compilerArg>
-        <compilerArg>
-          -Ajooby.services=true
-        </compilerArg>
         <compilerArg>
           -Ajooby.skipAttributeAnnotations=FooAnnotation,BarAnnotation
         </compilerArg>
-        <compilerArg>
-          -Ajooby.handler=myhandler
-        </compilerArg>
       </compilerArgs>
     </configuration>
   </plugin>
@@ -976,9 +956,7 @@ tasks.withType(JavaCompile) {
         '-parameters',
         '-Ajooby.debug=false',
         '-Ajooby.incremental=true',
-        '-Ajooby.services=true',
-        '-Ajooby.skipAttributeAnnotations=FooAnnotation,BarAnnotation',
-        '-Ajooby.handler=myhandler'
+        '-Ajooby.skipAttributeAnnotations=FooAnnotation,BarAnnotation'
     ]
 }
 ----

jooby/src/main/java/io/jooby/Jooby.java

@@ -1238,7 +1238,6 @@ public static void runApp(
     var apps = new ArrayList<Jooby>();
     var targetServer = server.getLoggerOff().isEmpty() ? server : MutedServer.mute(server);
     try {
-      // Init context static var
       for (var factory : provider) {
         var app = createApp(server, executionMode, factory);
         /*

jooby/src/main/java/io/jooby/ServerOptions.java

@@ -196,7 +196,6 @@ public class ServerOptions {
       if (conf.hasPath("server.http2")) {
         options.setHttp2(conf.getBoolean("server.http2"));
       }
-
       return Optional.of(options);
     }
     return Optional.empty();

jooby/src/main/java/io/jooby/SslOptions.java

@@ -508,7 +508,7 @@ public static SslOptions selfSigned(final String type) {
    * @param key Path to use for loading SSL options. Required.
    * @return SSl options or empty.
    */
-  public static @NonNull Optional<SslOptions> from(@NonNull Config conf, String... key) {
+  static @NonNull Optional<SslOptions> from(@NonNull Config conf, String... key) {
     return Stream.of(key)
         .filter(conf::hasPath)
         .findFirst()

modules/jooby-cli/src/main/resources/cli/build.gradle.hbs

@@ -54,7 +54,6 @@ tasks.withType(JavaCompile) {
     '-parameters',
 {{#if apt}}
     '-Ajooby.incremental=true',
-    '-Ajooby.services=true',
     '-Ajooby.debug=false'
 {{/if}}
   ]

modules/jooby-cli/src/main/resources/cli/build.gradle.kts.hbs

@@ -60,7 +60,6 @@ tasks {
     kapt {
       arguments {
         arg("jooby.incremental", true)
-        arg("jooby.services", true)
         arg("jooby.debug", false)
       }
     }

modules/jooby-cli/src/main/resources/cli/docker.maven.hbs

@@ -1,11 +1,11 @@
-FROM maven:3-eclipse-temurin-17 as build
+FROM maven:3-eclipse-temurin-21 as build
 WORKDIR /{{artifactId}}
 COPY pom.xml pom.xml
 COPY src src
 COPY conf conf
 RUN mvn package
 
-FROM eclipse-temurin:17-jdk
+FROM eclipse-temurin:21-jdk
 WORKDIR /{{artifactId}}
 {{#if stork}}
 COPY --from=build /{{artifactId}}/target/stork .

modules/jooby-cli/src/main/resources/cli/pom.xml.hbs

@@ -93,9 +93,6 @@
                 <annotationProcessorArg>
                   jooby.debug=false
                 </annotationProcessorArg>
-                <annotationProcessorArg>
-                  jooby.services=true
-                </annotationProcessorArg>
               </annotationProcessorArgs>
             </configuration>
           </execution>