performance: netty optimize response headers

Author: jknack

jooby/src/main/java/io/jooby/internal/output/ContextOutputFactory.java

@@ -10,8 +10,8 @@
 
 import edu.umd.cs.findbugs.annotations.NonNull;
 import io.jooby.internal.output.CompositeOutput;
-import io.jooby.internal.output.ContextOutputFactory;
 import io.jooby.internal.output.StaticOutput;
+import io.jooby.internal.output.WrappedOutput;
 
 /**
  * An output factory backed by {@link ByteBuffer}.
@@ -20,6 +20,33 @@
  * @since 4.0.0
  */
 public class ByteBufferedOutputFactory implements OutputFactory {
+
+  private static class ContextOutputFactory extends ByteBufferedOutputFactory {
+    public ContextOutputFactory(OutputOptions options) {
+      super(options);
+    }
+
+    @Override
+    public Output wrap(@NonNull ByteBuffer buffer) {
+      return new WrappedOutput(buffer);
+    }
+
+    @Override
+    public Output wrap(@NonNull String value, @NonNull Charset charset) {
+      return new WrappedOutput(charset.encode(value));
+    }
+
+    @Override
+    public Output wrap(@NonNull byte[] bytes) {
+      return new WrappedOutput(ByteBuffer.wrap(bytes));
+    }
+
+    @Override
+    public Output wrap(@NonNull byte[] bytes, int offset, int length) {
+      return new WrappedOutput(ByteBuffer.wrap(bytes, offset, length));
+    }
+  }
+
   private OutputOptions options;
 
   public ByteBufferedOutputFactory(OutputOptions options) {

jooby/src/main/java/io/jooby/output/ByteBufferedOutputFactory.java

@@ -20,6 +20,7 @@
  * @see BufferedOutput
  */
 public interface Output {
+
   /**
    * A read-only view as {@link ByteBuffer}.
    *

jooby/src/main/java/io/jooby/output/Output.java

@@ -490,7 +490,9 @@ static void encoderHeader(CharSequence name, CharSequence value, ByteBuf buf) {
   }
 
   private static void writeAscii(ByteBuf buf, int offset, CharSequence value) {
-    if (value instanceof AsciiString ascii) {
+    if (value instanceof NettyString netty) {
+      buf.setBytes(offset, netty.bytes, 0, netty.bytes.length);
+    } else if (value instanceof AsciiString ascii) {
       buf.setBytes(offset, ascii.array(), ascii.arrayOffset(), value.length());
     } else {
       buf.setCharSequence(offset, value, CharsetUtil.US_ASCII);

modules/jooby-netty/src/main/java/io/jooby/internal/netty/HeadersMultiMap.java

@@ -11,24 +11,22 @@
 import java.util.concurrent.ScheduledExecutorService;
 import java.util.concurrent.TimeUnit;
 
-import io.netty.util.AsciiString;
-
 public class NettyDateService implements Runnable {
   private static final int DATE_INTERVAL = 1000;
-  private AsciiString date;
+  private CharSequence date;
 
   public NettyDateService(ScheduledExecutorService scheduler) {
     scheduler.scheduleAtFixedRate(this, 0, DATE_INTERVAL, TimeUnit.MILLISECONDS);
   }
 
-  public AsciiString date() {
+  public CharSequence date() {
     return this.date;
   }
 
   @Override
   public void run() {
     this.date =
-        new AsciiString(
+        new NettyString(
             DateTimeFormatter.RFC_1123_DATE_TIME.format(ZonedDateTime.now(ZoneOffset.UTC)));
   }
 }

modules/jooby-netty/src/main/java/io/jooby/internal/netty/NettyDateService.java

@@ -22,11 +22,14 @@
 import io.netty.handler.codec.http.multipart.*;
 import io.netty.handler.codec.http.websocketx.WebSocketFrame;
 import io.netty.handler.timeout.IdleStateEvent;
-import io.netty.util.AsciiString;
 
 public class NettyHandler extends ChannelInboundHandlerAdapter {
   private final Logger log = LoggerFactory.getLogger(NettyServer.class);
-  private static final AsciiString server = AsciiString.cached("N");
+  private static final CharSequence server = NettyString.of("N");
+  public static final CharSequence CONTENT_TYPE = NettyString.of("content-type");
+  public static final CharSequence TEXT_PLAIN = NettyString.of("text/plain");
+  public static final CharSequence DATE = NettyString.of("date");
+  public static final CharSequence SERVER = NettyString.of("server");
   private final NettyDateService serverDate;
   private final List<Jooby> applications;
   private Router router;
@@ -66,10 +69,10 @@ public void channelRead(ChannelHandlerContext ctx, Object msg) {
       context = new NettyContext(ctx, req, app, path, bufferSize, http2);
 
       if (defaultHeaders) {
-        context.setHeaders.set(HttpHeaderNames.DATE, serverDate.date());
-        context.setHeaders.set(HttpHeaderNames.SERVER, server);
+        context.setHeaders.set(DATE, serverDate.date());
+        context.setHeaders.set(SERVER, server);
       }
-      context.setHeaders.set(HttpHeaderNames.CONTENT_TYPE, HttpHeaderValues.TEXT_PLAIN);
+      context.setHeaders.set(CONTENT_TYPE, TEXT_PLAIN);
 
       if (req.method() == HttpMethod.GET) {
         router.match(context).execute(context);

modules/jooby-netty/src/main/java/io/jooby/internal/netty/NettyHandler.java

@@ -89,11 +89,6 @@ public ByteBufAllocator getAllocator() {
     return new NettyOutputStatic(buffer.remaining(), () -> Unpooled.wrappedBuffer(buffer));
   }
 
-  @Override
-  @NonNull public Output wrap(@NonNull String value, @NonNull Charset charset) {
-    return new NettyByteBufOutput(Unpooled.wrappedBuffer(value.getBytes(charset)));
-  }
-
   @Override
   @NonNull public Output wrap(@NonNull byte[] bytes) {
     return new NettyOutputStatic(bytes.length, () -> Unpooled.wrappedBuffer(bytes));

modules/jooby-netty/src/main/java/io/jooby/internal/netty/NettyOutputFactory.java

@@ -10,17 +10,16 @@
 import edu.umd.cs.findbugs.annotations.NonNull;
 import io.jooby.Context;
 import io.netty.buffer.ByteBuf;
-import io.netty.util.AsciiString;
 
 public class NettyOutputStatic implements NettyByteBufRef {
   private final Supplier<ByteBuf> provider;
   private final int size;
-  private final AsciiString contentLength;
+  private final NettyString contentLength;
 
   protected NettyOutputStatic(int length, Supplier<ByteBuf> provider) {
     this.provider = provider;
     this.size = length;
-    this.contentLength = AsciiString.cached(Integer.toString(length));
+    this.contentLength = new NettyString(Integer.toString(length));
   }
 
   @Override

modules/jooby-netty/src/main/java/io/jooby/internal/netty/NettyOutputStatic.java

@@ -0,0 +1,45 @@
+/*
+ * Jooby https://jooby.io
+ * Apache License Version 2.0 https://jooby.io/LICENSE.txt
+ * Copyright 2014 Edgar Espina
+ */
+package io.jooby.internal.netty;
+
+import java.nio.charset.StandardCharsets;
+
+import edu.umd.cs.findbugs.annotations.NonNull;
+
+public class NettyString implements CharSequence {
+
+  final byte[] bytes;
+  private final String value;
+
+  public NettyString(String value) {
+    this.value = value;
+    this.bytes = value.getBytes(StandardCharsets.US_ASCII);
+  }
+
+  public static NettyString of(String value) {
+    return new NettyString(value);
+  }
+
+  @Override
+  public int length() {
+    return value.length();
+  }
+
+  @Override
+  public char charAt(int index) {
+    return value.charAt(index);
+  }
+
+  @Override
+  @NonNull public CharSequence subSequence(int start, int end) {
+    return value.subSequence(start, end);
+  }
+
+  @Override
+  @NonNull public String toString() {
+    return value;
+  }
+}

modules/jooby-netty/src/main/java/io/jooby/internal/netty/NettyString.java

@@ -8,8 +8,6 @@
 import static io.jooby.ExecutionMode.EVENT_LOOP;
 import static io.jooby.MediaType.JSON;
 
-import java.nio.charset.StandardCharsets;
-
 import io.jooby.Jooby;
 import io.jooby.StatusCode;
 import io.jooby.netty.NettyServer;
@@ -18,15 +16,12 @@ public class Performance extends Jooby {
 
   private static final String MESSAGE = "Hello, World!";
 
-  private static final byte[] MESSAGE_BYTES = MESSAGE.getBytes(StandardCharsets.UTF_8);
-
   {
     var outputFactory = getOutputFactory();
-    var message = outputFactory.wrap(MESSAGE_BYTES);
+    var message = outputFactory.wrap(MESSAGE);
     get(
         "/plaintext",
         ctx -> {
-          // return ctx.send(outputFactory.wrap(MESSAGE_BYTES));
           return ctx.send(message);
         });