router: deprecated mvc(Class, *) router

- Fix  #3658
[minor] Default route suffix doesn't match reflection-based MVC fix #3657

Author: jknack

jooby/src/main/java/io/jooby/Jooby.java

@@ -541,17 +541,20 @@ public Jooby mvc(@NonNull MvcExtension router) {
   }
 
   @NonNull @Override
+  @Deprecated(since = "3.8.0", forRemoval = true)
   public Jooby mvc(@NonNull Object router) {
     Provider provider = () -> router;
     return mvc(router.getClass(), provider);
   }
 
   @NonNull @Override
+  @Deprecated(since = "3.8.0", forRemoval = true)
   public Jooby mvc(@NonNull Class router) {
     return mvc(router, () -> require(router));
   }
 
   @NonNull @Override
+  @Deprecated(since = "3.8.0", forRemoval = true)
   public <T> Jooby mvc(@NonNull Class<T> router, @NonNull Provider<T> provider) {
     try {
       MvcFactory module = loadModule(router);
@@ -563,6 +566,7 @@ public <T> Jooby mvc(@NonNull Class<T> router, @NonNull Provider<T> provider) {
     }
   }
 
+  @Deprecated(since = "3.8.0", forRemoval = true)
   private <T> MvcFactory<T> loadModule(Class<T> router) {
     try {
       ServiceLoader<MvcFactory> modules = ServiceLoader.load(MvcFactory.class);
@@ -571,10 +575,10 @@ private <T> MvcFactory<T> loadModule(Class<T> router) {
           .findFirst()
           .orElseGet(
               () ->
-                  /** Make happy IDE incremental build: */
+                  /* Make happy IDE incremental build: */
                   mvcReflectionFallback(router, getClassLoader()));
     } catch (ServiceConfigurationError notfound) {
-      /** Make happy IDE incremental build: */
+      /* Make happy IDE incremental build: */
       return mvcReflectionFallback(router, getClassLoader());
     }
   }
@@ -1508,7 +1512,10 @@ private void joobyRunHook(ClassLoader loader, Server server) {
    */
   private MvcFactory mvcReflectionFallback(Class source, ClassLoader classLoader) {
     try {
-      String moduleName = source.getName() + "$Module";
+      var moduleName =
+          System.getProperty("jooby.routerPrefix", "")
+              + source.getName()
+              + System.getProperty("jooby.routerSuffix", "_");
       Class<?> moduleType = classLoader.loadClass(moduleName);
       Constructor<?> constructor = moduleType.getDeclaredConstructor();
       getLog().debug("Loading mvc using reflection: " + source);

jooby/src/main/java/io/jooby/MvcFactory.java

@@ -12,6 +12,7 @@
  *
  * @since 2.1.0
  */
+@Deprecated(since = "3.8.0", forRemoval = true)
 public interface MvcFactory<T> {
   /**
    * Check if the factory applies for the given MVC route.