Skip to content

Commit cf4cdad

Browse files
committed
remove default setting of hosts
1 parent 978fe3a commit cf4cdad

File tree

3 files changed

+6
-4
lines changed

3 files changed

+6
-4
lines changed

modules/jooby-jedis/src/main/java/org/jooby/jedis/RedisSentinel.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -238,9 +238,9 @@ public class RedisSentinel extends Redis {
238238
* application.conf
239239
*
240240
* <pre>
241-
* jedis.sentinel.hosts = ["localhost:26379"]
241+
* jedis.sentinel.hosts = ["localhost:26379", "host2:26379"]
242242
* jedis.sentinel.master = "master"
243-
* jedis.password = ""
243+
* jedis.password = "mySuperSecretPasswordPutHere"
244244
* </pre>
245245
*
246246
* Example:

modules/jooby-jedis/src/main/resources/org/jooby/jedis/jedis.conf

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,6 @@ jedis.pool.jmxNamePrefix = redis-pool
2525
jedis.session.prefix = sessions
2626
jedis.session.timeout = ${session.timeout}
2727

28-
jedis.sentinel.hosts = ["localhost:26379"]
28+
jedis.sentinel.hosts = []
2929
jedis.sentinel.master = "master"
3030
jedis.password = ""

modules/jooby-jedis/src/test/java/org/jooby/jedis/RedisSentinelTest.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@
1717
import org.powermock.modules.junit4.PowerMockRunner;
1818
import redis.clients.jedis.JedisSentinelPool;
1919

20+
import java.util.Collections;
2021
import java.util.HashSet;
2122
import java.util.Set;
2223

@@ -38,7 +39,8 @@ public class RedisSentinelTest {
3839
@SuppressWarnings("unchecked")
3940
@Test
4041
public void shouldGetJedisSentinelInstance() throws Exception {
41-
Config config = jedisConfig().withValue("db", ConfigValueFactory.fromAnyRef("redis://localhost:26379"));
42+
Config config = jedisConfig().withValue("db", ConfigValueFactory.fromAnyRef("redis://localhost:26379"))
43+
.withValue("jedis.sentinel.hosts", ConfigValueFactory.fromAnyRef(Collections.singletonList("localhost:26379")));
4244
new MockUnit(Env.class, Binder.class, JedisSentinelPool.class)
4345
.expect(unit -> {
4446
Env env = unit.get(Env.class);

0 commit comments

Comments
 (0)