code cleanup: remove List.of application

Author: jknack

jooby/src/main/java/io/jooby/buffer/README

@@ -8,3 +8,11 @@ Copy from: https://github.com/spring-projects/spring-framework/tree/main/spring-
 - replace reactive stream classes references by JDK reactive streams
 - DataBufferUtils is a limited version of original - remove Deprecated methods
 - Remove all deprecated since 6.0 from DataBuffer and DataBufferFactory
+
+
+= NEW BUFFER API
+
+== JETTY
+  - https://github.com/jetty/jetty.project/issues/10476
+  - https://javadoc.jetty.org/jetty-12/org/eclipse/jetty/util/BufferUtil.html
+  - https://stackoverflow.com/questions/78659372/how-do-you-set-in-jetty-12-a-max-request-size-programmatically

modules/jooby-jetty/src/main/java/io/jooby/jetty/JettyServer.java

@@ -47,7 +47,6 @@ public class JettyServer extends io.jooby.Server.Base {
   private Server server;
 
   private ThreadPool threadPool;
-  private List<Jooby> applications = new ArrayList<>();
 
   private ServerOptions options = new ServerOptions().setServer("jetty").setWorkerThreads(THREADS);
   private Consumer<HttpConfiguration> httpConfigurer;
@@ -96,20 +95,19 @@ public io.jooby.Server start(@NonNull Jooby application) {
           "org.eclipse.jetty.server.Request.maxFormContentSize",
           Long.toString(options.getMaxRequestSize()));
 
-      applications.add(application);
-
       addShutdownHook();
 
       if (threadPool == null) {
         threadPool = new QueuedThreadPool(options.getWorkerThreads());
         ((QueuedThreadPool) threadPool).setName("worker");
       }
 
-      fireStart(applications, threadPool);
+      fireStart(List.of(application), threadPool);
 
       var acceptors = 1;
       var selectors = options.getIoThreads();
       this.server = new Server(threadPool);
+      server.addBean(application);
       server.setStopAtShutdown(false);
 
       JettyHttp2Configurer http2 =
@@ -217,7 +215,7 @@ public io.jooby.Server start(@NonNull Jooby application) {
       Handler handler =
           new JettyHandler(
               invocationType,
-              applications.get(0),
+              application,
               options.getBufferSize(),
               options.getMaxRequestSize(),
               options.getDefaultHeaders());
@@ -255,7 +253,7 @@ public io.jooby.Server start(@NonNull Jooby application) {
       server.setHandler(context);
       server.start();
 
-      fireReady(applications);
+      fireReady(List.of(application));
     } catch (Exception x) {
       if (io.jooby.Server.isAddressInUse(x.getCause())) {
         x = new BindException("Address already in use: " + options.getPort());
@@ -289,9 +287,9 @@ private void isNotInUse(List<String> protocols, String protocol, Consumer<String
 
   @NonNull @Override
   public synchronized io.jooby.Server stop() {
-    fireStop(applications);
-    applications.clear();
     if (server != null) {
+      var app = server.getBean(Jooby.class);
+      fireStop(List.of(app));
       try {
         server.stop();
       } catch (Exception x) {

modules/jooby-netty/src/main/java/io/jooby/netty/NettyServer.java

@@ -10,7 +10,6 @@
 import static java.util.concurrent.Executors.newFixedThreadPool;
 
 import java.net.BindException;
-import java.util.ArrayList;
 import java.util.Arrays;
 import java.util.List;
 import java.util.concurrent.ExecutionException;
@@ -54,13 +53,13 @@ public class NettyServer extends Server.Base {
 
   private static final int _100 = 100;
 
-  private List<Jooby> applications = new ArrayList<>();
   private EventLoopGroup acceptorloop;
   private EventLoopGroup eventloop;
   private EventLoopGroup dateLoop;
   private ExecutorService worker;
 
   private NettyDataBufferFactory bufferFactory;
+  private Jooby application;
 
   private ServerOptions options = new ServerOptions().setServer("netty");
 
@@ -116,6 +115,7 @@ public String getName() {
   @NonNull @Override
   public Server start(@NonNull Jooby application) {
     try {
+      this.application = application;
       /* Worker: Application blocking code */
       if (worker == null) {
         worker = newFixedThreadPool(options.getWorkerThreads(), new DefaultThreadFactory("worker"));
@@ -125,14 +125,13 @@ public Server start(@NonNull Jooby application) {
       }
       // Make sure context use same buffer factory
       application.setBufferFactory(bufferFactory);
-      applications.add(application);
 
       addShutdownHook();
 
-      fireStart(applications, worker);
+      fireStart(List.of(application), worker);
 
       /* Disk attributes: */
-      String tmpdir = applications.get(0).getTmpdir().toString();
+      String tmpdir = application.getTmpdir().toString();
       DiskFileUpload.baseDirectory = tmpdir;
       DiskAttribute.baseDirectory = tmpdir;
 
@@ -174,7 +173,7 @@ public Server start(@NonNull Jooby application) {
             "Server configured for httpsOnly, but ssl options not set");
       }
 
-      fireReady(applications);
+      fireReady(List.of(application));
     } catch (InterruptedException x) {
       throw SneakyThrows.propagate(x);
     } catch (ExecutionException x) {
@@ -207,7 +206,6 @@ private ClientAuth toClientAuth(SslOptions.ClientAuth clientAuth) {
 
   private NettyPipeline newPipeline(
       SslContext sslContext, HttpDataFactory factory, NettyDateService dateService, boolean http2) {
-    var router = applications.get(0);
     var bufferSize = options.getBufferSize();
     var headersFactory = HeadersMultiMap.httpHeadersFactory();
     var decoderConfig =
@@ -222,7 +220,7 @@ private NettyPipeline newPipeline(
         dateService,
         factory,
         decoderConfig,
-        router,
+        application,
         options.getMaxRequestSize(),
         bufferSize,
         options.getDefaultHeaders(),
@@ -233,8 +231,7 @@ private NettyPipeline newPipeline(
 
   @NonNull @Override
   public synchronized Server stop() {
-    fireStop(applications);
-    applications.clear();
+    fireStop(List.of(application));
     // only for jooby build where close events may take longer.
     NettyWebSocket.all.clear();
 

modules/jooby-undertow/src/main/java/io/jooby/undertow/UndertowServer.java

@@ -8,8 +8,6 @@
 import static io.undertow.UndertowOptions.ENABLE_HTTP2;
 
 import java.net.BindException;
-import java.util.ArrayList;
-import java.util.Collections;
 import java.util.List;
 import java.util.Optional;
 
@@ -50,8 +48,7 @@ public class UndertowServer extends Server.Base {
   private static final int _10 = 10;
 
   private Undertow server;
-
-  private List<Jooby> applications = new ArrayList<>();
+  private Jooby application;
 
   private ServerOptions options =
       new ServerOptions().setIoThreads(ServerOptions.IO_THREADS).setServer("utow");
@@ -76,13 +73,13 @@ public String getName() {
   @Override
   public @NonNull Server start(@NonNull Jooby application) {
     try {
-      applications.add(application);
+      this.application = application;
 
       addShutdownHook();
 
       HttpHandler handler =
           new UndertowHandler(
-              applications.get(0),
+              application,
               options.getBufferSize(),
               options.getMaxRequestSize(),
               options.getDefaultHeaders());
@@ -151,11 +148,11 @@ public String getName() {
       } else if (options.isHttpsOnly()) {
         throw new StartupException("Server configured for httpsOnly, but ssl options not set");
       }
-      fireStart(applications, worker);
+      fireStart(List.of(application), worker);
       server = builder.build();
       server.start();
 
-      fireReady(Collections.singletonList(application));
+      fireReady(List.of(application));
 
       return this;
     } catch (Exception x) {
@@ -184,8 +181,7 @@ private SslClientAuthMode toSslClientAuthMode(SslOptions.ClientAuth clientAuth)
   @NonNull @Override
   public synchronized Server stop() {
     try {
-      fireStop(applications);
-      applications.clear();
+      fireStop(List.of(application));
     } catch (Exception x) {
       throw SneakyThrows.propagate(x);
     } finally {