build: reduce log

Author: jknack

modules/jooby-apt/src/test/java/io/jooby/apt/ProcessorRunner.java

@@ -99,8 +99,17 @@ public ProcessorRunner(Object instance) throws IOException {
     this(instance, Map.of());
   }
 
+  public ProcessorRunner(Object instance, Consumer<String> stdout) throws IOException {
+    this(instance, stdout, Map.of());
+  }
+
   public ProcessorRunner(Object instance, Map<String, Object> options) throws IOException {
-    this.processor = new HookJoobyProcessor(System.out::println);
+    this(instance, System.out::println, options);
+  }
+
+  public ProcessorRunner(Object instance, Consumer<String> stdout, Map<String, Object> options)
+      throws IOException {
+    this.processor = new HookJoobyProcessor(stdout::accept);
     var optionsArray =
         options.entrySet().stream().map(e -> "-A" + e.getKey() + "=" + e.getValue()).toList();
     Truth.assert_()

modules/jooby-apt/src/test/java/tests/verifyarg/VerifyArgTypeTest.java

@@ -21,8 +21,15 @@ class VerifyArgTypeTest {
   @ParameterizedTest
   @MethodSource("provideControllers")
   public void compileController_illegalArgumentType_shouldThrowException(Object controller) {
-    RuntimeException ex =
-        assertThrows(RuntimeException.class, () -> new ProcessorRunner(controller));
+    var ex =
+        assertThrows(
+            RuntimeException.class,
+            () ->
+                new ProcessorRunner(
+                    controller,
+                    error -> {
+                      // NOOP
+                    }));
 
     assertTrue(ex.getMessage().contains("Illegal argument type at"));
   }

modules/jooby-test/src/test/java/io/jooby/test/TestApp.java

@@ -5,11 +5,15 @@
  */
 package io.jooby.test;
 
+import java.util.List;
+
 import io.jooby.Jooby;
 import io.jooby.RouterOption;
+import io.jooby.StartupSummary;
 
 public class TestApp extends Jooby {
   {
+    setStartupSummary(List.of(StartupSummary.NONE));
     setRouterOptions(RouterOption.IGNORE_CASE, RouterOption.IGNORE_TRAILING_SLASH);
     setContextPath("/test");
     get("/", ctx -> "OK");

modules/jooby-test/src/test/java/io/jooby/test/TestArgApp.java

@@ -5,10 +5,14 @@
  */
 package io.jooby.test;
 
+import java.util.List;
+
 import io.jooby.Jooby;
+import io.jooby.StartupSummary;
 
 public class TestArgApp extends Jooby {
   public TestArgApp(String name) {
+    setStartupSummary(List.of(StartupSummary.NONE));
     get("/", ctx -> name);
   }
 }

tests/src/test/java/io/jooby/junit/ServerTestRunner.java

@@ -100,16 +100,9 @@ public void ready(SneakyThrows.Consumer2<WebClient, WebClient> onReady) {
       if (mavenBuild) {
         applogger = app.getClass().getName();
         app.setStartupSummary(List.of(StartupSummary.NONE));
-        if (app.getErrorHandler() == null) {
-          app.error(
-              new DefaultErrorHandler() {
-                @Override
-                protected void log(Context ctx, Throwable cause, StatusCode code) {
-                  app.getLog()
-                      .info(ErrorHandler.errorMessage(ctx, code) + ": " + cause.getMessage());
-                }
-              });
-        }
+        app.error(
+            Optional.ofNullable(app.getErrorHandler())
+                .orElseGet(ServerTestRunner::buildErrorHandler));
       }
 
       ServerOptions serverOptions = app.getServerOptions();
@@ -154,6 +147,18 @@ protected void log(Context ctx, Throwable cause, StatusCode code) {
     }
   }
 
+  private static DefaultErrorHandler buildErrorHandler() {
+    return new DefaultErrorHandler() {
+      @Override
+      protected void log(Context ctx, Throwable cause, StatusCode code) {
+        ctx.getRouter()
+            .getLog()
+            .info(ErrorHandler.errorMessage(ctx, code) + ": " + cause.getMessage());
+        ctx.getRouter().getLog().debug(ErrorHandler.errorMessage(ctx, code), cause.getMessage());
+      }
+    };
+  }
+
   private boolean disabled() {
     var osname = System.getProperty("os.name").toLowerCase();
     var osarch = System.getProperty("os.arch").toLowerCase();

tests/src/test/java/io/jooby/problem/data/App.java

@@ -120,7 +120,7 @@ public class App extends Jooby {
     get(
         "/throw-illegal-state-exception",
         ctx -> {
-          throw new IllegalStateException();
+          throw new IllegalStateException("expected error");
         });
 
     get(

tests/src/test/java/io/jooby/test/Issue1349.java

@@ -6,6 +6,7 @@
 package io.jooby.test;
 
 import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertTrue;
 
 import io.jooby.Jooby;
 import io.jooby.StatusCode;
@@ -17,12 +18,6 @@ public class Issue1349 {
 
   public static class App1349 extends Jooby {
     {
-      error(
-          IllegalAccessException.class,
-          ((ctx, cause, statusCode) -> {
-            ctx.setResponseCode(statusCode);
-            ctx.send(cause.getMessage());
-          }));
       get("/1349", ctx -> something());
       get("/1349/iae", ctx -> throwsIAE());
     }
@@ -51,7 +46,7 @@ public void issue1349(ServerTestRunner runner) {
                   "/1349/iae",
                   rsp -> {
                     assertEquals(500, rsp.code());
-                    assertEquals("no-access", rsp.body().string());
+                    assertTrue(rsp.body().string().contains("message: no-access"));
                   });
             });
   }