performance: netty

- remove some slow path checks
- fix bug on date header generator

Author: jknack

modules/jooby-netty/src/main/java/io/jooby/internal/netty/HeadersMultiMap.java

@@ -490,10 +490,13 @@ static void encoderHeader(CharSequence name, CharSequence value, ByteBuf buf) {
   }
 
   private static void writeAscii(ByteBuf buf, int offset, CharSequence value) {
-    if (value instanceof NettyString netty) {
-      buf.setBytes(offset, netty.bytes, 0, netty.bytes.length);
-    } else if (value instanceof AsciiString ascii) {
-      buf.setBytes(offset, ascii.array(), ascii.arrayOffset(), value.length());
+    var clazz = value.getClass();
+    if (clazz == NettyString.class) {
+      var nettyString = (NettyString) value;
+      buf.setBytes(offset, nettyString.bytes, 0, nettyString.bytes.length);
+    } else if (clazz == AsciiString.class) {
+      var asciiString = (AsciiString) value;
+      buf.setBytes(offset, asciiString.array(), asciiString.arrayOffset(), value.length());
     } else {
       buf.setCharSequence(offset, value, CharsetUtil.US_ASCII);
     }

modules/jooby-netty/src/main/java/io/jooby/internal/netty/NettyDateService.java

@@ -16,7 +16,10 @@ public class NettyDateService implements Runnable {
   private CharSequence date;
 
   public NettyDateService(ScheduledExecutorService scheduler) {
-    scheduler.scheduleAtFixedRate(this, 0, DATE_INTERVAL, TimeUnit.MILLISECONDS);
+    this.date =
+        new NettyString(
+            DateTimeFormatter.RFC_1123_DATE_TIME.format(ZonedDateTime.now(ZoneOffset.UTC)));
+    scheduler.scheduleAtFixedRate(this, DATE_INTERVAL, DATE_INTERVAL, TimeUnit.MILLISECONDS);
   }
 
   public CharSequence date() {

modules/jooby-netty/src/main/java/io/jooby/internal/netty/NettyRequestDecoder.java

@@ -27,6 +27,11 @@ protected HttpMessage createMessage(String[] initialLine) throws Exception {
         headersFactory);
   }
 
+  @Override
+  protected boolean isContentAlwaysEmpty(HttpMessage msg) {
+    return false;
+  }
+
   private static HttpMethod valueOf(String name) {
     // fast-path
     if (name == GET) {
@@ -42,15 +47,6 @@ private static HttpMethod valueOf(String name) {
       return HttpMethod.PUT;
     }
     // "slow"-path: ensure method is on upper case
-    return HttpMethod.valueOf(toUpperCase(name));
-  }
-
-  private static String toUpperCase(String name) {
-    for (int i = 0; i < name.length(); i++) {
-      if (Character.isLowerCase(name.charAt(i))) {
-        return name.toUpperCase();
-      }
-    }
-    return name;
+    return HttpMethod.valueOf(name.toUpperCase());
   }
 }

modules/jooby-netty/src/main/java/io/jooby/internal/netty/NettyResponseEncoder.java

@@ -12,8 +12,8 @@
 public class NettyResponseEncoder extends HttpResponseEncoder {
   @Override
   protected void encodeHeaders(HttpHeaders headers, ByteBuf buf) {
-    if (headers instanceof HeadersMultiMap headersMultiMap) {
-      headersMultiMap.encode(buf);
+    if (headers.getClass() == HeadersMultiMap.class) {
+      ((HeadersMultiMap) headers).encode(buf);
     } else {
       super.encodeHeaders(headers, buf);
     }

tests/src/test/java/examples/Performance.java

@@ -43,6 +43,10 @@ public class Performance extends Jooby {
 
   public static void main(final String[] args) {
     System.setProperty("io.netty.disableHttpHeadersValidation", "true");
-    runApp(args, new NettyServer(new ServerOptions()), EVENT_LOOP, Performance::new);
+    runApp(
+        args,
+        new NettyServer(new ServerOptions()).setSingleEventLoopGroup(true),
+        EVENT_LOOP,
+        Performance::new);
   }
 }