Updating codestyle

Hackwar · Hackwar · commit 18ab4a176b1e · 2025-03-02T21:42:08.000+01:00
diff --git a/src/administrator/components/com_weblinks/script.php b/src/administrator/components/com_weblinks/script.php
@@ -311,13 +311,13 @@ private function addColumnsIfNeeded()
         $db    = Factory::getDbo();
         $table = $db->getTableColumns('#__weblinks');
 
-        if (!array_key_exists('version', $table)) {
+        if (!\array_key_exists('version', $table)) {
             $sql = 'ALTER TABLE ' . $db->quoteName('#__weblinks') . ' ADD COLUMN ' . $db->quoteName('version') . " int unsigned NOT NULL DEFAULT '1'";
             $db->setQuery($sql);
             $db->execute();
         }
 
-        if (!array_key_exists('images', $table)) {
+        if (!\array_key_exists('images', $table)) {
             $sql = 'ALTER TABLE ' . $db->quoteName('#__weblinks') . ' ADD COLUMN ' . $db->quoteName('images') . ' text NOT NULL';
             $db->setQuery($sql);
             $db->execute();
diff --git a/src/administrator/components/com_weblinks/src/Extension/WeblinksComponent.php b/src/administrator/components/com_weblinks/src/Extension/WeblinksComponent.php
@@ -122,7 +122,7 @@ public function getContexts(): array
      *
      * @since   4.0.0
      */
-    protected function getTableNameForSection(string $section = null)
+    protected function getTableNameForSection(?string $section = null)
     {
         return ($section === 'category' ? 'categories' : 'weblinks');
     }
@@ -136,7 +136,7 @@ protected function getTableNameForSection(string $section = null)
      *
      * @since   4.0.0
      */
-    protected function getStateColumnForSection(string $section = null)
+    protected function getStateColumnForSection(?string $section = null)
     {
         return 'state';
     }
diff --git a/src/administrator/components/com_weblinks/src/Field/Modal/WeblinkField.php b/src/administrator/components/com_weblinks/src/Field/Modal/WeblinkField.php
@@ -60,7 +60,7 @@ protected function getInput()
         // Script to proxy the select modal function to the modal-fields.js file.
         if ($allowSelect) {
             static $scriptSelect = null;
-            if (is_null($scriptSelect)) {
+            if (\is_null($scriptSelect)) {
                 $scriptSelect = [];
             }
 
diff --git a/src/administrator/components/com_weblinks/src/Helper/AssociationsHelper.php b/src/administrator/components/com_weblinks/src/Helper/AssociationsHelper.php
@@ -147,7 +147,7 @@ public function getType($typeName = '')
         $joins   = [];
         $support = $this->getSupportTemplate();
         $title   = '';
-        if (in_array($typeName, $this->itemTypes)) {
+        if (\in_array($typeName, $this->itemTypes)) {
             switch ($typeName) {
                 case 'weblink':
                     $support['state']     = true;
diff --git a/src/administrator/components/com_weblinks/src/Model/WeblinkModel.php b/src/administrator/components/com_weblinks/src/Model/WeblinkModel.php
@@ -376,7 +376,7 @@ protected function preprocessForm(Form $form, $data, $group = 'content')
         if (Associations::isEnabled()) {
             $languages = LanguageHelper::getContentLanguages(false, false, null, 'ordering', 'asc');
 
-            if (count($languages) > 1) {
+            if (\count($languages) > 1) {
                 $addform = new \SimpleXMLElement('<form />');
                 $fields  = $addform->addChild('fields');
                 $fields->addAttribute('name', 'associations');
diff --git a/src/administrator/components/com_weblinks/src/Model/WeblinksModel.php b/src/administrator/components/com_weblinks/src/Model/WeblinksModel.php
@@ -37,7 +37,7 @@ class WeblinksModel extends ListModel
      * @see     JControllerLegacy
      * @since   1.6
      */
-    public function __construct($config = [], MVCFactoryInterface $factory = null)
+    public function __construct($config = [], ?MVCFactoryInterface $factory = null)
     {
         if (empty($config['filter_fields'])) {
             $config['filter_fields'] = [
diff --git a/src/administrator/components/com_weblinks/src/Service/HTML/AdministratorService.php b/src/administrator/components/com_weblinks/src/Service/HTML/AdministratorService.php
@@ -77,7 +77,7 @@ public function association($weblinkid)
                 $languages         = LanguageHelper::getContentLanguages([0, 1]);
                 $content_languages = array_column($languages, 'lang_code');
                 foreach ($items as &$item) {
-                    if (in_array($item->lang_code, $content_languages)) {
+                    if (\in_array($item->lang_code, $content_languages)) {
                         $text    = $item->lang_code;
                         $url     = Route::_('index.php?option=com_weblinks&task=weblink.edit&id=' . (int) $item->id);
                         $tooltip = '<strong>' . htmlspecialchars($item->language_title, ENT_QUOTES, 'UTF-8') . '</strong><br>'
diff --git a/src/administrator/components/com_weblinks/src/View/Weblink/HtmlView.php b/src/administrator/components/com_weblinks/src/View/Weblink/HtmlView.php
@@ -68,7 +68,7 @@ public function display($tpl = null)
         $this->form  = $model->getForm();
 
         // Check for errors.
-        if (count($errors = $model->getErrors())) {
+        if (\count($errors = $model->getErrors())) {
             throw new GenericDataException(implode("\n", $errors), 500);
         }
 
@@ -114,7 +114,7 @@ protected function addToolbar()
         // Build the actions for new and existing records.
         if ($isNew) {
             // For new records, check the create permission.
-            if (count($user->getAuthorisedCategories('com_weblinks', 'core.create')) > 0) {
+            if (\count($user->getAuthorisedCategories('com_weblinks', 'core.create')) > 0) {
                 ToolbarHelper::apply('weblink.apply');
 
                 ToolbarHelper::saveGroup(
diff --git a/src/administrator/components/com_weblinks/src/View/Weblinks/HtmlView.php b/src/administrator/components/com_weblinks/src/View/Weblinks/HtmlView.php
@@ -88,7 +88,7 @@ public function display($tpl = null)
         $this->activeFilters = $this->get('ActiveFilters');
 
         // Check for errors.
-        if (count($errors = $this->get('Errors'))) {
+        if (\count($errors = $this->get('Errors'))) {
             throw new GenericDataException(implode("\n", $errors), 500);
         }
 
diff --git a/src/components/com_weblinks/src/Controller/WeblinkController.php b/src/components/com_weblinks/src/Controller/WeblinkController.php
@@ -269,7 +269,7 @@ public function go()
 
         // Check whether item access level allows access.
         $groups = $this->app->getIdentity()->getAuthorisedViewLevels();
-        if (!in_array($link->access, $groups)) {
+        if (!\in_array($link->access, $groups)) {
             throw new \Exception(Text::_('JERROR_ALERTNOAUTHOR'), 403);
         }
 
@@ -284,7 +284,7 @@ public function go()
         }
 
         // Check whether item access level allows access.
-        if (!in_array($category->access, $groups)) {
+        if (!\in_array($category->access, $groups)) {
             throw new \Exception(Text::_('JERROR_ALERTNOAUTHOR'), 403);
         }
 
diff --git a/src/components/com_weblinks/src/Helper/AssociationHelper.php b/src/components/com_weblinks/src/Helper/AssociationHelper.php
@@ -37,7 +37,7 @@ abstract class AssociationHelper extends CategoryAssociationHelper
     public static function getAssociations($id = 0, $view = null)
     {
         $input = Factory::getApplication()->input;
-        $view  = is_null($view) ? $input->get('view') : $view;
+        $view  = \is_null($view) ? $input->get('view') : $view;
         $id    = empty($id) ? $input->getInt('id') : $id;
         if ($view === 'weblink') {
             if ($id) {
diff --git a/src/components/com_weblinks/src/Model/CategoriesModel.php b/src/components/com_weblinks/src/Model/CategoriesModel.php
@@ -112,7 +112,7 @@ public function getItems()
             $options['countItems'] = $params->get('show_cat_num_links', 1) || !$params->get('show_empty_categories_cat', 0);
             $categories            = Categories::getInstance('Weblinks', $options);
             $this->_parent         = $categories->get($this->getState('filter.parentId', 'root'));
-            if (is_object($this->_parent)) {
+            if (\is_object($this->_parent)) {
                 $this->_items = $this->_parent->getChildren();
             } else {
                 $this->_items = false;
@@ -129,7 +129,7 @@ public function getItems()
      */
     public function getParent()
     {
-        if (!is_object($this->_parent)) {
+        if (!\is_object($this->_parent)) {
             $this->getItems();
         }
 
diff --git a/src/components/com_weblinks/src/Model/CategoryModel.php b/src/components/com_weblinks/src/Model/CategoryModel.php
@@ -117,7 +117,7 @@ public function getItems()
         // Load tags of all items.
         if ($taggedItems) {
             $tagsHelper = new TagsHelper();
-            $itemIds    = \array_keys($taggedItems);
+            $itemIds    = array_keys($taggedItems);
 
             foreach ($tagsHelper->getMultipleItemTags('com_weblinks.weblink', $itemIds) as $id => $tags) {
                 $taggedItems[$id]->tags->itemTags = $tags;
@@ -262,15 +262,15 @@ protected function populateState($ordering = null, $direction = null)
 
         $orderCol = $app->input->get('filter_order', 'ordering');
 
-        if (!in_array($orderCol, $this->filter_fields)) {
+        if (!\in_array($orderCol, $this->filter_fields)) {
             $orderCol = 'ordering';
         }
 
         $this->setState('list.ordering', $orderCol);
 
         $listOrder = $app->input->get('filter_order_Dir', 'ASC');
 
-        if (!in_array(strtoupper($listOrder), ['ASC', 'DESC', ''])) {
+        if (!\in_array(strtoupper($listOrder), ['ASC', 'DESC', ''])) {
             $listOrder = 'ASC';
         }
 
@@ -301,7 +301,7 @@ protected function populateState($ordering = null, $direction = null)
      */
     public function getCategory()
     {
-        if (!is_object($this->_item)) {
+        if (!\is_object($this->_item)) {
             $params = $this->getState('params', new Registry());
 
             $options               = [];
@@ -311,7 +311,7 @@ public function getCategory()
             $categories  = Categories::getInstance('Weblinks', $options);
             $this->_item = $categories->get($this->getState('category.id', 'root'));
 
-            if (is_object($this->_item)) {
+            if (\is_object($this->_item)) {
                 $this->_children = $this->_item->getChildren();
                 $this->_parent   = false;
 
@@ -337,7 +337,7 @@ public function getCategory()
      */
     public function getParent()
     {
-        if (!is_object($this->_item)) {
+        if (!\is_object($this->_item)) {
             $this->getCategory();
         }
 
@@ -351,7 +351,7 @@ public function getParent()
      */
     public function &getLeftSibling()
     {
-        if (!is_object($this->_item)) {
+        if (!\is_object($this->_item)) {
             $this->getCategory();
         }
 
@@ -365,7 +365,7 @@ public function &getLeftSibling()
      */
     public function &getRightSibling()
     {
-        if (!is_object($this->_item)) {
+        if (!\is_object($this->_item)) {
             $this->getCategory();
         }
 
@@ -379,7 +379,7 @@ public function &getRightSibling()
      */
     public function &getChildren()
     {
-        if (!is_object($this->_item)) {
+        if (!\is_object($this->_item)) {
             $this->getCategory();
         }
 
diff --git a/src/components/com_weblinks/src/Model/WeblinkModel.php b/src/components/com_weblinks/src/Model/WeblinkModel.php
@@ -169,7 +169,7 @@ public function getItem($pk = null)
                 } else {
                     // If no access filter is set, the layout takes some responsibility for display of limited information.
                     $groups = $user->getAuthorisedViewLevels();
-                    $data->params->set('access-view', in_array($data->access, $groups) && in_array($data->category_access, $groups));
+                    $data->params->set('access-view', \in_array($data->access, $groups) && \in_array($data->category_access, $groups));
                 }
 
                 $this->_item[$pk] = $data;
diff --git a/src/components/com_weblinks/src/View/Category/HtmlView.php b/src/components/com_weblinks/src/View/Category/HtmlView.php
@@ -75,7 +75,7 @@ protected function prepareDocument()
 
         if (
             $menu && $menu->component == 'com_weblinks' && isset($menu->query['view'])
-            && in_array($menu->query['view'], ['categories', 'category'])
+            && \in_array($menu->query['view'], ['categories', 'category'])
         ) {
             $id = $menu->query['id'];
         } else {
diff --git a/src/components/com_weblinks/src/View/Form/HtmlView.php b/src/components/com_weblinks/src/View/Form/HtmlView.php
@@ -80,7 +80,7 @@ public function display($tpl = null)
         $this->return_page = $this->get('ReturnPage');
 
         if (empty($this->item->id)) {
-            $authorised = $user->authorise('core.create', 'com_weblinks') || count($user->getAuthorisedCategories('com_weblinks', 'core.create'));
+            $authorised = $user->authorise('core.create', 'com_weblinks') || \count($user->getAuthorisedCategories('com_weblinks', 'core.create'));
         } else {
             $authorised = $user->authorise('core.edit', 'com_weblinks.category.' . $this->item->catid);
         }
@@ -101,7 +101,7 @@ public function display($tpl = null)
         }
 
         // Check for errors.
-        if (count($errors = $this->get('Errors'))) {
+        if (\count($errors = $this->get('Errors'))) {
             throw new GenericDataException(implode("\n", $errors), 500);
         }
 
diff --git a/src/plugins/editors-xtd/weblink/src/Extension/Weblink.php b/src/plugins/editors-xtd/weblink/src/Extension/Weblink.php
@@ -19,7 +19,6 @@
 use Joomla\CMS\Object\CMSObject;
 use Joomla\CMS\Plugin\CMSPlugin;
 use Joomla\CMS\Session\Session;
-use Joomla\Database\DatabaseAwareTrait;
 use Joomla\Database\DatabaseInterface;
 use Joomla\Event\DispatcherInterface;
 
diff --git a/src/plugins/search/weblinks/src/Extension/Weblinks.php b/src/plugins/search/weblinks/src/Extension/Weblinks.php
@@ -98,7 +98,7 @@ public function onContentSearch($text, $phrase = '', $ordering = '', $areas = nu
         $searchText = $text;
 
         if (
-            is_array($areas)
+            \is_array($areas)
             && !array_intersect($areas, array_keys($this->onContentSearchAreas()))
         ) {
             return [];
diff --git a/src/plugins/system/weblinks/src/Extension/Weblinks.php b/src/plugins/system/weblinks/src/Extension/Weblinks.php
@@ -96,7 +96,7 @@ public function onGetStats(Event $event)
 
         [$extension] = $event->getArguments();
 
-        if (!in_array($extension, $this->supportedExtensions)) {
+        if (!\in_array($extension, $this->supportedExtensions)) {
             return;
         }
 

Original file line number	Diff line number	Diff line change
`@@ -122,7 +122,7 @@ public function getContexts(): array`
`122`	`122`	`*`
`123`	`123`	`* @since 4.0.0`
`124`	`124`	`*/`
`125`		`- protected function getTableNameForSection(string $section = null)`
	`125`	`+ protected function getTableNameForSection(?string $section = null)`
`126`	`126`	`{`
`127`	`127`	`return ($section === 'category' ? 'categories' : 'weblinks');`
`128`	`128`	`}`
`@@ -136,7 +136,7 @@ protected function getTableNameForSection(string $section = null)`
`136`	`136`	`*`
`137`	`137`	`* @since 4.0.0`
`138`	`138`	`*/`
`139`		`- protected function getStateColumnForSection(string $section = null)`
	`139`	`+ protected function getStateColumnForSection(?string $section = null)`
`140`	`140`	`{`
`141`	`141`	`return 'state';`
`142`	`142`	`}`
Original file line number	Diff line number	Diff line change
`@@ -60,7 +60,7 @@ protected function getInput()`
`60`	`60`	`// Script to proxy the select modal function to the modal-fields.js file.`
`61`	`61`	`if ($allowSelect) {`
`62`	`62`	`static $scriptSelect = null;`
`63`		`- if (is_null($scriptSelect)) {`
	`63`	`+ if (\is_null($scriptSelect)) {`
`64`	`64`	`$scriptSelect = [];`
`65`	`65`	`}`
`66`	`66`
Original file line number	Diff line number	Diff line change
`@@ -37,7 +37,7 @@ class WeblinksModel extends ListModel`
`37`	`37`	`* @see JControllerLegacy`
`38`	`38`	`* @since 1.6`
`39`	`39`	`*/`
`40`		`- public function __construct($config = [], MVCFactoryInterface $factory = null)`
	`40`	`+ public function __construct($config = [], ?MVCFactoryInterface $factory = null)`
`41`	`41`	`{`
`42`	`42`	`if (empty($config['filter_fields'])) {`
`43`	`43`	`$config['filter_fields'] = [`
Original file line number	Diff line number	Diff line change
`@@ -88,7 +88,7 @@ public function display($tpl = null)`
`88`	`88`	`$this->activeFilters = $this->get('ActiveFilters');`
`89`	`89`
`90`	`90`	`// Check for errors.`
`91`		`- if (count($errors = $this->get('Errors'))) {`
	`91`	`+ if (\count($errors = $this->get('Errors'))) {`
`92`	`92`	`throw new GenericDataException(implode("\n", $errors), 500);`
`93`	`93`	`}`
`94`	`94`
Original file line number	Diff line number	Diff line change
`@@ -269,7 +269,7 @@ public function go()`
`269`	`269`
`270`	`270`	`// Check whether item access level allows access.`
`271`	`271`	`$groups = $this->app->getIdentity()->getAuthorisedViewLevels();`
`272`		`- if (!in_array($link->access, $groups)) {`
	`272`	`+ if (!\in_array($link->access, $groups)) {`
`273`	`273`	`throw new \Exception(Text::_('JERROR_ALERTNOAUTHOR'), 403);`
`274`	`274`	`}`
`275`	`275`
`@@ -284,7 +284,7 @@ public function go()`
`284`	`284`	`}`
`285`	`285`
`286`	`286`	`// Check whether item access level allows access.`
`287`		`- if (!in_array($category->access, $groups)) {`
	`287`	`+ if (!\in_array($category->access, $groups)) {`
`288`	`288`	`throw new \Exception(Text::_('JERROR_ALERTNOAUTHOR'), 403);`
`289`	`289`	`}`
`290`	`290`