Replace $app->input by $app->getInput() (#568)

Author: joomdonation

src/administrator/components/com_weblinks/src/Model/WeblinkModel.php

@@ -162,7 +162,7 @@ protected function loadFormData()
 
             // Prime some default values.
             if ($this->getState('weblink.id') == 0) {
-                $data->set('catid', $app->input->get('catid', $app->getUserState('com_weblinks.weblinks.filter.category_id'), 'int'));
+                $data->set('catid', $app->getInput()->get('catid', $app->getUserState('com_weblinks.weblinks.filter.category_id'), 'int'));
             }
         }
 

src/administrator/components/com_weblinks/src/Model/WeblinksModel.php

@@ -90,10 +90,10 @@ protected function populateState($ordering = 'a.title', $direction = 'asc')
     {
         $app = Factory::getApplication();
 
-        $forcedLanguage = $app->input->get('forcedLanguage', '', 'cmd');
+        $forcedLanguage = $app->getInput()->get('forcedLanguage', '', 'cmd');
 
         // Adjust the context to support modal layouts.
-        if ($layout = $app->input->get('layout')) {
+        if ($layout = $app->getInput()->get('layout')) {
             $this->context .= '.' . $layout;
         }
 

src/administrator/components/com_weblinks/src/View/Weblink/HtmlView.php

@@ -73,7 +73,7 @@ public function display($tpl = null)
         }
 
         // If we are forcing a language in modal (used for associations).
-        if ($this->getLayout() === 'modal' && $forcedLanguage = Factory::getApplication()->input->get('forcedLanguage', '', 'cmd')) {
+        if ($this->getLayout() === 'modal' && $forcedLanguage = Factory::getApplication()->getInput()->get('forcedLanguage', '', 'cmd')) {
             // Set the language field to the forcedLanguage and disable changing it.
             $this->form->setValue('language', null, $forcedLanguage);
             $this->form->setFieldAttribute('language', 'readonly', 'true');
@@ -100,7 +100,7 @@ public function display($tpl = null)
     protected function addToolbar()
     {
         $app = Factory::getApplication();
-        $app->input->set('hidemainmenu', true);
+        $app->getInput()->set('hidemainmenu', true);
 
         $user       = $this->getCurrentUser();
         $isNew      = ($this->item->id == 0);

src/administrator/components/com_weblinks/src/View/Weblinks/HtmlView.php

@@ -106,7 +106,7 @@ public function display($tpl = null)
         } else {
             // In article associations modal we need to remove language filter if forcing a language.
             // We also need to change the category filter to show show categories with All or the forced language.
-            if ($forcedLanguage = Factory::getApplication()->input->get('forcedLanguage', '', 'CMD')) {
+            if ($forcedLanguage = Factory::getApplication()->getInput()->get('forcedLanguage', '', 'CMD')) {
                 // If the language is forced we can't allow to select the language, so transform the language selector filter into an hidden field.
                 $languageXml = new \SimpleXMLElement('<field name="language" type="hidden" default="' . $forcedLanguage . '" />');
                 $this->filterForm->setField($languageXml, 'filter', true);

src/administrator/components/com_weblinks/tmpl/weblink/edit.php

@@ -20,7 +20,7 @@
 
 HTMLHelper::_('behavior.formvalidator');
 $app = Factory::getApplication();
-$input = $app->input;
+$input = $app->getInput();
 $assoc = Associations::isEnabled();
 // Fieldsets to not automatically render by /layouts/joomla/edit/params.php
 $this->ignore_fieldsets = array('details', 'images', 'item_associations', 'jmetadata');

src/administrator/components/com_weblinks/tmpl/weblink/modal.php

@@ -18,7 +18,7 @@
 
 HTMLHelper::_('bootstrap.tooltip', '.hasTooltip', array('placement' => 'bottom'));
 // @deprecated 4.0 the function parameter, the inline js and the buttons are not needed since 3.7.0.
-$function  = Factory::getApplication()->input->getCmd('function', 'jEditWeblink_' . (int) $this->item->id);
+$function  = Factory::getApplication()->getInput()->getCmd('function', 'jEditWeblink_' . (int) $this->item->id);
 // Function to update input title when changed
 $this->getDocument()->addScriptDeclaration('
 	function jEditWeblinkModal() {

src/administrator/components/com_weblinks/tmpl/weblinks/modal.php

@@ -28,8 +28,8 @@
 HTMLHelper::_('behavior.multiselect');
 $this->document->getWebAssetManager()
     ->registerAndUseScript('com_weblinks.admin-weblinks-modal', 'media/com_weblinks/js/admin-weblinks-modal.js', [], ['defer' => true], ['core']);
-$function  = $app->input->getCmd('function', 'jSelectWeblink');
-$editor    = $app->input->getCmd('editor', '');
+$function  = $app->getInput()->getCmd('function', 'jSelectWeblink');
+$editor    = $app->getInput()->getCmd('editor', '');
 $listOrder = $this->escape($this->state->get('list.ordering'));
 $listDirn  = $this->escape($this->state->get('list.direction'));
 $onclick   = $this->escape($function);
@@ -160,7 +160,7 @@
 
       <input type="hidden" name="task" value="" />
        <input type="hidden" name="boxchecked" value="0" />
-        <input type="hidden" name="forcedLanguage" value="<?php echo $app->input->get('forcedLanguage', '', 'CMD'); ?>" />
+        <input type="hidden" name="forcedLanguage" value="<?php echo $app->getInput()->get('forcedLanguage', '', 'CMD'); ?>" />
         <?php echo HTMLHelper::_('form.token'); ?>
 
  </form>

src/components/com_weblinks/src/Helper/AssociationHelper.php

@@ -36,7 +36,7 @@ abstract class AssociationHelper extends CategoryAssociationHelper
      */
     public static function getAssociations($id = 0, $view = null)
     {
-        $input = Factory::getApplication()->input;
+        $input = Factory::getApplication()->getInput();
         $view  = \is_null($view) ? $input->get('view') : $view;
         $id    = empty($id) ? $input->getInt('id') : $id;
         if ($view === 'weblink') {

src/components/com_weblinks/src/Model/CategoriesModel.php

@@ -73,7 +73,7 @@ protected function populateState($ordering = null, $direction = null)
         $app = Factory::getApplication();
         $this->setState('filter.extension', $this->_extension);
         // Get the parent id if defined.
-        $parentId = $app->input->getInt('id');
+        $parentId = $app->getInput()->getInt('id');
         $this->setState('filter.parentId', $parentId);
         $params = $app->getParams();
         $this->setState('params', $params);

src/components/com_weblinks/src/Model/CategoryModel.php

@@ -254,29 +254,29 @@ protected function populateState($ordering = null, $direction = null)
         $limit = $app->getUserStateFromRequest('global.list.limit', 'limit', $app->get('list_limit'), 'uint');
         $this->setState('list.limit', $limit);
 
-        $limitstart = $app->input->get('limitstart', 0, 'uint');
+        $limitstart = $app->getInput()->get('limitstart', 0, 'uint');
         $this->setState('list.start', $limitstart);
 
         // Optional filter text
-        $this->setState('list.filter', $app->input->getString('filter-search'));
+        $this->setState('list.filter', $app->getInput()->getString('filter-search'));
 
-        $orderCol = $app->input->get('filter_order', 'ordering');
+        $orderCol = $app->getInput()->get('filter_order', 'ordering');
 
         if (!\in_array($orderCol, $this->filter_fields)) {
             $orderCol = 'ordering';
         }
 
         $this->setState('list.ordering', $orderCol);
 
-        $listOrder = $app->input->get('filter_order_Dir', 'ASC');
+        $listOrder = $app->getInput()->get('filter_order_Dir', 'ASC');
 
         if (!\in_array(strtoupper($listOrder), ['ASC', 'DESC', ''])) {
             $listOrder = 'ASC';
         }
 
         $this->setState('list.direction', $listOrder);
 
-        $id = $app->input->get('id', 0, 'int');
+        $id = $app->getInput()->get('id', 0, 'int');
         $this->setState('category.id', $id);
 
         $user = $this->getCurrentUser();
@@ -397,7 +397,7 @@ public function &getChildren()
      */
     public function hit($pk = 0)
     {
-        $hitcount = Factory::getApplication()->input->getInt('hitcount', 1);
+        $hitcount = Factory::getApplication()->getInput()->getInt('hitcount', 1);
 
         if ($hitcount) {
             $pk    = (!empty($pk)) ? $pk : (int) $this->getState('category.id');