Merge pull request #576 from mahmoudmagdy1-1/component_rel

Add follow/nofollow attribute control for web links plus test

Author: alikon

jorobo.dist.ini

@@ -4,7 +4,7 @@ source = src
 target = package
 
 ; Create a pre-release of the extension on GitHub
-; Add your personal GitHub access tocken
+; Add your personal GitHub access token
 ; and add Release to the target (separated by space) above
 [github]
 remote = origin

src/administrator/components/com_weblinks/forms/weblink.xml

@@ -234,6 +234,16 @@
 			name="jbasic"
 			label="COM_WEBLINKS_FIELDSET_OPTIONS"
 			>
+			<field 
+				name="follow"
+				type="list"
+				label="COM_WEBLINKS_FIELD_FOLLOW_LABEL"
+				default="nofollow"
+				>
+				<option value="follow">COM_WEBLINKS_FIELD_VALUE_FOLLOW</option>
+				<option value="nofollow">COM_WEBLINKS_FIELD_VALUE_NOFOLLOW</option>
+			</field>
+			
 			<field
 				name="target"
 				type="list"

src/administrator/language/en-GB/com_weblinks.ini

@@ -48,6 +48,9 @@ COM_WEBLINKS_FIELD_SHOW_CAT_TAGS_LABEL="Category Tags"
 COM_WEBLINKS_FIELD_SHOW_TAGS_LABEL="Tags"
 COM_WEBLINKS_FIELD_TARGET_DESC="Target browser window when the link is selected."
 COM_WEBLINKS_FIELD_TARGET_LABEL="Target"
+COM_WEBLINKS_FIELD_FOLLOW_LABEL="Follow/No Follow"
+COM_WEBLINKS_FIELD_VALUE_FOLLOW="Follow"
+COM_WEBLINKS_FIELD_VALUE_NOFOLLOW="No Follow"
 COM_WEBLINKS_FIELD_URL_LABEL="URL"
 COM_WEBLINKS_FIELD_VALUE_REPORTED="Reported"
 COM_WEBLINKS_FIELD_VERSION_LABEL="Revision"

src/components/com_weblinks/tmpl/category/default_items.php

@@ -129,8 +129,9 @@
                         switch ($item->params->get('target', $this->params->get('target'))) {
                             case 1:
                                 // Open in a new window
-                                echo '<a href="' . $link . '" target="_blank" class="' . $menuclass . '" rel="nofollow">' .
-                                    $this->escape($item->title) . '</a>';
+                                echo '<a href="' . $link . '" target="_blank" class="' . $menuclass . '"
+                                rel="'  . $item->params->get('follow', 'nofollow') . '">'
+                                . $this->escape($item->title) . '</a>';
 
                                 break;
                             case 2:
@@ -157,8 +158,9 @@
                                 break;
                             default:
                                 // Open in parent window
-                                echo '<a href="' . $link . '" class="' . $menuclass . '" rel="nofollow">' .
-                                    $this->escape($item->title) . ' </a>';
+                                echo '<a href="' . $link . '" target="_blank" class="' . $menuclass . '"
+                                rel="'  . $item->params->get('follow', 'nofollow') . '">'
+                                . $this->escape($item->title) . '</a>';
 
                                 break;
                         }

src/components/com_weblinks/tmpl/weblink/default.php

@@ -51,7 +51,7 @@
 
     <div itemprop="articleBody">
        <div class="p-3">
-            <a href="<?php echo $weblinkUrl; ?>" target="_blank" itemprop="url">
+            <a href="<?php echo $weblinkUrl; ?>" target="_blank" rel="<?php echo $this->params->get('follow', 'nofollow'); ?>" itemprop="url">
                 <?php echo $weblinkUrl; ?>
           </a>
        </div>

tests/cypress/integration/site/components/com_weblinks/Weblinks.cy.js

@@ -97,5 +97,36 @@ describe('Test in frontend that the weblinks', () => {
         });
       });
   });
+    it('should show correct rel attribute for follow', () => {
+        // Set follow parameter to 'follow'
+        cy.db_updateExtensionParameter('follow', 'follow', 'com_weblinks');
+        // Create test weblink with title and URL
+        cy.db_createWeblink({
+            title: 'Follow Test',
+            url: 'https://follow.example',
+        }).then((weblink) => {
+            // Visit weblink category page
+            cy.visit(`/index.php?option=com_weblinks&view=category&id=${weblink.catid}`);
+            // Verify rel attribute is 'follow'
+            cy.contains('a', 'Follow Test')
+                .should('have.attr', 'rel', 'follow');
+        });
+    });
+
+    it('should show correct rel attribute for nofollow', () => {
+        // Set follow parameter to 'nofollow'
+        cy.db_updateExtensionParameter('follow', 'nofollow', 'com_weblinks');
+        // Create test weblink with title and URL
+        cy.db_createWeblink({
+            title: 'Nofollow Test',
+            url: 'https://nofollow.example',
+        }).then((weblink) => {
+            // Visit weblink category page
+            cy.visit(`/index.php?option=com_weblinks&view=category&id=${weblink.catid}`);
+            // Verify rel attribute is 'nofollow'
+            cy.contains('a', 'Nofollow Test')
+                .should('have.attr', 'rel', 'nofollow');
+        });
+    });
 });