Improve component installer script (#570)

* Improve component installer script

* Remove un-used import

* Toolbar is not available in document in Joomla 4.

Author: joomdonation

src/administrator/components/com_weblinks/script.php

@@ -16,7 +16,8 @@
 use Joomla\CMS\Installer\InstallerAdapter;
 use Joomla\CMS\Language\Text;
 use Joomla\CMS\Table\Category;
-use Joomla\Database\DatabaseInterface;
+use Joomla\Database\DatabaseAwareInterface;
+use Joomla\Database\DatabaseAwareTrait;
 use Joomla\Filesystem\File;
 use Joomla\Filesystem\Folder;
 
@@ -25,8 +26,10 @@
  *
  * @since  3.4
  */
-class Com_WeblinksInstallerScript
+class Com_WeblinksInstallerScript implements DatabaseAwareInterface
 {
+    use DatabaseAwareTrait;
+
     /**
      * Function called before extension installation/update/removal procedure commences
      *
@@ -87,7 +90,7 @@ public function preflight($type, $parent)
     public function install($parent)
     {
         // Initialize a new category
-        $category = new Category(Factory::getContainer()->get(DatabaseInterface::class));
+        $category = new Category($this->getDatabase());
 
         // Check if the Uncategorised category exists before adding it
         if (!$category->load(['extension' => 'com_weblinks', 'title' => 'Uncategorised'])) {
@@ -142,7 +145,7 @@ public function install($parent)
     public function postflight($type, $parent)
     {
         // Only execute database changes on MySQL databases
-        $dbName = Factory::getContainer()->get(DatabaseInterface::class)->name;
+        $dbName = $this->getDatabase()->name;
 
         if (strpos($dbName, 'mysql') !== false) {
             // Add Missing Table Columns if needed
@@ -166,7 +169,7 @@ public function postflight($type, $parent)
     private function insertMissingUcmRecords()
     {
         // Insert the rows in the #__content_types table if they don't exist already
-        $db = Factory::getContainer()->get(DatabaseInterface::class);
+        $db = $this->getDatabase();
 
         // Get the type ID for a Weblink
         $query = $db->getQuery(true);
@@ -288,7 +291,7 @@ private function dropColumnsIfNeeded()
             'approved',
         ];
 
-        $db    = Factory::getContainer()->get(DatabaseInterface::class);
+        $db    = $this->getDatabase();
         $table = $db->getTableColumns('#__weblinks');
 
         $columns = array_intersect($oldColumns, array_keys($table));
@@ -309,7 +312,7 @@ private function dropColumnsIfNeeded()
      */
     private function addColumnsIfNeeded()
     {
-        $db    = Factory::getContainer()->get(DatabaseInterface::class);
+        $db    = $this->getDatabase();
         $table = $db->getTableColumns('#__weblinks');
 
         if (!\array_key_exists('version', $table)) {

src/administrator/components/com_weblinks/src/View/Weblinks/HtmlView.php

@@ -20,6 +20,7 @@
 use Joomla\CMS\Language\Text;
 use Joomla\CMS\MVC\View\GenericDataException;
 use Joomla\CMS\MVC\View\HtmlView as BaseHtmlView;
+use Joomla\CMS\Toolbar\Toolbar;
 use Joomla\CMS\Toolbar\ToolbarHelper;
 use Joomla\Component\Weblinks\Administrator\Model\WeblinksModel;
 
@@ -135,7 +136,7 @@ protected function addToolbar()
         $user  = $this->getCurrentUser();
 
         // Get the toolbar object instance
-        $toolbar = $this->getDocument()->getToolbar();
+        $toolbar = Toolbar::getInstance('toolbar');
 
         ToolbarHelper::title(Text::_('COM_WEBLINKS_MANAGER_WEBLINKS'), 'link weblinks');
 

src/administrator/manifests/packages/weblinks/script.php

@@ -28,7 +28,7 @@ class Pkg_WeblinksInstallerScript extends InstallerScript
      */
     public function __construct()
     {
-        $this->minimumJoomla = '4.3.0';
+        $this->minimumJoomla = '4.4.0';
         $this->minimumPhp    = JOOMLA_MINIMUM_PHP;
     }
 }