types

Author: rdeutz

app/Http/Controllers/Api/V1/SiteController.php

@@ -32,7 +32,7 @@ public function register(Request $request): JsonResponse
         $url = $request->string('url');
         $key = $request->string('key');
 
-        if ($url === '' && $key === '') {
+        if ($url->isEmpty() && $key->isEmpty()) {
             return $this->error('BadRequest');
         }
 
@@ -67,8 +67,6 @@ public function register(Request $request): JsonResponse
      */
     public function check(Request $request): JsonResponse
     {
-
-
         return response()->json(['check']);
     }
 

app/Traits/ApiResponse.php

@@ -10,44 +10,44 @@
 trait ApiResponse
 {
     /**
-     * @param $message
+     * @param string $message
      *
      * @return JsonResponse
      */
-    protected function ok($message = 'OK'): JsonResponse
+    protected function ok(string $message = 'OK'): JsonResponse
     {
         return $this->success($message, 200);
     }
 
     /**
-     * @param $message
-     * @param $statusCode
+     * @param string $message
+     * @param int    $statusCode
      *
      * @return JsonResponse
      */
-    protected function success($message, $statusCode = 200): JsonResponse
+    protected function success(string $message, int $statusCode = 200): JsonResponse
     {
         return $this->response($message, $statusCode);
     }
 
     /**
-     * @param $message
-     * @param $statusCode
+     * @param string $message
+     * @param int    $statusCode
      *
      * @return JsonResponse
      */
-    protected function error($message, $statusCode = 400): JsonResponse
+    protected function error(string $message, int $statusCode = 400): JsonResponse
     {
         return $this->response($message, $statusCode);
     }
 
     /**
-     * @param $message
-     * @param $statusCode
+     * @param string $message
+     * @param int    $statusCode
      *
      * @return JsonResponse
      */
-    protected function response($message, $statusCode = 200): JsonResponse
+    protected function response(string $message, int $statusCode = 200): JsonResponse
     {
         return response()->json([
             'message' => $message,