cs fixes

Author: SniperSister

app/Console/Commands/PerformSiteHealthCheck.php

@@ -27,9 +27,10 @@ class PerformSiteHealthCheck extends Command
      */
     public function handle(): int
     {
-        CheckSiteHealth::dispatchSync(
-            Site::findOrFail($this->input->getArgument('siteId'))
-        );
+        /** @var Site $site */
+        $site = Site::findOrFail($this->input->getArgument('siteId'));
+
+        CheckSiteHealth::dispatchSync($site);
 
         return Command::SUCCESS;
     }

app/Console/Commands/QueueHealthChecks.php

@@ -34,7 +34,11 @@ public function handle(): int
         $this->output->writeln('Pushing pending health checks');
 
         Site::query()
-            ->whereDate('last_seen', '<', Carbon::now()->subHours(env('HEALTH_CHECK_INTERVAL', 24)))
+            ->whereDate(
+                'last_seen',
+                '<',
+                Carbon::now()->subHours((int) config('autoupdates.healthcheck_interval')) // @phpstan-ignore-line
+            )
             ->chunkById(
                 100,
                 function (Collection $chunk) {
@@ -44,7 +48,7 @@ function (Collection $chunk) {
                     $this->totalPushed += $chunk->count();
 
                     // Push each site check to queue
-                    $chunk->each(fn($site) => CheckSiteHealth::dispatch($site));
+                    $chunk->each(fn ($site) => CheckSiteHealth::dispatch($site));
                 }
             );
 

app/Jobs/CheckSiteHealth.php

@@ -44,6 +44,7 @@ public function handle(): void
             ])->toArray()
         );
 
+        // @phpstan-ignore-next-line
         $this->site->last_seen = Carbon::now();
         $this->site->save();
     }

app/Services/SiteConnectionService.php

@@ -95,12 +95,23 @@ protected function performHttpRequest(
             );
         }
 
-        // Return decoded body
-        return json_decode(
+        // Decode body
+        $return = json_decode(
             (string) $response->getBody(),
             true,
             512,
             JSON_THROW_ON_ERROR
         );
+
+        // Make sure it's an array
+        if (!is_array($return)) {
+            throw new RequestException(
+                "Invalid JSON body",
+                $request,
+                $response
+            );
+        }
+
+        return $return;
     }
 }

config/app.php

@@ -121,6 +121,5 @@
     'maintenance' => [
         'driver' => env('APP_MAINTENANCE_DRIVER', 'file'),
         'store' => env('APP_MAINTENANCE_STORE', 'database'),
-    ],
-
+    ]
 ];

config/autoupdates.php

@@ -0,0 +1,5 @@
+<?php
+
+return [
+    'healthcheck_interval' => env('HEALTH_CHECK_INTERVAL', 24)
+];

phpstan.neon.dist

@@ -7,5 +7,8 @@ parameters:
     paths:
         - app/
 
-    # Level 9 is the highest level
-    level: 5
+    level: 9
+
+    ignoreErrors:
+        - '#Method .* return type has no value type specified in iterable type array.#'
+        - '#Method .* has parameter .* with no value type specified in iterable type array.#'