fix tests

Author: SniperSister

app/Jobs/CheckSiteHealth.php

@@ -43,7 +43,6 @@ public function handle(): void
         $this->site->save();
 
         // Check if conditions are met
-        // @phpstan-ignore-next-line
         if (!$this->site->update_requirement_state) {
             return;
         }

app/RemoteSite/Responses/HealthCheck.php

@@ -12,7 +12,7 @@ public function __construct(
         public string $db_version,
         public string $cms_version,
         public string $server_os,
-        public bool $update_requirement_state
+        public ?bool $update_requirement_state = null
     ) {
     }
 }

database/migrations/2025_05_18_143851_add_update_requirement_state_to_sites_table.php

@@ -4,8 +4,7 @@
 use Illuminate\Database\Schema\Blueprint;
 use Illuminate\Support\Facades\Schema;
 
-return new class extends Migration
-{
+return new class extends Migration {
     /**
      * Run the migrations.
      */

tests/Unit/Jobs/UpdateSiteTest.php

@@ -59,6 +59,28 @@ public function testJobQuitsIfNoUpdateIsAvailable()
         $this->assertTrue(true);
     }
 
+    public function testJobQuitsIfRequirementsArentMet()
+    {
+        $site = $this->getSiteMock(
+            [
+                'checkHealth' => $this->getHealthCheckMock(['update_requirement_state' => false])
+            ]
+        );
+
+        Log::spy();
+
+        $object = new UpdateSite($site, "1.0.1");
+        $object->handle();
+
+        Log::shouldHaveReceived('info')
+            ->once()
+            ->withArgs(function ($message) {
+                return str_contains($message, 'Site does not meet requirements, abort');
+            });
+
+        $this->assertTrue(true);
+    }
+
     public function testJobQuitsIfWeDetectALoopForAVersion()
     {
         $site = $this->getSiteMock([], null, 6);
@@ -241,7 +263,8 @@ protected function getHealthCheckMock($overrides = [])
             "db_type" => "mysqli",
             "db_version" => "1.0.0",
             "cms_version" => "1.0.0",
-            "server_os" => "Joomla OS 1.0.0"
+            "server_os" => "Joomla OS 1.0.0",
+            "update_requirement_state" => true
         ];
 
         return HealthCheck::from([