add loop detection

#25

Author: rdeutz

app/Console/Commands/PerformUpdate.php

@@ -6,6 +6,7 @@
 use App\Models\Site;
 use Illuminate\Console\Command;
 use App\Console\Traits\RequestTargetVersion;
+use Illuminate\Support\Facades\Log;
 
 class PerformUpdate extends Command
 {
@@ -35,6 +36,14 @@ public function handle(): int
         /** @var Site $site */
         $site = Site::findOrFail($this->input->getArgument('siteId'));
 
+        $updateCount = $site->updates()->where('new_version', $targetVersion)->count();
+
+        if ($updateCount >= config('autoupdates.max_update_tries')) {
+            Log::info("Update Loop detected for Site: " . $site->id . '; TargetVersion: ' . $targetVersion);
+
+            return Command::SUCCESS;
+        }
+
         UpdateSite::dispatchSync(
             $site,
             $targetVersion

config/autoupdates.php

@@ -4,4 +4,5 @@
     'healthcheck_interval' => env('HEALTH_CHECK_INTERVAL', 24),
     'cleanup_site_delay' => env('CLEANUP_SITE_DELAY', 7),
     'tuf_repo_cachetime' => env('TUF_REPO_CACHETIME', 5),
+    'max_update_tries' => env('MAX_UPDATE_TRIES', 5),
 ];