Merge pull request #61 from joomla-projects/feature/ignore-specific-postprocess-errors

Ignore specific finalizeition errors to reduce noise for logs and users

Author: HLeithner

app/Jobs/UpdateSite.php

@@ -142,7 +142,7 @@ public function handle(): void
         // Run the postupdate steps
         $postUpdateResult = $connection->finalizeUpdate(["fromVersion" => $healthResult->cms_version]);
 
-        if (!$postUpdateResult->success) {
+        if (!$postUpdateResult->success && !$postUpdateResult->hasIgnorableError()) {
             throw new UpdateException(
                 "finalize",
                 "Update for site failed in postprocessing: " . $this->site->id . ", errors: " . json_encode($postUpdateResult->errors),

app/RemoteSite/Responses/FinalizeUpdate.php

@@ -11,4 +11,23 @@ public function __construct(
         public ?array $errors = null,
     ) {
     }
+
+    public function hasIgnorableError(): bool
+    {
+        if (is_null($this->errors)) {
+            return false;
+        }
+
+        $errorString = (string) json_encode($this->errors);
+
+        if (str_contains($errorString, 'Undefined constant') && str_contains($errorString, 'T4PATH_MEDIA')) {
+            return true;
+        }
+
+        if (str_contains($errorString, 'Error on updating manifest cache') && str_contains($errorString, 'T4PATH_MEDIA')) {
+            return true;
+        }
+
+        return false;
+    }
 }