Skip to content

Commit 9b2602a

Browse files
committed
Recompile assets for release
1 parent 512a992 commit 9b2602a

File tree

10 files changed

+44
-104
lines changed

10 files changed

+44
-104
lines changed

dist/js/joomla-alert.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,7 @@
9797
this.addEventListener('transitionend', () => {
9898
this.dispatchCustomEvent('joomla.alert.closed');
9999
if (element) {
100-
element.parentNode.removeChild(element)
100+
element.parentNode.removeChild(element);
101101
} else {
102102
this.remove();
103103
}
@@ -181,7 +181,7 @@
181181
const button = this.querySelector('button');
182182
if (button) {
183183
button.removeEventListener('click', this);
184-
button.parentNode.removeChild(button)
184+
button.parentNode.removeChild(button);
185185
}
186186
}
187187

dist/js/joomla-tab-es5.js

Lines changed: 9 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -227,7 +227,7 @@ function _getPrototypeOf(o) {
227227
return;
228228
}
229229

230-
if (this.findAncestor(this, 'joomla-tab')) {
230+
if (this.parentNode.closest('joomla-tab')) {
231231
this.isNested = true;
232232
}
233233

@@ -259,11 +259,10 @@ function _getPrototypeOf(o) {
259259
var element = this.querySelector("#".concat(hash)); // Add the parent tab to the array for activation
260260

261261
if (element) {
262-
var currentTabSet = this.findAncestor(element, 'joomla-tab');
263-
var parentTabSet = this.findAncestor(currentTabSet, 'joomla-tab');
262+
var currentTabSet = element.closest('joomla-tab');
264263

265-
if (parentTabSet) {
266-
var parentTab = this.findAncestor(currentTabSet, 'section');
264+
if (this.isNested) {
265+
var parentTab = currentTabSet.closest('section');
267266

268267
if (parentTab) {
269268
tabLinkHash.push("#tab-".concat(parentTab.id));
@@ -344,15 +343,14 @@ function _getPrototypeOf(o) {
344343

345344
if (_element) {
346345
// Activate any parent tabs (nested tables)
347-
var _currentTabSet = this.findAncestor(_element, 'joomla-tab');
346+
var _currentTabSet = _element.closest('joomla-tab');
348347

349-
var _parentTabSet = this.findAncestor(_currentTabSet, 'joomla-tab');
348+
if (this.isNested) {
349+
var parentTabSet = _currentTabSet.closest('joomla-tab');
350350

351-
if (_parentTabSet) {
352-
var _parentTab = this.findAncestor(_currentTabSet, 'section');
353-
354-
_parentTabSet.showTab(_parentTab); // Now activate the given tab
351+
var _parentTab = _currentTabSet.closest('section');
355352

353+
parentTabSet.showTab(_parentTab); // Now activate the given tab
356354

357355
this.show(_element);
358356
} else {
@@ -597,22 +595,6 @@ function _getPrototypeOf(o) {
597595
}
598596
}
599597
}
600-
}, {
601-
key: "findAncestor",
602-
value: function findAncestor(el, tagName) {
603-
var element = el;
604-
605-
while (element.nodeName.toLowerCase() !== tagName) {
606-
// Ensure we haven't reached the top of the dom tree
607-
if (element.parentElement === null) {
608-
return false;
609-
}
610-
611-
element = element.parentElement;
612-
}
613-
614-
return element;
615-
}
616598
/* Method to dispatch events */
617599

618600
}, {

dist/js/joomla-tab-es5.min.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/js/joomla-tab.js

Lines changed: 9 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@
4141
return;
4242
}
4343

44-
if (this.findAncestor(this, 'joomla-tab')) {
44+
if (this.parentNode.closest('joomla-tab')) {
4545
this.isNested = true;
4646
}
4747

@@ -72,11 +72,11 @@
7272

7373
// Add the parent tab to the array for activation
7474
if (element) {
75-
const currentTabSet = this.findAncestor(element, 'joomla-tab');
76-
const parentTabSet = this.findAncestor(currentTabSet, 'joomla-tab');
75+
const currentTabSet = element.closest('joomla-tab');
76+
77+
if (this.isNested) {
78+
const parentTab = currentTabSet.closest('section');
7779

78-
if (parentTabSet) {
79-
const parentTab = this.findAncestor(currentTabSet, 'section');
8080
if (parentTab) {
8181
tabLinkHash.push(`#tab-${parentTab.id}`);
8282
}
@@ -151,11 +151,11 @@
151151

152152
if (element) {
153153
// Activate any parent tabs (nested tables)
154-
const currentTabSet = this.findAncestor(element, 'joomla-tab');
155-
const parentTabSet = this.findAncestor(currentTabSet, 'joomla-tab');
154+
const currentTabSet = element.closest('joomla-tab');
156155

157-
if (parentTabSet) {
158-
const parentTab = this.findAncestor(currentTabSet, 'section');
156+
if (this.isNested) {
157+
const parentTabSet = currentTabSet.closest('joomla-tab');
158+
const parentTab = currentTabSet.closest('section');
159159
parentTabSet.showTab(parentTab);
160160
// Now activate the given tab
161161
this.show(element);
@@ -383,18 +383,6 @@
383383
}
384384
}
385385

386-
findAncestor(el, tagName) {
387-
let element = el;
388-
while (element.nodeName.toLowerCase() !== tagName) {
389-
// Ensure we haven't reached the top of the dom tree
390-
if (element.parentElement === null) {
391-
return false;
392-
}
393-
element = element.parentElement;
394-
}
395-
return element;
396-
}
397-
398386
/* Method to dispatch events */
399387
dispatchCustomEvent(eventName, element, related) {
400388
const OriginalCustomEvent = new CustomEvent(eventName, { bubbles: true, cancelable: true });

dist/js/joomla-tab.min.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

docs/_media/js/joomla-alert.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,7 @@
9797
this.addEventListener('transitionend', () => {
9898
this.dispatchCustomEvent('joomla.alert.closed');
9999
if (element) {
100-
element.parentNode.removeChild(element)
100+
element.parentNode.removeChild(element);
101101
} else {
102102
this.remove();
103103
}
@@ -181,7 +181,7 @@
181181
const button = this.querySelector('button');
182182
if (button) {
183183
button.removeEventListener('click', this);
184-
button.parentNode.removeChild(button)
184+
button.parentNode.removeChild(button);
185185
}
186186
}
187187

0 commit comments

Comments
 (0)