Skip to content

Commit 2897829

Browse files
committed
code quality increased in js
1 parent 80cc021 commit 2897829

File tree

3 files changed

+43
-33
lines changed

3 files changed

+43
-33
lines changed

administrator/components/com_workflow/layouts/toolbar/redo.php

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,14 @@
1818

1919
?>
2020
<joomla-toolbar-button>
21-
<button class="btn btn-info action-button" onclick="WorkflowGraph.Event.fire('onClickRedoWorkflow');" tabindex="0">
21+
<button id="redo-workflow" class="btn btn-info action-button" tabindex="0">
2222
<span class="icon-redo icon-fw" aria-hidden="true"></span>
2323
<?php echo Text::_('COM_WORKFLOW_REDO'); ?>
2424
</button>
2525
</joomla-toolbar-button>
26+
27+
<script>
28+
document.getElementById('redo-workflow')?.addEventListener('click', () => {
29+
WorkflowGraph.Event.fire('onClickRedoWorkflow');
30+
});
31+
</script>

administrator/components/com_workflow/layouts/toolbar/undo.php

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,16 @@
1818

1919
?>
2020
<joomla-toolbar-button>
21-
<button class="btn btn-info action-button" onclick="WorkflowGraph.Event.fire('onClickUndoWorkflow');" tabindex="0">
21+
<button id="undo-workflow" class="btn btn-info action-button" tabindex="0">
2222
<span class="icon-undo-2 icon-fw" aria-hidden="true"></span>
2323
<?php echo Text::_('COM_WORKFLOW_UNDO'); ?>
2424
</button>
2525
</joomla-toolbar-button>
26+
27+
28+
<script>
29+
document.getElementById('undo-workflow')?.addEventListener('click', () => {
30+
WorkflowGraph.Event.fire('onClickUndoWorkflow');
31+
});
32+
</script>
33+

administrator/components/com_workflow/resources/scripts/components/Titlebar.vue

Lines changed: 27 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -11,37 +11,33 @@
1111
class="d-flex align-items-center flex-wrap mb-0"
1212
aria-label="workflow details"
1313
>
14-
<div class="me-3 mb-1 d-flex">
15-
<dt class="visually-hidden">
16-
{{ sprintf('COM_WORKFLOW_GRAPH_STATUS', workflow.published ? 'COM_WORKFLOW_GRAPH_ENABLED' : 'COM_WORKFLOW_GRAPH_DISABLED') }}
17-
</dt>
18-
<dd>
19-
<span
20-
class="badge"
21-
:class="workflow.published ? 'bg-success' : 'bg-warning'"
22-
role="status"
23-
>
24-
{{ workflow.published ? translate('COM_WORKFLOW_GRAPH_ENABLED') : translate('COM_WORKFLOW_GRAPH_DISABLED') }}
25-
</span>
26-
</dd>
27-
</div>
28-
<div class="me-3 mb-1 d-flex">
29-
<dt class="visually-hidden">
30-
{{ sprintf('COM_WORKFLOW_GRAPH_STAGE_COUNT', stagesCount) }}
31-
</dt>
32-
<dd>
33-
{{ stagesCount }} {{ stagesCount === 1 ? translate('COM_WORKFLOW_GRAPH_STAGE') : translate('COM_WORKFLOW_GRAPH_STAGES') }}
34-
</dd>
35-
</div>
36-
<div class="me-3 mb-1 d-flex">
37-
<dt class="visually-hidden">
38-
{{ sprintf('COM_WORKFLOW_GRAPH_TRANSITION_COUNT', transitionsCount) }}
39-
</dt>
40-
<dd>
41-
{{ transitionsCount }} {{ transitionsCount === 1 ? translate('COM_WORKFLOW_GRAPH_TRANSITION') :
42-
translate('COM_WORKFLOW_GRAPH_TRANSITIONS') }}
43-
</dd>
44-
</div>
14+
<dt class="visually-hidden">
15+
{{ sprintf('COM_WORKFLOW_GRAPH_STATUS', workflow.published ? 'COM_WORKFLOW_GRAPH_ENABLED' : 'COM_WORKFLOW_GRAPH_DISABLED') }}
16+
</dt>
17+
<dd class="me-3 mb-1 d-flex">
18+
<span
19+
class="badge"
20+
:class="workflow.published ? 'bg-success' : 'bg-warning'"
21+
role="status"
22+
>
23+
{{ workflow.published ? translate('COM_WORKFLOW_GRAPH_ENABLED') : translate('COM_WORKFLOW_GRAPH_DISABLED') }}
24+
</span>
25+
</dd>
26+
27+
<dt class="visually-hidden">
28+
{{ sprintf('COM_WORKFLOW_GRAPH_STAGE_COUNT', stagesCount) }}
29+
</dt>
30+
<dd class="me-3 mb-1 d-flex">
31+
{{ stagesCount }} {{ stagesCount === 1 ? translate('COM_WORKFLOW_GRAPH_STAGE') : translate('COM_WORKFLOW_GRAPH_STAGES') }}
32+
</dd>
33+
34+
<dt class="visually-hidden">
35+
{{ sprintf('COM_WORKFLOW_GRAPH_TRANSITION_COUNT', transitionsCount) }}
36+
</dt>
37+
<dd class="me-3 mb-1 d-flex">
38+
{{ transitionsCount }} {{ transitionsCount === 1 ? translate('COM_WORKFLOW_GRAPH_TRANSITION')
39+
: translate('COM_WORKFLOW_GRAPH_TRANSITIONS') }}
40+
</dd>
4541
</dl>
4642
</div>
4743
<div

0 commit comments

Comments
 (0)