fix : used the component helper to get the article and category

Author: shahzan01

plugins/system/opengraph/src/Extension/opengraph.php

@@ -23,10 +23,16 @@
 use Joomla\CMS\Opengraph\OpengraphServiceInterface;
 use Joomla\CMS\Uri\Uri;
 use Exception;
+use Joomla\CMS\Component\ComponentHelper;
 use Joomla\CMS\Table\Content;
 use Joomla\Database\DatabaseInterface;
 use Joomla\CMS\Menu\MenuItem;
 use Joomla\Component\Fields\Administrator\Helper\FieldsHelper;
+use Joomla\Component\Content\Site\Model\ArticleModel;
+use Joomla\Component\Content\Site\Model\CategoryModel;
+use Joomla\CMS\MVC\Factory\MVCFactoryInterface;
+
+
 
 // phpcs:disable PSR1.Files.SideEffects
 \defined('_JEXEC') or die;
@@ -56,16 +62,6 @@ final class Opengraph extends CMSPlugin implements SubscriberInterface
      */
     protected $autoloadLanguage = true;
 
-    /**
-     * Database object
-     *
-     * The database is injected by parent constructor
-     *
-     * @var  DatabaseInterface
-     * @since  __DEPLOY_VERSION__
-     */
-    protected $db;
-
 
     /**
      * Returns an array of events this subscriber will listen to.
@@ -140,46 +136,64 @@ public function onBeforeCompileHead(BeforeCompileHeadEvent $event): void
     {
         $app = $this->app;
 
+
         if (!$app->isClient('site')) {
             return;
         }
 
+        /** @var HtmlDocument $document */
         $document = $app->getDocument();
 
         // Only process HTML documents
         if (!($document instanceof HtmlDocument)) {
             return;
         }
 
-        $input = $app->input;
-        $option = $input->get('option', '', 'cmd');
-        $view = $input->get('view', '', 'cmd');
-        $id = $input->getInt('id');
-
-        // Skip indexer and feed formats
-        if (($option . '.' . $view) === 'com_finder.indexer') {
-            return;
-        }
-
-        if ($input->get('format', '', 'cmd') === 'feed') {
+        $input  = $app->input;
+        if (
+            $input->getCmd('option') !== 'com_content'
+            || $input->getCmd('view')   !== 'article'
+            || ! $id = $input->getInt('id')
+        ) {
             return;
         }
-        // Check if plugin is enabled globally
+        // Plugin globally disabled?
         if (!$this->params->get('enable_og_generation', 1)) {
             return;
         }
-        $uniqueArticle = true;
-        if (is_array($input->get('id', 0, 'int'))) {
-            $uniqueArticle = false;
+
+        /** @var MVCComponent $component */
+        $component  = $app->bootComponent('com_content');
+
+        /** @var MVCFactoryInterface $mvcFactory */
+        $mvcFactory = $component->getMVCFactory();
+
+        $params = ComponentHelper::getParams('com_content');
+        // Fallback if for some reason it isn’t an object
+        if (! $params instanceof Registry) {
+            $params = new Registry;
         }
 
-        if ($uniqueArticle) {
-            $article = new Content($this->db);
-            $article->load($id);
-            $category = Table::getInstance('Category');
-            $category->load($article->catid);
+        /** @var ArticleModel $articleModel */
+        $articleModel = $mvcFactory->createModel('Article', 'Site', ['ignore_request' => true]);
+
+        $articleModel->setState('params', clone $params);
+        $articleModel->setState('article.id', $id);
+
+        $article = $articleModel->getItem($id);
+        if (! $article) {
+            return;
         }
 
+        /** @var CategoryModel $categoryModel */
+        $categoryModel = $mvcFactory->createModel(
+            'Category',
+            'Site',
+            ['ignore_request' => true]
+        );
+        $categoryModel->setState('category.id', $article->catid);
+        $category = $categoryModel->getCategory();
+
 
 
 
@@ -243,15 +257,16 @@ public function onBeforeCompileHead(BeforeCompileHeadEvent $event): void
      * @param array $articleImages The array of article images.
      * @param array $ogTags The array of OG tags.
      */
-    private function getOgTagsFromCategoryMappings(Registry $categoryParams, Content $article, array $articleImages, array &$ogTags): void
+    private function getOgTagsFromCategoryMappings(Registry $categoryParams, object $article, array $articleImages, array &$ogTags): void
     {
 
         foreach ($categoryParams as $key => $fieldName) {
             // Only process keys that start with 'og_'
             if (strpos($key, 'og_') === 0 && str_ends_with($key, '_field')) {
                 $ogTagName = substr($key, 0, -6); // Remove "_field" from the end
 
-                $ogTags[$ogTagName] = $this->getFieldValue($article, $fieldName, $articleImages);
+                $value = $this->getFieldValue($article, $fieldName, $articleImages);
+                $ogTags[$ogTagName] = $value;
             }
         }
     }
@@ -267,7 +282,7 @@ private function getOgTagsFromCategoryMappings(Registry $categoryParams, Content
      *
      * @return string
      */
-    private function getFieldValue(Content $article, string $fieldName, array $articleImages): string
+    private function getFieldValue(object $article, string $fieldName, array $articleImages): string
     {
         // Check if it's a custom field
         if (strpos($fieldName, 'field.') === 0) {