fix : forms now correclty save values in both category and article

Author: shahzan01

plugins/system/opengraph/src/Extension/opengraph.php

@@ -22,6 +22,7 @@
 use Joomla\CMS\Document\Document;
 use Joomla\CMS\Opengraph\OpengraphServiceInterface;
 use Joomla\CMS\Uri\Uri;
+use Exception;
 
 
 
@@ -124,34 +125,43 @@ public function onBeforeCompileHead(BeforeCompileHeadEvent $event): void
      */
     public function onContentPrepareForm(PrepareFormEvent $event): void
     {
-        $app = $this->getApplication();
+        $form    = $event->getForm();
+        $context = $form->getName();
+        $app     = $this->getApplication();
 
-        if (!$app->isClient('administrator')) {
+        if (!$app->isClient('administrator') || !$this->isSupported($context)) {
             return;
         }
 
-        $form = $event->getForm();
-        $context = $form->getName();
-        $component = $app->bootComponent('com_content');
-        if (!$component instanceof OpengraphServiceInterface) {
-            return;
-        }
+        $isCategory = $this->isCategoryContext($context);
+        $groupName  = $isCategory ? 'params' : 'attribs';
 
-        // Check if this is a category context - load mappings form first for categories
-        if ($this->isCategoryContext($context)) {
+        // Load and modify opengraphmappings.xml (only for categories)
+        if ($isCategory) {
             $mappingsXml = __DIR__ . '/../forms/opengraphmappings.xml';
             if (file_exists($mappingsXml)) {
-                $form->loadFile($mappingsXml, false);
+                try {
+                    $modifiedXml = $this->adjustFieldsGroup($mappingsXml, $groupName);
+                    $form->load($modifiedXml, false);
+                } catch (Exception $e) {
+                    error_log('OpenGraph Plugin: Failed to load mappings form: ' . $e->getMessage());
+                }
             }
         }
 
-        // Load the main OpenGraph form for all supported contexts
+        // Load and modify opengraph.xml
         $mainXml = __DIR__ . '/../forms/opengraph.xml';
         if (file_exists($mainXml)) {
-            $form->loadFile($mainXml, false);
+            try {
+                $modifiedXml = $this->adjustFieldsGroup($mainXml, $groupName);
+                $form->load($modifiedXml, false);
+            } catch (Exception $e) {
+                error_log('OpenGraph Plugin: Failed to load main form: ' . $e->getMessage());
+            }
         }
     }
 
+
     /**
      * Inject the OpenGraph data into the document.
      *
@@ -225,6 +235,40 @@ private function setOpenGraphImage(Document $document, ?string $image, ?string $
     }
 
 
+    /**
+     * Check if the current plugin should execute opengraph related activities
+     *
+     * @param   string  $context
+     *
+     * @return   boolean
+     *
+     * @since  __DEPLOY_VERSION__
+     */
+    protected function isSupported($context): bool
+    {
+        // @todo: will be changed in future to support other components
+
+
+
+        $supportedContexts = [
+            'com_content.article',
+            'com_categories.categorycom_content',
+        ];
+
+        if (!in_array($context, $supportedContexts, true)) {
+            return false;
+        }
+
+        //todo : currently we have interface in com_content only but we need to have it in other components
+
+        // $parts = explode('.', $context, 2);
+
+        // $component = $this->getApplication()->bootComponent($parts[0]);
+
+        // return $component instanceof OpengraphServiceInterface;
+
+        return true;
+    }
 
     /**
      * Check if the context is a category context.
@@ -243,4 +287,21 @@ private function isCategoryContext(string $context): bool
 
         return in_array($context, $categoryContexts, true);
     }
+
+    private function adjustFieldsGroup(string $filePath, string $newGroup): string
+    {
+        $xmlContent = file_get_contents($filePath);
+        $xml = simplexml_load_string($xmlContent);
+
+        if ($xml === false) {
+            throw new Exception("Could not load XML file: {$filePath}");
+        }
+
+        // Adjust all <fields> nodes to use the desired group
+        foreach ($xml->xpath('//fields') as $fields) {
+            $fields['name'] = $newGroup;
+        }
+
+        return $xml->asXML();
+    }
 }