fix : fix some bugs and modified the plugins settings page

Author: shahzan01

plugins/system/opengraph/opengraph.xml

@@ -29,17 +29,15 @@
     </languages>
     <config>
         <fields name="params">
-            <fieldset name="global_og_settings"
-                      label="PLG_SYSTEM_OPENGRAPH_GLOBAL_OG_SETTINGS"
-                      description="PLG_SYSTEM_OPENGRAPH_GLOBAL_DESC">
+            <fieldset name="basic">
                 <field name="enable_og_generation"
                        type="radio"
-                       class="btn-group btn-group-yesno"
+                       layout="joomla.form.field.radio.switcher"
                        default="1"
                        label="PLG_SYSTEM_OPENGRAPH_ENABLE_OG_GENERATION"
                        description="PLG_SYSTEM_OPENGRAPH_ENABLE_OG_GENERATION_DESC">
-                    <option value="0">JNO</option>
-                    <option value="1">JYES</option>
+                    <option value="0">JDISABLED</option>
+                    <option value="1">JENABLED</option>
                 </field>
                 <field name="fb_app_id"
                        type="text"
@@ -67,24 +65,6 @@
                        min="50"
                        max="200" />
             </fieldset>
-            <fieldset name="overview_help"
-                      label="PLG_SYSTEM_OPENGRAPH_OVERVIEW">
-                <field name="about_note"
-                       type="note"
-                       class="alert alert-info"
-                       label="PLG_SYSTEM_OPENGRAPH_FEATURES_LABEL"
-                       description="PLG_SYSTEM_OPENGRAPH_FEATURES_DESC" />
-                <field name="quickstart_note"
-                       type="note"
-                       class="alert alert-primary"
-                       label="PLG_SYSTEM_OPENGRAPH_QUICKSTART_LABEL"
-                       description="PLG_SYSTEM_OPENGRAPH_QUICKSTART_DESC" />
-                <field name="tips_note"
-                       type="note"
-                       class="alert alert-info"
-                       label="PLG_SYSTEM_OPENGRAPH_TIPS_LABEL"
-                       description="PLG_SYSTEM_OPENGRAPH_TIPS_DESC" />
-            </fieldset>
         </fields>
     </config>
 </extension>

plugins/system/opengraph/src/Extension/opengraph.php

@@ -143,7 +143,7 @@ public function onContentPrepareForm(PrepareFormEvent $event): void
                 $categoryId = (int) $article->catid;
             }
         }
-
+        $catParams = new Registry();
         if ($categoryId > 0) {
             /** @var MVCComponent $catComponent */
             $catComponent = $app->bootComponent('com_categories');
@@ -158,7 +158,9 @@ public function onContentPrepareForm(PrepareFormEvent $event): void
             $catParams = new Registry($category->params ?? '{}');
         }
 
-
+        if (!$catParams) {
+            return;
+        }
         // Get the mappings from the category params
         $mappings = [];
         foreach ($catParams as $paramKey => $fieldName) {
@@ -265,9 +267,7 @@ public function onBeforeCompileHead(BeforeCompileHeadEvent $event): void
             ['ignore_request' => true]
         );
         $categoryModel->setState('category.id', $article->catid);
-        $category = $categoryModel->getItem($article->catid);
-
-
+        $category = $categoryModel->getCategory();
 
 
         // Get menu parameters