Add strict locators to Joomla Installation

Author: javigomez

src/JoomlaBrowser.php

@@ -86,48 +86,48 @@ public function installJoomla()
         $I->waitForText('Main Configuration', 10,['xpath' => '//h3']);
 
         $this->debug('I click Language Selector');
-        $I->click("//div[@id='jform_language_chzn']/a"); // Language Selector
+        $I->click(['xpath' => "//div[@id='jform_language_chzn']/a"]); // Language Selector
         $this->debug('I select en-GB');
-        $I->click("//li[text()='English (United Kingdom)']"); // English (United Kingdom)
-        sleep(1);
+        $I->click(['xpath' => "//li[text()='English (United Kingdom)']"]); // English (United Kingdom)
+        $I->wait(1);
         $this->debug('I fill Site Name');
-        $I->fillField('Site Name', 'Joomla CMS test');
+        $I->fillField(['id' => 'jform_site_name'], 'Joomla CMS test');
         $this->debug('I fill Site Description');
-        $I->fillField('Description', 'Site for testing Joomla CMS');
+        $I->fillField(['id' => 'jform_site_metadesc'], 'Site for testing Joomla CMS');
 
         // I get the configuration from acceptance.suite.yml (see: tests/_support/acceptancehelper.php)
         $this->debug('I fill Admin Email');
-        $I->fillField('Admin Email', $this->config['admin email']);
+        $I->fillField(['id' => 'jform_admin_email'], $this->config['admin email']);
         $this->debug('I fill Admin Username');
-        $I->fillField('Admin Username', $this->config['username']);
+        $I->fillField(['id' => 'jform_admin_user'], $this->config['username']);
         $this->debug('I fill Admin Password');
-        $I->fillField('Admin Password', $this->config['password']);
+        $I->fillField(['id' => 'jform_admin_password'], $this->config['password']);
         $this->debug('I fill Admin Password Confirmation');
-        $I->fillField('Confirm Admin Password', $this->config['password']);
+        $I->fillField(['id' => 'jform_admin_password2'], $this->config['password']);
         $this->debug('I click Site Offline: no');
-        $I->click("//fieldset[@id='jform_site_offline']/label[2]"); // ['No Site Offline']
+        $I->click(['xpath' => "//fieldset[@id='jform_site_offline']/label[2]"]); // ['No Site Offline']
         $this->debug('I click Next');
-        $I->click('Next');
+        $I->click(['link' => 'Next']);
 
         $this->debug('I Fill the form for creating the Joomla site Database');
         $I->waitForText('Database Configuration', 10,['css' => 'h3']);
 
         $this->debug('I select MySQLi');
-        $I->selectOption('#jform_db_type', $this->config['database type']);
+        $I->selectOption(['id' => 'jform_db_type'], $this->config['database type']);
         $this->debug('I fill Database Host');
-        $I->fillField('Host Name', $this->config['database host']);
+        $I->fillField(['id' => 'jform_db_host'], $this->config['database host']);
         $this->debug('I fill Database User');
-        $I->fillField('Username', $this->config['database user']);
+        $I->fillField(['id' => 'jform_db_user'], $this->config['database user']);
         $this->debug('I fill Database Password');
-        $I->fillField('Password', $this->config['database password']);
+        $I->fillField(['id' => 'jform_db_pass'], $this->config['database password']);
         $this->debug('I fill Database Name');
-        $I->fillField('Database Name', $this->config['database name']);
+        $I->fillField(['id' => 'jform_db_name'], $this->config['database name']);
         $this->debug('I fill Database Prefix');
-        $I->fillField('Table Prefix', $this->config['database prefix']);
+        $I->fillField(['id' => 'jform_db_prefix'], $this->config['database prefix']);
         $this->debug('I click Remove Old Database ');
-        $I->click("//label[@for='jform_db_old1']"); // Remove Old Database button
+        $I->click(['xpath' => "//label[@for='jform_db_old1']"]); // Remove Old Database button
         $this->debug('I click Next');
-        $I->click('Next');
+        $I->click(['link' => 'Next']);
 
         $this->debug('I install joomla with or without sample data');
         $I->waitForText('Finalisation', 10, ['xpath' => '//h3']);
@@ -139,8 +139,8 @@ public function installJoomla()
         //    $this->debug('I install Joomla without Sample Data');
         //    $I->selectOption('#jform_sample_file', '#jform_sample_file0'); // No sample data
         //endif;
-        $I->selectOption('#jform_sample_file', '#jform_sample_file0'); // No sample data
-        $I->click('Install');
+        $I->selectOption(['id' => 'jform_sample_file'], ['id' => 'jform_sample_file0']); // No sample data
+        $I->click(['link' => 'Install']);
 
         // Wait while Joomla gets installed
         $this->debug('I wait for Joomla being installed');